Re: [MMUSIC] AD Evaluation of draft-ietf-mmusic-sctp-sdp-21 - TECHNICAL comments

Christer Holmberg <christer.holmberg@ericsson.com> Sat, 21 January 2017 20:26 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F591129C62; Sat, 21 Jan 2017 12:26:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.221
X-Spam-Level:
X-Spam-Status: No, score=-4.221 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GXIgIbakvsvX; Sat, 21 Jan 2017 12:26:07 -0800 (PST)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9576E126579; Sat, 21 Jan 2017 12:26:06 -0800 (PST)
X-AuditID: c1b4fb3a-d001d98000007c71-10-5883c3dcd45a
Received: from ESESSHC008.ericsson.se (Unknown_Domain [153.88.183.42]) by (Symantec Mail Security) with SMTP id 9A.13.31857.CD3C3885; Sat, 21 Jan 2017 21:26:04 +0100 (CET)
Received: from ESESSMB209.ericsson.se ([169.254.9.76]) by ESESSHC008.ericsson.se ([153.88.183.42]) with mapi id 14.03.0319.002; Sat, 21 Jan 2017 21:23:04 +0100
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Ben Campbell <ben@nostrum.com>, "draft-ietf-mmusic-sctp-sdp.all@ietf.org" <draft-ietf-mmusic-sctp-sdp.all@ietf.org>, mmusic <mmusic@ietf.org>, Roman Shpount <roman@telurix.com>
Thread-Topic: AD Evaluation of draft-ietf-mmusic-sctp-sdp-21 - TECHNICAL comments
Thread-Index: AdJ0ILFiibP8Bb/uTmOrMFLsPov7fA==
Date: Sat, 21 Jan 2017 20:23:04 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B4BF9A860@ESESSMB209.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.150]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsUyM2K7lu6dw80RBh8OCFrM7zzNbrGpfxOL xdTlj1ksZlyYyuzA4rFkyU8mj1k7n7B43JpSEMAcxWWTkpqTWZZapG+XwJVxamEXa0GPSMXe L4tYGxgP8HcxcnJICJhInF35kK2LkYtDSGAdo8TSa3MZIZzFjBKfXp0EynBwsAlYSHT/0waJ iwjsYpT4eGMDO0i3sECQxPdn61hAbBGBYIl/c7awQdh6EkeWL2cE6WURUJU43c4BEuYV8JXo WNXICmIzCohJfD+1hgnEZhYQl7j1ZD4TxEECEkv2nGeGsEUlXj7+xwphK0ms2H6JEaJeR2LB 7k9sELa2xLKFr5kh5gtKnJz5hGUCo9AsJGNnIWmZhaRlFpKWBYwsqxhFi1OLi3PTjYz0Uosy k4uL8/P08lJLNjECQ//glt9WOxgPPnc8xCjAwajEw2sQ1xQhxJpYVlyZe4hRgoNZSYQ3Fhg5 QrwpiZVVqUX58UWlOanFhxilOViUxHnNVt4PFxJITyxJzU5NLUgtgskycXBKNTB2GO2b9UPi 58qboacv6um/CKuVTUtQFDt8TfAwE4fNPUWPV/tk75u8v80q0tVs3vumO0/fucayN+/Kcfta ge+tX6XNyxfX3utJWP9W+t/Bk2LVHDJSBsxhvKu+XbpceDTkm4fQkW2vdCJDTuoKnqlqDE7+ cOgQ+wUxruwnui/MLXyDMpozDyixFGckGmoxFxUnAgDngh/4eQIAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/7ucY-G0-qmP6qP1ORUZbybBbYro>
Subject: Re: [MMUSIC] AD Evaluation of draft-ietf-mmusic-sctp-sdp-21 - TECHNICAL comments
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jan 2017 20:26:09 -0000

Hi,

Below are my replies to Ben's technical comments.

----------------
Substantive Comments

> -1, first paragraph: RFC 5572-update is currently in IETF LC. Is there a reason not to reference it instead?

I assume you mean 4572-update :)

I agree that we should reference that spec instead, and I'll fix that.

----

> -4.1, last paragraph:
> I assume this paragraph refers to fmt values used with UDP/DTLS/SCTP or TCP/DTLS/SCTP, 
> not fmt values in general.

Correct. 

> It would help to be explicit about that.

The first sentence in section 4.1 does say:

   "This section defines the following new SDP Media Description (m-
   line) protocol identifiers (proto values) for describing an SCTP
   association: 'UDP/DTLS/SCTP' and 'TCP/DTLS/SCTP'."

> (Also, it seem like this paragraph belongs in section 4.3).

I could move and combine it with the 4th paragraph of section 4.3:

   "The m- line fmt value, identifying the application-layer protocol,
   MUST be registered by IANA. Section 15.3 defines the IANA registry 
   for the media format namespace."

----

> -4.5: The example is missing the sctp-port attribute.

I'll add it.

----

> -5.3: Why is the mux-category SPECIAL rather than CAUTION? IIUC, SPECIAL means you need to refer
> to the rules in the protocol definition. But the text here basically say that the rules are undefined.

I'm ok using CAUTION. I agree it might be more appropriate than SPECIAL.

----

> -6.1: What is meant by saying an "endpoint MUST assume that larger ... 
> will be rejected"? Can that be stated in terms of actual procedure (e.g. 
> "endpoint MUST NOT send...larger"?

I'd like Roman's input on this, in case he had some cases in mind where endpoint will have to send larger messages.

I guess we could say SHOULD NO send larger message, and explain that one cannot assume that larger message (if sent for whatever reason) will be accepted by the peer.

----

> -6.2, "Purpose" field: Please include the unit here, too.

I'll change to "maximum message size (indicated in bytes) that..."
                                 
----

> -9.1, 2nd paragraph: Don't the lower layers need to be established before the
> upper layers? Won't removal of the TCP connection or DTLS association break 
> an existing SCTP association?

Roman had lots of input on this, so I'll let him reply.

----

> -18.2: Seems like RFC0793 and RFC6544 should be normative references.

I'll fix that.

Regards,

Christer