Re: [MMUSIC] AD Review: draft-ietf-mmusic-t140-usage-data-channel - the pull request
Christer Holmberg <christer.holmberg@ericsson.com> Fri, 24 January 2020 15:08 UTC
Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C56551201DC; Fri, 24 Jan 2020 07:08:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.002
X-Spam-Level:
X-Spam-Status: No, score=-2.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bhSw4MoSTRBS; Fri, 24 Jan 2020 07:08:51 -0800 (PST)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 97F9B12018B; Fri, 24 Jan 2020 07:08:51 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H9EDoPGvtKuVfvkI8Qawo8v9X5G09gBYQGHuSCxt/NSY5/8UkkFcvtgyNltbZnCTNOUrc1vHdhf/vsI3RE/zAY86TQVQxVhLK7zhGpe7+Lbt0XcHO6GDAUd2F0f6x3uRtGrZdfxwAfBRsLozQsokx+1ohwUIH6uu2/GZQSIfKo+XwHPzxKejt6SKQ1C/EYTXgX+TifnUg+fWfV2JX6V7EdU1XQBS4Zfofdna7LB3NSFIbodYsY3RgL7KL6wrgdkgxsVZRRm/5vcSXL4MMIrBrSJYw5Lb6jcev6oGyKls9EMH3SQoJ+Lq4A3NR+nEKvGbcpnMvQJvGthDut3ALB82Ww==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OfvLIsXFDvJvhbPyK//2LzEbv7uIcqPbxU/L4s14mII=; b=BoXiqeUJKeaA0tNV6/BPBOFb9XVr4Mp+a0Oz+bNbp/7q4IW4gLEI7x9f3LN6am3B5+onS4OreUjN7tozJ5MDm5HOCdOIrVQu3nHF/lJGSUXh7RQ7yw0o3Jgj7+bevaA6miLzayJrQ7T3WWqNyiGOHOxpnTuBdTOJnxYWWYtwU1219zKQCZGp5TqZVvij0deAVf4uvrrlqWEYL7z+/lWihyTSP9my6wxJvxKoHs5/2tBe6A9vmSS+Yb2vvSjphBuyTXiaAyLgWpNySZJFwRMSysNCMeEzuaHCnbqkj7iS9BttDG1iQ4452re5pm0EBEk+Z6EPihvzNPL5bd9Tq3p4sg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OfvLIsXFDvJvhbPyK//2LzEbv7uIcqPbxU/L4s14mII=; b=PwGueeziAxevOwLzcZw8KFK0yh+hc7xvtNeEdDXUPXlGZDflJNUgPXzYYziGc8WJMPlk3kOOuFn7tMff5RnSdy4V8jfQEI3OOq3zlCRW4BdIJDctUbhPqHe8B0YRxta5OLNy4k9BZ5LEwZ5VYPL3776SLLnTztJ/c5Wx7jKJgEo=
Received: from AM0PR07MB3987.eurprd07.prod.outlook.com (52.134.82.159) by AM0PR07MB5649.eurprd07.prod.outlook.com (20.178.113.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.10; Fri, 24 Jan 2020 15:08:49 +0000
Received: from AM0PR07MB3987.eurprd07.prod.outlook.com ([fe80::28e8:93ab:34a6:c38d]) by AM0PR07MB3987.eurprd07.prod.outlook.com ([fe80::28e8:93ab:34a6:c38d%3]) with mapi id 15.20.2686.013; Fri, 24 Jan 2020 15:08:49 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Adam Roach <adam@nostrum.com>, "draft-ietf-mmusic-t140-usage-data-channel.all@ietf.org" <draft-ietf-mmusic-t140-usage-data-channel.all@ietf.org>, "mmusic@ietf.org" <mmusic@ietf.org>
Thread-Topic: AD Review: draft-ietf-mmusic-t140-usage-data-channel - the pull request
Thread-Index: AQHV0sgudsqwKtROiEW86rimS8k5bQ==
Date: Fri, 24 Jan 2020 15:08:49 +0000
Message-ID: <4F482AAE-687E-49A2-A9AB-3B2B35B08694@ericsson.com>
Accept-Language: en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1e.0.191013
authentication-results: spf=none (sender IP is ) smtp.mailfrom=christer.holmberg@ericsson.com;
x-originating-ip: [89.166.49.243]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 718db2e2-0f9b-433c-cbd4-08d7a0df512b
x-ms-traffictypediagnostic: AM0PR07MB5649:
x-microsoft-antispam-prvs: <AM0PR07MB56491D5A00DB6D1B53F3531E930E0@AM0PR07MB5649.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 02929ECF07
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(189003)(199004)(36756003)(966005)(6512007)(478600001)(6486002)(81166006)(81156014)(8676002)(8936002)(86362001)(186003)(44832011)(6506007)(71200400001)(26005)(5660300002)(316002)(76116006)(2616005)(2906002)(110136005)(66556008)(64756008)(66946007)(33656002)(66476007)(66446008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR07MB5649; H:AM0PR07MB3987.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: T9qZgTkDIM208AMeL5C1k4LAYdx6FOsB+SAU826Ct6A2zsSLSZeggg7Hri+s1LSqqzpSpfyDiCbgtMg/UjBgbp5ldpcLPRXiQLZ3HAD7V/h3nnRWf0r9bY/JIER0PcTjztR1MM3flvwtTrlBaF/acERnhXCKVhU/Da1C7AYLUpijKLWx9F0gGJVzwYjZLwlPbPTtS9E75SQnzroWOGAnVVQk4B1VWAGPq7Jz69aKMfGyEEhC+2sDg6n7ws7Re1o/8jAOYXVTLlsMUpE3q3bL2MnF+dvBscR12Ye7/W2PrXY6Li25gJLhihIdvg1GpCSXSMGtiiq4ywYTHWt+Aj6n6CQ4DniXNfreBK+HCwc/lHeQeKD0//C8lXwtUPLggKm5L1cAZ7+fh0cce4Qu3V0+Vw9Zfyp3iO6a1tIbgprT+3mfWtvG+cl4KNnAaVrnkOYDkJM6so6lE4KU/ljesTEzVIfqqAb67EfoT0nqmEtnieU=
x-ms-exchange-antispam-messagedata: LLzp2kCYJE+Tt6VmFs+pjiSNFMviEiaR1lnpMBvPScvU5snp+cz02bB0MTpRHzkHOSgePVo4K253VZZUBpxBvH0xARax4J+ANbSNPCQZZc2Kl3xHkTRz7xlz40ZvmAA9hBxocreyR3XIS6dCOsvq4g==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <53558A96A1CF0F4CAAEBB45A7F1169BB@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 718db2e2-0f9b-433c-cbd4-08d7a0df512b
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2020 15:08:49.5510 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nZ464qUHsFwEKt30uXxO3/U4nov0Hz1y2OvMpwycPkbXNkRlenjFR1MqyfIpcjZ8RoQdCVYQDPi+7cxRN60Xhu8Tj08s3kjY5LpXc4fOIr4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB5649
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/DDLVdRFF0GSTSajfWnuO6xaaZik>
Subject: Re: [MMUSIC] AD Review: draft-ietf-mmusic-t140-usage-data-channel - the pull request
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Jan 2020 15:08:54 -0000
Hi, Based on Adam's AD review, I have created a pull request. https://github.com/cdh4u/draft-datachannel-t140/pull/55 Adam indicated that I could implement the changes together with the changes based on the IETF last-call comments. But, assuming people are ok with the changes, I'd like to merge the PR and submit a new version for the IESG to review. Regards, Christer On 24/01/2020, 15.10, "Christer Holmberg" <christer.holmberg@ericsson.com> wrote: Hi, --------------------------------------------------------------------------- >> §4.1: >> >> The offerer and answerer MUST NOT include the max-retr and max-time >> attribute parameters in the 'dcmap' attribute. >> >> Ideally, this would include text that indicates what a recipient of such >> messages would do (with the obvious choices being ignoring them or treating >> them as an error). I suggest the easiest thing to specify is that recipients >> of either attribute for a T.140 section MUST ignore them. >> >> Just to note: >> >> - The draft defines that the T.140 data channel is reliable. >> - max-retr and max-time are used to indicate that a data channel is partially reliable, so there would be a conflict. >> >> So, the question is whether it is ok to just ignore, or whether it is a protocol error and the m- line therefore should be rejected. >> >> If *both* attribute parameters are included in an offer (which would also create a conflict), draft-channel-sdpneg says that the offer must be rejected. > > Given this last fact, it seems that the best approach would be to treat > the presence of either parameter in this context as an error. The key > here is that the behavior should be spelled out. I suggest the following: OLD: The offerer and answerer MUST NOT include the max-retr and max-time attribute parameters in the 'dcmap' attribute. NEW: The offerer and answerer MUST NOT include the max-retr and max-time attribute parameters in the 'dcmap' attribute. If any of the attribute parameters are included in an offer or answer, the receiver MUST take the proper actions to reject the SDP. --------------------------------------------------------------------------- Regards, Christer
- Re: [MMUSIC] AD Review: draft-ietf-mmusic-t140-us… Christer Holmberg
- Re: [MMUSIC] AD Review: draft-ietf-mmusic-t140-us… Gunnar Hellström