Re: [MMUSIC] Roman Danyliw's Discuss on draft-ietf-mmusic-ice-sip-sdp-37: (with DISCUSS and COMMENT)

Adam Roach <adam@nostrum.com> Wed, 07 August 2019 19:27 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E92111206EF; Wed, 7 Aug 2019 12:27:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.679
X-Spam-Level:
X-Spam-Status: No, score=-1.679 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PIokYZxyLE6i; Wed, 7 Aug 2019 12:27:44 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6D2561206EE; Wed, 7 Aug 2019 12:27:37 -0700 (PDT)
Received: from Orochi.local (c-24-9-76-58.hsd1.co.comcast.net [24.9.76.58]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id x77JRSjW074645 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 7 Aug 2019 14:27:30 -0500 (CDT) (envelope-from adam@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1565206051; bh=m1s9ZyAH7eA3V0OdRsK0TfVHi2tJLsJhjOQxgOBNG9Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=PKX3OT2Yeh8xrE+R5uVYtBC/08ks3LMh3yHXllVWJSvIrFirqJJFKfeNxhXiKqtyW B8Ulg2CX5qYqUWvx9jAAapvneHnTYKDojy+VAovb7RDCPqRcEgeZy1fuHj1DMPoT0W pzbeoRYi+8vVgc5L1m5tWrmczXh6n1Byffjna87k=
X-Authentication-Warning: raven.nostrum.com: Host c-24-9-76-58.hsd1.co.comcast.net [24.9.76.58] claimed to be Orochi.local
To: Roman Danyliw <rdd@cert.org>, The IESG <iesg@ietf.org>
Cc: fandreas@cisco.com, mmusic-chairs@ietf.org, mmusic@ietf.org, draft-ietf-mmusic-ice-sip-sdp@ietf.org
References: <156505852285.2142.10774832459273251927.idtracker@ietfa.amsl.com>
From: Adam Roach <adam@nostrum.com>
Message-ID: <d9877c1a-e36e-7e53-ce72-433f23090687@nostrum.com>
Date: Wed, 07 Aug 2019 14:27:23 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <156505852285.2142.10774832459273251927.idtracker@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/LWNhA8K4NRrMLeX4XkIgo3q3wH4>
Subject: Re: [MMUSIC] Roman Danyliw's Discuss on draft-ietf-mmusic-ice-sip-sdp-37: (with DISCUSS and COMMENT)
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Aug 2019 19:27:45 -0000

I'm not generally around this week, but had a few moments and wanted to 
weigh in on these discuss points, as they don't appear to have responses 
yet. :)

On 8/5/19 21:28, Roman Danyliw via Datatracker wrote:
> (1) Section 8.1. Per “These require techniques for message integrity and
> encryption for offers and answers, which are satisfied by the TLS mechanism
> [RFC3261] when SIP is used”, the guidance is right (use TLS), but this
> reference is outdated.  Section 26.2.1 of RFC3261 provides rather old guidance
> on the ciphersuite.  Is there a reason why not to use BCP195 for guidance on
> versions/ciphersuites?


As much as SIP has a convoluted layering story, the separation between 
SIP and SDP remains pretty clean (both from a protocol perspective and 
organizationally within the IETF). While it's likely the case that RFC 
3261 could use some updating to its security story [1], I don't think it 
makes sense to hold up this document on that work. It's really rather 
far outside the purview of this document to make changes to the 
underlying cipher suite; in fact, I would argue that doing so would be 
disallowed in MMUSIC, since it is part of the core protocol work that 
clearly falls in SIPCORE's charter.


> (2) Section 8.2.1, The “voice hammer attack” appears to be an artifact of SDP.
> The text explicitly notes that this attack is not “specific to ICE but that ICE
> can help provide a remediation” (aside, should “remediation” be “mitigation”).
> However, the preceding introductory section (8.2) explicitly says “there are
> several attacks possible with ICE”.  These two statements aren’t consistent.


It seems that the solution for this would be to promote section 8.2.1 to 
its own top-level section inside the security considerations section. 
Would that work for you?


> (3) Section 8.2.2.  This section reads like an operational consideration.  The
> setup scoped in the parent Section 8.2, “there are several attacks possible
> with ICE when the attacker is an authenticated and valid participant in the ICE
> exchange”, isn’t discussed here (i.e., how is the presence or absence of an ALG
> germane to an attacker who is a participant in the ICE exchange)


It seems that the solution for this would be to promote 8.2.2 to its own 
top-level section within the document, preceding the Security 
Considerations section, possibly with a renaming along the lines of 
"Operational Considerations: Interactions with Application Layer 
Gateways and SIP". Does that work for you?

I note that making both of these changes leaves section 8.2 empty save 
for the introductory text; I propose that we simply remove the section.


> (4) Section 8.  Is there a reason why the security considerations from RFC8445
> are not noted as also applying (e.g., Section 19.1 - .4.

Would the addition of text at the top of section 8 that says "Please 
note that the security considerations from sections 19.1 through 19.4 of 
[RFC8445] also apply to this document." address your concern?

/a

____
[1] And there is some work happening in this area, albeit not with TLS; 
see https://datatracker.ietf.org/doc/draft-ietf-sipcore-digest-scheme/ 
for example.