Re: [MMUSIC] I-D Action: draft-ietf-mmusic-ice-sip-sdp-30.txt

Flemming Andreasen <fandreas@cisco.com> Sat, 01 June 2019 23:06 UTC

Return-Path: <fandreas@cisco.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E84BD120045 for <mmusic@ietfa.amsl.com>; Sat, 1 Jun 2019 16:06:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.509
X-Spam-Level:
X-Spam-Status: No, score=-14.509 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f4ccmUQP-A4z for <mmusic@ietfa.amsl.com>; Sat, 1 Jun 2019 16:06:16 -0700 (PDT)
Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A58C11200CE for <mmusic@ietf.org>; Sat, 1 Jun 2019 16:06:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=9458; q=dns/txt; s=iport; t=1559430376; x=1560639976; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to; bh=LImOkO8lzuva1fyh12DL5xlCjHYPmhQISt10dPYZxfc=; b=aXmpbzxrpsFI5nG2pWOMPTq6wtsvu/PrTdzxexT7w0D0f/jRvNFkgnBm teEe482YAh851IF8ibqkwsiKH5dCOBeamUMazAat57vsDR+Z9ml6Wcqld 0mTIcjjnnzSp/OVb8Hfm5zRMbfk/SqoCgF9x3y+V8zr9c0mIjkUdHt9Hs 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AHAAD3A/Nc/5RdJa1lGgEBAQEBAgEBAQEHAgEBAQGBUQUBAQEBCwGCEGlRATIohBSIHIxTJYlQiQ2GAIF7CQEBAQ4YAQoMAQGDekYCgwQjNAkOAQMBAQQBAQIBBG0cDIVLAQEEAQEhSwsQCQIYJwMCAicfEQYBDAYCAQGDHgGBdhQPjXqbaoEvH4QXAg5BQIMegUaBNAGLWReBQD+BEScMgl8+gmEBAQIBARaEUYJYBKh5CYIPhj+MbQYbgiJohgmDWyeJWY0AhwuPO4FPOIFYTSMVGiGCbAmCEheIYYVbIwMwkAcBAQ
X-IronPort-AV: E=Sophos;i="5.60,540,1549929600"; d="scan'208,217";a="280842028"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 01 Jun 2019 23:06:15 +0000
Received: from [10.118.10.19] (rtp-fandreas-2-8812.cisco.com [10.118.10.19]) by rcdn-core-12.cisco.com (8.15.2/8.15.2) with ESMTP id x51N6EIX013575; Sat, 1 Jun 2019 23:06:15 GMT
To: Suhas Nandakumar <suhasietf@gmail.com>, mmusic WG <mmusic@ietf.org>
References: <155939048775.17273.13936885338207300192@ietfa.amsl.com> <CAMRcRGQpzMtmWYXEtq0oDp=1J52eXFWiGxX_vJLaOUuhNMWtGg@mail.gmail.com>
From: Flemming Andreasen <fandreas@cisco.com>
Message-ID: <d77b3cbf-1e59-3602-91ff-d7afa058b3c4@cisco.com>
Date: Sat, 01 Jun 2019 19:06:14 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <CAMRcRGQpzMtmWYXEtq0oDp=1J52eXFWiGxX_vJLaOUuhNMWtGg@mail.gmail.com>
Content-Type: multipart/alternative; boundary="------------670E8059610FD6E5EE31DE89"
Content-Language: en-US
X-Outbound-SMTP-Client: 10.118.10.19, rtp-fandreas-2-8812.cisco.com
X-Outbound-Node: rcdn-core-12.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/Tmhli6ymOXWxogcZeb6raFjfVt8>
Subject: Re: [MMUSIC] I-D Action: draft-ietf-mmusic-ice-sip-sdp-30.txt
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Jun 2019 23:06:19 -0000

Thank you for the updated document Suhas. I have read through it and it 
generally looks good to me. One question though:

Section 3.3.4 says:
<quote>

    Once the state of each check list is Completed, and if the agent is
    the controlling agent, it nominates a candidate pair [RFC8445] and
    checks for each data stream whether the nominated pair matches the
    default candidate pair.  If there are one or more data streams with a
    match, and the peer did not indicate support for the 'ice2' ice-
    option, the controlling agent MUST generate a subsequent offer
    (Section 3.4.1), in which the connection address, port and transport
    protocol in the "c=" and "m=" lines associated with each data stream
    match the corresponding local information of the nominated pair for
    that data stream.
</quote>

In the second sentence, shouldn't it rather be if there is a line with a 
mismatch instead of a match ?

Thanks

-- Flemming



On 6/1/19 8:02 AM, Suhas Nandakumar wrote:
> Version 30 address answerer ice-mismatch clarification suggestions
>
> Thanks
> Suhas
>
> On Sat, Jun 1, 2019 at 5:31 PM <internet-drafts@ietf.org 
> <mailto:internet-drafts@ietf.org>> wrote:
>
>
>     A New Internet-Draft is available from the on-line Internet-Drafts
>     directories.
>     This draft is a work item of the Multiparty Multimedia Session
>     Control WG of the IETF.
>
>             Title           : Session Description Protocol (SDP)
>     Offer/Answer procedures for Interactive Connectivity Establishment
>     (ICE)
>             Authors         : Marc Petit-Huguenin
>                               Suhas Nandakumar
>                               Ari Keranen
>             Filename        : draft-ietf-mmusic-ice-sip-sdp-30.txt
>             Pages           : 42
>             Date            : 2019-06-01
>
>     Abstract:
>        This document describes Session Description Protocol (SDP) Offer/
>        Answer procedures for carrying out Interactive Connectivity
>        Establishment (ICE) between the agents.
>
>
>     The IETF datatracker status page for this draft is:
>     https://datatracker.ietf.org/doc/draft-ietf-mmusic-ice-sip-sdp/
>
>     There are also htmlized versions available at:
>     https://tools.ietf.org/html/draft-ietf-mmusic-ice-sip-sdp-30
>     https://datatracker.ietf.org/doc/html/draft-ietf-mmusic-ice-sip-sdp-30
>
>     A diff from the previous version is available at:
>     https://www.ietf.org/rfcdiff?url2=draft-ietf-mmusic-ice-sip-sdp-30
>
>
>     Please note that it may take a couple of minutes from the time of
>     submission
>     until the htmlized version and diff are available at
>     tools.ietf.org <http://tools.ietf.org>.
>
>     Internet-Drafts are also available by anonymous FTP at:
>     ftp://ftp.ietf.org/internet-drafts/
>
>     _______________________________________________
>     mmusic mailing list
>     mmusic@ietf.org <mailto:mmusic@ietf.org>
>     https://www.ietf.org/mailman/listinfo/mmusic
>