[MMUSIC] Roman Danyliw's Discuss on draft-ietf-mmusic-sdp-uks-06: (with DISCUSS and COMMENT)

Roman Danyliw via Datatracker <noreply@ietf.org> Tue, 06 August 2019 02:24 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: mmusic@ietf.org
Delivered-To: mmusic@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B305B1200E9; Mon, 5 Aug 2019 19:24:24 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Roman Danyliw via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-mmusic-sdp-uks@ietf.org, Bo Burman <bo.burman@ericsson.com>, mmusic-chairs@ietf.org, bo.burman@ericsson.com, mmusic@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.100.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Roman Danyliw <rdd@cert.org>
Message-ID: <156505826472.2103.10624716680930395268.idtracker@ietfa.amsl.com>
Date: Mon, 05 Aug 2019 19:24:24 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/cIy0TSZtesSzqNcl8Rc4W0m5x5Q>
Subject: [MMUSIC] Roman Danyliw's Discuss on draft-ietf-mmusic-sdp-uks-06: (with DISCUSS and COMMENT)
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Aug 2019 02:24:25 -0000

Roman Danyliw has entered the following ballot position for
draft-ietf-mmusic-sdp-uks-06: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-mmusic-sdp-uks/



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

(1) Section 3.2.  There are a few places where further clarity on error
handling would be helpful:

-- Per “A peer that receives an "external_id_hash" extension that does not
match the value of the identity binding from its peer MUST immediately fail the
TLS handshake with an error”, which TLS error alert?

-- Per “A peer that receives an identity binding, but does not receive an
‘external_id_hash’extension MAY choose to fail the connection”, if it does
“fail the connection”, with which error alert?


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

(2) I support Ben’s DISCUSS on the clarity of Section 3.2. I would add a few
additional observations:

** Per the sentence, “The resulting string is then encoded using UTF-8”,
shouldn’t this JSON text already be UTF-8 per Section 8.1 of RFC8259 -- what’s
the new encoding to be done?

** Recommend a citation for the WebRTC identity assertion, SDP identity
attribute and PASSPoRT formats earlier than the last sentence of the relevant
paragraph

(3) Section 3.2.  The second “Note” in this section likely is meant to be
generic guidance regardless of whether SDP or PASSPoRT is used.  However, since
the first “Note” only applies to SDP, it could be read that this crypto agility
guidance only applies to PASSPoRT.  Recommend using a different convention.

(4) Section 3.  Per “Neither SIP nor WebRTC identity providers are not required
to perform this validation”, this sentence has a triple negative (i.e.,
neither, nor and not).  Please rephrase to clarify that these providers are
required to validate.