IETF Logo Mail Archive

Re: [MMUSIC] AD Review: draft-ietf-mmusic-sdp-uks

"Martin Thomson" <mt@lowentropy.net> Wed, 05 June 2019 23:01 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EEC43120025 for <mmusic@ietfa.amsl.com>; Wed, 5 Jun 2019 16:01:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b=aRjhWCts; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=vDsMDpTS
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JWPVCEXBaJoK for <mmusic@ietfa.amsl.com>; Wed, 5 Jun 2019 16:01:26 -0700 (PDT)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A35EF12009E for <mmusic@ietf.org>; Wed, 5 Jun 2019 16:01:25 -0700 (PDT)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 034E020FBE for <mmusic@ietf.org>; Wed, 5 Jun 2019 19:01:25 -0400 (EDT)
Received: from imap2 ([10.202.2.52]) by compute1.internal (MEProxy); Wed, 05 Jun 2019 19:01:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type:content-transfer-encoding; s=fm2; bh=a6Hwj af+fzcQp3JDdAKLTBrqS9OuZEJR0twTl8haC/8=; b=aRjhWCts7nVdV0FRws2Fz dQ8OLAS3Lj/rQbyVsZNlzL+HkuY6epeIcTTnEV21ueOy5RobNu6gI8+D0u91+Qtu Pa2xzBc3X/Oie2dDrlzs+A42GRjKRLT1cRq/QoEdSbzbf2/4dyFpRoTKjzFMgw/b g1jnlUY/1DueAFO06s1jsZtgfUG6E3k8GvuaneTy6Ulbx7t+l1WMFJyV3ShzOM27 IYRt1mNNyOgJRNjtZVOwb8kQpDFe9Oc1v60Lz7pOHDMT3rkAIp49veY/OWOFH28Q xhsQIqsg7pKnu0tIUo/RyJBEMoLSb0eLTHgufUyWSemeB9M1yHrDB3P2ISsZ/RyG w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=a6Hwjaf+fzcQp3JDdAKLTBrqS9OuZEJR0twTl8haC /8=; b=vDsMDpTSJDXGHAZzCjSFEX96E5wxux3L03+z0FSjp5vBLjAx/hVTMizDg woPHdSw/xEcFaHlDd+3Q608iuLsphrJTPYCJpbGMK1/SnfLOg2E05hrs6u5H0eSr yrrIXeWv+/08/KIOHfci5muSuN6EBTJT1A6whbE6Mhz7dPAJIARx7zzxoumYxi52 kcLHZPtlXZ/BUsonnR6SM5mbtL2vFKa4wSueiCLygE8It6XEm52PscahuNTDDy4A 8xo0UeJwRmrUEokLjACCrxxsgmedXIP+KiWARQBXcTIyBjMUvHg7qX6cCSShV8WC yUKVp7Nx5dU8EQy1ioVSAgBi1PkHQ==
X-ME-Sender: <xms:xEn4XFJaCnBOg7_17ZtiCFj-57rpqCzg1hngupxlcNr-GZ3JfPjIMQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudegfedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtgfesth hqredtreerjeenucfhrhhomhepfdforghrthhinhcuvfhhohhmshhonhdfuceomhhtsehl ohifvghnthhrohhphidrnhgvtheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpih gvthhfrdhorhhgnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmtheslhhofigvnhhtrhho phihrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:xEn4XBSit2vboYuh-8huz3UXXyXJXwVqbXYK_VWc4r0wt25kDIET0w> <xmx:xEn4XFoEEQlO8e4gIGDFMgIkA5Umo6cO2D85Y1OVSadlgNXJScO1xA> <xmx:xEn4XOp2TpjLtumau0QOCwWzMVUIYqmXzGRiyghMlVUNXOJdEFvd9w> <xmx:xEn4XI5AEh77oUWFFAJmuYx7ZUNhjAmZKqstUqsZ1XOnPtW_LTA6DA>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 8EBF1E00A1; Wed, 5 Jun 2019 19:01:24 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.6-661-g2bffb41-fmstable-20190605v4
Mime-Version: 1.0
Message-Id: <3f495f29-cb3c-472e-897b-6d24da73e2c3@www.fastmail.com>
In-Reply-To: <2b3651f8-c2f2-fcd2-1883-16de305391f3@nostrum.com>
References: <2b3651f8-c2f2-fcd2-1883-16de305391f3@nostrum.com>
Date: Thu, 06 Jun 2019 09:01:25 +1000
From: Martin Thomson <mt@lowentropy.net>
To: mmusic <mmusic@ietf.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/mmusic/vWZkM5-v_tgJ2UaPcAVFpsBKoKk>
Subject: Re: [MMUSIC] AD Review: draft-ietf-mmusic-sdp-uks
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jun 2019 23:01:29 -0000

Thanks Adam.  I fixed these on master: https://github.com/martinthomson/sdp-uks/commit/5ca01250e8fe193111a76a1d0558ead9306fa3a6

On Thu, Jun 6, 2019, at 08:50, Adam Roach wrote:
> This is my AD review for draft-ietf-mmusic-sdp-uks. It is
> uncharacteristically short, as I have already reviewed earlier
> versions of this document and provided feedback to the authors.
> 
> None of my comment preclude putting the document into IETF last call.
> Please address them along with any other comments that may arise
> during the last call process.
> 
> Thanks!
> 
> ---------------------------------------------------------------------------
> 
> Please update the abstract to indicate that this document updates
> RFC 8122.
> 
> ---------------------------------------------------------------------------
> 
> §1:
> 
>  >  entity.  A successful attack leads to the creation of sessions where
>  >  peers are confused about the identify of the participants.
> 
> Nit: "...identity of..."
> 
> ---------------------------------------------------------------------------
> 
> §4.3:
> 
>  >  This is considered benign since these protocols are usually
>  >  distinguishable.
> 
> Suggest: s/usually/designed to be/
> 
> (there are specific forbidden PT values reserved to avoid collisions
> with RTCP -- 72 through 76, to be specific)
> 
> _______________________________________________
> mmusic mailing list
> mmusic@ietf.org
> https://www.ietf.org/mailman/listinfo/mmusic
>

v2.23.0 | Report a Bug | By Email