Re: [mpls] RTG-DIR Last Call review of draft-ietf-spring-segment-routing-mpls-18

Alexander Vainshtein <Alexander.Vainshtein@ecitele.com> Sun, 31 March 2019 04:46 UTC

Return-Path: <Alexander.Vainshtein@ecitele.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DA70E12013A; Sat, 30 Mar 2019 21:46:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.68
X-Spam-Level:
X-Spam-Status: No, score=-1.68 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_FILL_THIS_FORM_SHORT=0.01, T_KAM_HTML_FONT_INVALID=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=eci365.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2zwXjwvC40_0; Sat, 30 Mar 2019 21:46:14 -0700 (PDT)
Received: from mail1.bemta26.messagelabs.com (mail1.bemta26.messagelabs.com [85.158.142.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 027B612011F; Sat, 30 Mar 2019 21:46:12 -0700 (PDT)
Received: from [85.158.142.200] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-6.bemta.az-b.eu-central-1.aws.symcld.net id E5/37-16347-F0640AC5; Sun, 31 Mar 2019 04:46:07 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjl+JIrShJLcpLzFFi42Ix0fyhosvvtiD G4H0nj8XiNRIWmzs2sFnsWHyE1eLW0pWsFifn/GC2WLDmKbvF8Qu/GR3YPXbOusvu0XLkLavH kiU/mQKYo1gz85LyKxJYM/qP3mIruHObuWL726OMDYw7rjJ3MXJxsAgsYpbYPbOTEcQREpjIJ HHt3BQmCOc+o8TCNW+BHE4ONgFbiU2r77KB2CICuhKXXp4C62AWWMckcW5/OztIQlggWOJl1y cmiKIQiY/3zrBC2FYSB2d1MoPYLAKqEjen7wKr4RWIlXj0cQuYLSTQzyhxc6E5iM0JtOzHw6V gyxgFxCS+n1oDVsMsIC5x68l8MFtCQEBiyZ7zzBC2qMTLx/9YIeqTJO4/XcgIEVeUmHFvDjuE LStxaX43VNxXoufqO6BeDiBbWWLLi1iQXyQEHjNKXNy4HWqmlkTjinY2CFtKYv/meVC9ORLPP h2HqpGR+NG1iwWieS6bxN//U9khnkmWODHnMwtEkZzEqt6HUEUXmCU23V3PDvFNnsS3B49ZJj BqzkLy3CwkqVngQBKUODnzCZDNARTXlFi/Sx+iRFFiSvdDdghbQ6J1zlx2ZPEFjOyrGC2TijL TM0pyEzNzdA0NDHQNDY11TXQNTYz0Eqt0k/RSS3WTU/NKihKBsnqJ5cV6xZW5yTkpenmpJZsY gakvpZClbwfjx/b0Q4ySHExKorx/182PEeJLyk+pzEgszogvKs1JLT7EKMPBoSTBK+O6IEZIs Cg1PbUiLTMHmIRh0hIcPEoivJ0uQGne4oLE3OLMdIjUKUZvjgOLHs5l5ujb+AxIbrkPIreDyV 1g8u3B53OZhVjy8vNSpcR5HUE2CICMyCjNg1sAyyaXGGWlhHkZGRgYhHgKUotyM0tQ5V8xinM wKgnz6oBM4cnMK4G74xXQiUxAJ1qUzgc5sSQRISXVwMj+ezrbVSvWxYcizPc8ehix/dPutyoS HBU5VyxskgMlPAzv7NnSmrXvfvtv44Yuxi6DWtNrW6Ut09b/1Dnf9qG6oUFj/+R79afmlImmr P0TEfPkotCLI9Gbn5hq2gR5fyhV+NhfN9v38IMiLed7nMJTTB98n6ow4buTzJ3f6yLnTw9jW/ Vh3n8lluKMREMt5qLiRAA+ryIuIQQAAA==
X-Env-Sender: Alexander.Vainshtein@ecitele.com
X-Msg-Ref: server-33.tower-245.messagelabs.com!1554007563!4205550!1
X-Originating-IP: [52.41.248.36]
X-SYMC-ESS-Client-Auth: mailfrom-relay-check=pass
X-StarScan-Received:
X-StarScan-Version: 9.31.5; banners=ecitele.com,-,-
X-VirusChecked: Checked
Received: (qmail 7779 invoked from network); 31 Mar 2019 04:46:06 -0000
Received: from us-west-2a.mta.dlp.protect.symantec.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (52.41.248.36) by server-33.tower-245.messagelabs.com with AES256-SHA256 encrypted SMTP; 31 Mar 2019 04:46:06 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ECI365.onmicrosoft.com; s=selector1-ecitele-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i6bhYJ9M9EeHQVlN/HeMnV5Byl5y3+X8VToEzBJmZto=; b=AXzO6uFrh53XyTaka/vXVtwS0QH8GCL/l2Z9QgBVB+bB2OGNJVP7WlgWQTl0tvsML5xS8ourIHdynt8RWejd+LyuyOhhXG8F1F09BOKC1oNVaTLOmPrp7yHqVRbq8NkaIxZ3GYoNJPv92MmoexF7sSamfXc0BFCQf/3RVVhjfLE=
Received: from AM0PR03MB3828.eurprd03.prod.outlook.com (52.135.146.159) by AM0PR03MB5731.eurprd03.prod.outlook.com (20.179.255.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Sun, 31 Mar 2019 04:46:00 +0000
Received: from AM0PR03MB3828.eurprd03.prod.outlook.com ([fe80::7946:b505:a799:7a25]) by AM0PR03MB3828.eurprd03.prod.outlook.com ([fe80::7946:b505:a799:7a25%3]) with mapi id 15.20.1750.017; Sun, 31 Mar 2019 04:46:00 +0000
From: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com>
To: Ahmed Bashandy <abashandy.ietf@gmail.com>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "spring@ietf.org" <spring@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>, "draft-ietf-spring-segment-routing-mpls.authors@ietf.org" <draft-ietf-spring-segment-routing-mpls.authors@ietf.org>, Min Ye <amy.yemin@huawei.com>, "rtg-ads@ietf.org" <rtg-ads@ietf.org>
Thread-Topic: RTG-DIR Last Call review of draft-ietf-spring-segment-routing-mpls-18
Thread-Index: AdTUGm/eJf6lMfiCTXeKfnpkjeXMAgRsjQ+AAGtdWKA=
Date: Sun, 31 Mar 2019 04:46:00 +0000
Message-ID: <AM0PR03MB3828866508FC9A2FD28175319D540@AM0PR03MB3828.eurprd03.prod.outlook.com>
References: <VI1PR03MB3839B5FA07EADE57084F8E389D4F0@VI1PR03MB3839.eurprd03.prod.outlook.com> <65361777-db63-9a7a-9199-dd04425b4785@gmail.com>
In-Reply-To: <65361777-db63-9a7a-9199-dd04425b4785@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [147.234.241.1]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 51dcbff4-f7e3-49f9-bf74-08d6b593c620
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM0PR03MB5731;
x-ms-traffictypediagnostic: AM0PR03MB5731:
x-ms-exchange-purlcount: 5
x-microsoft-antispam-prvs: <AM0PR03MB57317FD1B8BBD83383BBACA29D540@AM0PR03MB5731.eurprd03.prod.outlook.com>
x-forefront-prvs: 0993689CD1
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(136003)(39850400004)(376002)(346002)(366004)(199004)(189003)(51444003)(6116002)(6306002)(8936002)(8676002)(99286004)(6436002)(14444005)(33656002)(54906003)(5660300002)(72206003)(316002)(53936002)(53946003)(97736004)(81156014)(478600001)(256004)(52536014)(6916009)(105586002)(2906002)(11346002)(6506007)(476003)(186003)(66574012)(74316002)(86362001)(14454004)(236005)(229853002)(81166006)(106356001)(53546011)(26005)(102836004)(71190400001)(4326008)(66066001)(790700001)(7736002)(68736007)(55016002)(3846002)(76176011)(71200400001)(54896002)(9686003)(606006)(446003)(486006)(6246003)(7696005)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR03MB5731; H:AM0PR03MB3828.eurprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ecitele.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: YBDnzTcDq0vAQhAJKVncTbR1FOZvoIRphqZIgnlAvo1/XQhOgvwOQf51l4csCJjFPmTiV9nS5eRF6Cmj47Ub2fVlA1F3UKA0x0AP+5e7uqu4L3+ztytw2+5qF7OeC+tls0ArHq9AUK62gTRtBeCBUvDT2MrBRrFXLSiQUGqEoqF225HLTFgEjqvY0CXK9TkVZYlirUL4hM9YTjB5c8NJ4EB0bUBw0TErKIyQRoVywseypDDJ9uXQp/WOn+r6QooPLlmS8w/rvAR3uPTwBndfo0k2rIuubPEb6ZgLd1gISiCiTMMawz6E+CFWY0WOFE5WQaPyQv9xcA0i2qMnxc5FTE4492HErhWyRZq186BVyAu6LRiMoIXqtGFYrfqWcEy8dXRvHo0zsyQbn8bxUqZVvmvdSfO1kVqqXWqBJEYVOFo=
Content-Type: multipart/alternative; boundary="_000_AM0PR03MB3828866508FC9A2FD28175319D540AM0PR03MB3828eurp_"
MIME-Version: 1.0
X-OriginatorOrg: ecitele.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51dcbff4-f7e3-49f9-bf74-08d6b593c620
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2019 04:46:00.6907 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2c514a61-08de-4519-b4c0-921fef62c42a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5731
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/NXTSfEauwEduQPzgqN2vIWno_zU>
Subject: Re: [mpls] RTG-DIR Last Call review of draft-ietf-spring-segment-routing-mpls-18
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Mar 2019 04:46:19 -0000

Ahmed,
Lots of thanks for a very encouraging and cooperative response.

I checked the -19 version with regard to the issues I’ve raised in my RTG-DIR Last Call review, and here is the summary status:

Issue/Nit raised in review of the -18 version

Status in the -19 version

Comments

Check of the prefix advertised as a Node SID being owned by more than one router in the domain is OPTIONALR

Resolved

The requirement level for such a check has been changed from MAY to SHOULD

Unnecessary text declaring non-compliant implementations as faulty and using forward references

Resolved

Unnecessary text has been removed

Inaccurate statement regarding allocation and advertisement of labels representing Adj-SIDs by IGP extensions for SR

Resolved

The corresponding statement does not mention label allocation any more

Nit: Grammar issues (singular vs. plural)

Fixed

In all places I’ve mentioned and then in some other ones

Nit: Reference issues

Fixed





Regards,
Sasha

Office: +972-39266302
Cell:      +972-549266302
Email:   Alexander.Vainshtein@ecitele.com

From: Ahmed Bashandy <abashandy.ietf@gmail.com>;
Sent: Friday, March 29, 2019 4:14 AM
To: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com>;; rtg-ads@ietf.org
Cc: rtg-dir@ietf.org; spring@ietf.org; mpls@ietf.org; draft-ietf-spring-segment-routing-mpls.authors@ietf.org; Min Ye <amy.yemin@huawei.com>;
Subject: Re: RTG-DIR Last Call review of draft-ietf-spring-segment-routing-mpls-18


Thanks a lot for the review

I uploaded version 19 of the draft, which, IMO, addresses all your comments

See the reply "#Ahmed"
On 3/10/19 9:55 AM, Alexander Vainshtein wrote:

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir<http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir>

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: review of draft-ietf-spring-segment-routing-mpls-18
Reviewer: Alexander (“Sasha”) Vainshtein
Review Date: 10-Mar-19
IETF LC End Date: 07-Mar-2019
Intended Status: Proposed Standard

Summary: I have some minor concerns about this document that I think should be resolved before publication.

Comments:

I have done an early RTG-DIR review of the -14 version of the draft half a year ago, and the issues I’ve raised then have been resolved in the subsequent versions one way or another). Therefore this review has been intentionally focused on the changes done to the draft in the few recent versions.

In my previous review I have noticed that the draft was not easy reading for me. Since then readability of the draft has been improved. However, there are still several places in the new text that are still difficult to parse.

I did not run the nits checker on the draft, so my list of nits is probably incomplete.

Just as with my earlier review, I send this one also to the MPLS WG list – and for the same reasons.

I tried to discuss my review privately with the authors, but they did not respond.

Major Issues: No major issues found.

Minor Issues:

1.  The text in Section 1 states that “a network operator SHOULD configure at least one node segment per routing instance, topology, algorithm” and continues that “An implementation MAY check that an IGP node-SID is not associated with a prefix that is owned by more than one router within the same routing domain, If so, it SHOULD NOT use this Node-SID, MAY use another one if available, and SHOULD log an error”. This looks somewhat controversial to me because:

a.  The check of the Node SID not being owned by more than one router in the routing domain is defined as purely optional. According to RFC 2119, implementations that choose to implement such a check must be able to interoperate with implementations that do not implement it

b.  The recommended handling of the results of this check (fully aligned with the text in Section 3.2 pf RFC 8402 that prohibits using prefixes owned by more than one router in the domain as Node-SODs) strongly suggests that the prefix that is owned by more than one router in the domain is unusable as the Node SID

I see two possibilities to resolve this controversy: either make the check in question a “real requirement” (i.e., replace MAY with SHOULD or even MUST), or explain why it is safe enough not to implement such a check (i.e., how implementations that support this check and implementations that do not support it can interoperate within a given routing domain). The first of these options seems to me aligned with Section 3.2 in RFC 8402 that says that “An IGP Node-SID MUST NOT be associated with a prefix that is owned by more than one router within the same routing domain”.
#Ahmed: I replaced the MAY with SHOULD


2.       I have  a problem with the highlighted part of the following text in Section 2.5:
   An implementation MUST NOT allow the MCCs belonging to the same
   router to assign the same incoming label to more than one SR FEC. An
   implementation that allows such behavior is considered as faulty.
   Procedures defined in this document equally applies to this case,
   both for incoming label collision (Section 2.5<https://tools.ietf.org/html/draft-ietf-spring-segment-routing-mpls-18#section-2.5>;) and the effect on
   outgoing label programming (Section 2.6<https://tools.ietf.org/html/draft-ietf-spring-segment-routing-mpls-18#section-2.6>;).

a.  The Section in question deals with incoming label collision (in fact, the text that immediately follows the problematic fragment states that “The objective of the following steps is to deterministically install in the MPLS Incoming Label Map, also known as label FIB, a single FEC with the incoming label "L1"”

b.  As a consequence, any mention of  outgoing label programming, looks out of context (even accompanied by a forward reference to Section 2.6)

c.  Section 2.6 covers the impact of incoming label collision on programming of outgoing labels in quite a generic way. Therefore I think that the  highlighted part of the quoted fragment can be safely removed (complete with the grammar mistake).

d.  I also do not see any value in stating that an implementations that violates a mandatory requirement of the spec is faulty – isn’t that self-evident?

#Ahmed: I removed the highlighted text because I agree with what you said in item (d) that it has no value



3.  The highlighted text in Section 2.8 is not accurate:

   For Local SIDs, the MCC is responsible for downloading the correct

   label value to FIB. For example, an IGP with SR extensions [I-D.ietf-

   isis-segment-routing-extensions, I-D.ietf-ospf-segment-routing-

   extensions] allocates and downloads the MPLS label corresponding to

   an Adj-SID [RFC8402<https://tools.ietf.org/html/rfc8402>;].

a.  IGP with SR extensions may indeed dynamically allocate and download MPLS labels acting as local Adj-SIDs

b.  However, these labels can be allocated by configuration (e.g. as mentioned in the tie-breaking rules in Section 2.5.1 and in the example in Section A.2.3 in the draft), in which case IGP with SR extensions would only responsible for its advertisement and installation.
#Ahmed: I removed the highlighted word "allocated"




NITS:

 :

1.  In section 2.5:

a.  In the sentence “Procedures defined in this document equally applies to this case” the noun is in plural but the verb is in singular. (If this sentence is removed as suggested above, this nit disappears)

b.  The same problem exists in the sentence “An incoming label collision occurs if the SIDs of the set of FECs {FEC1, FEC2,..., FECk} maps to the same incoming SR MPLS label "L1"”
#Ahmed: The sentence is removed as you suggested


2.       In section 2.10.1 the preposition “to” between the words “according” and “MPLS” is missing in the fragment “Push the calculated label according the MPLS label pushing rules specified in [RFC3032]”.
#Ahmed added the missing "to"


3.       Problems with references:

a.       As reported by Sergey<https://mailarchive.ietf.org/arch/msg/spring/C_W3KBcL2AWxmlB7Sp53_PvqbQA>;, there are two occurrences of references to RFC 8042 “OSPF Two-Part Metric” instead of RFC 8402. Lots of thanks to Sergey for catching this
#Ahmed: Corrected, thanks again


b.       Reference to RFC 8174 mistakenly contains a link to  RFC 7274.
#Ahmed: Corrected


Hopefully these notes will be useful.
#Ahmed: VERY useful

Regards,
Sasha

Office: +972-39266302
Cell:      +972-549266302
Email:   Alexander.Vainshtein@ecitele.com<mailto:Alexander.Vainshtein@ecitele.com>


___________________________________________________________________________

This e-mail message is intended for the recipient only and contains information which is
CONFIDENTIAL and which may be proprietary to ECI Telecom. If you have received this
transmission in error, please inform us by e-mail, phone or fax, and then delete the original
and all copies thereof.
___________________________________________________________________________

___________________________________________________________________________

This e-mail message is intended for the recipient only and contains information which is 
CONFIDENTIAL and which may be proprietary to ECI Telecom. If you have received this 
transmission in error, please inform us by e-mail, phone or fax, and then delete the original 
and all copies thereof.
___________________________________________________________________________