Re: [mpls] Rtgdir early review of draft-ietf-mpls-msd-yang-04

[Susan Hares <[e-mail]>]

Yingzhen:

You have addressed my minor issue and the nit.

Thank you for updating the draft.

Cheerily, Sue

From: Yingzhen Qu <[e-mail]>
Sent: Wednesday, January 24, 2024 11:16 PM
To: Susan Hares <[e-mail]>
Cc: [e-mail]; [e-mail]; [e-mail]
Subject: Re: Rtgdir early review of draft-ietf-mpls-msd-yang-04

Hi Sue, I've uploaded version -05 to address your comments: added the references and fixed the nit. Please let me know if you see any other issues. Thanks, Yingzhen  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌  ‌
External ([e-mail]<mailto:[e-mail]>)
  Report This Email<https://protection.inkyphishfence.com/report?id=bmV0b3JnMTA1ODY5MTIvc2hhcmVzQG5kemguY29tLzViYTZmMGUwNDU2M2M1OWNiOTZhZDQ2MDZlNDYyNDJkLzE3MDYxNTYxNjcuMTU=#key=519e7584f0b202f0b0ef85a643ffd08b>  FAQ<https://www.godaddy.com/help/report-email-with-advanced-email-security-40813>  GoDaddy Advanced Email Security, Powered by INKY<https://www.inky.com/protection-by-inky>

Hi Sue,

I've uploaded version -05 to address your comments: added the references and fixed the nit.

Please let me know if you see any other issues.

Thanks,
Yingzhen

On Tue, Jan 23, 2024 at 5:48 AM Susan Hares <[e-mail]<mailto:[e-mail]>> wrote:
Yingzhen:

As to the nit, anytime you wish.  It is a nit.

As to the references to RFC8664 and RFC8814, I’m a bit surprised by this since the references are guides for people who implement.  I would add the additional references.

Cheers,

Sue

From: Yingzhen Qu <[e-mail]<mailto:[e-mail]>>
Sent: Monday, January 22, 2024 10:09 PM
To: Susan Hares <[e-mail]<mailto:[e-mail]>>
Cc: [e-mail]<mailto:[e-mail]>; [e-mail]<mailto:[e-mail]>; [e-mail]<mailto:[e-mail]>
Subject: Re: Rtgdir early review of draft-ietf-mpls-msd-yang-04


Hi Sue,

Thanks for the review.

Regarding the reference, both PCE MSD [RFC8664] and BGP-LS [RFC8814] are referencing RFC 8476 and 8491 as well for MSD definition. This is not to list all protocols supporting MSD, but to help users find out what MSD means. I don't think it's necessary to add RFC 8664 and 8814 as references.

About the editorial nit, if you don't mind, I'll fix it in the next version.

Thanks,
Yingzhen



On Mon, Jan 22, 2024 at 7:09 AM Susan Hares via Datatracker <[e-mail]<mailto:[e-mail]>> wrote:
Reviewer: Susan Hares
Review result: Has Nits


Routing Directorate report on draft-ietf-mpls-msd-yang-04.txt
Status: Has one small technical issue that needs checking + 1 editorial nit

Caveat: I am not a Yang doctor, I am counting on Yang doctor's review from Jan Lindblad:

Yang Doctor Review Initial link:
https://mailarchive.ietf.org/arch/msg/yang-doctors/PUx5grv1ch3L93cBmwKS_iFB3_w/<https://shared.outlook.inky.com/link?domain=mailarchive.ietf.org&t=h.eJxFjrEOwiAURX-lYdY-aMurdTIOLjqYGGeDgEC01EC1VuO_Ky6u59yc3Be5hQuZZ8T2_TXOAVrhLiJI6-46d7o_5V0wkAC00cAovJmqTvZdiLDdP7gJdyZtuWlKuWyH9e7gVsvyMACZZOScul5_t4ZRPsOGFRCtCDouvHraXHYt8KPAE9W04lhK3shjg0JVSFFXWFSFAlZTZBwZ1jnjqapTdXTePK32v4sLk06nXPIq-T95fwCVEEZ5.MEQCIDnSdojyUouGOXlhPEkqhr2BnsgtlVc11Zf1aFoa1b29AiBB6arCY8Mnu-bGZbcaDW5fr_q9Bp2FXDNoQ5AQrdfZMA>

Yang Doctor's comments resolved on -04.txt
https://mailarchive.ietf.org/arch/msg/yang-doctors/9TlCawy9EyQ69Ap4n0LcFeown8A/<https://shared.outlook.inky.com/link?domain=mailarchive.ietf.org&t=h.eJxFjsFuAiEURX_FsNZ5MIWnzErTtCs3Jv0BhCdMnAED05rR-O8VN27PuTm5d_abB9YtWJimS-kARtMPJtvQ_1HT03RqUvZQAYzFw2yiX7lkp5QL6J_h01xn_TUfUO8uMvK9_aZ0jZsdsOWCnWs30nPrBVcb1KKFEkymso3uFhqbRlBHgydOXCr8sErbo0bjJHIkia1sHYg1R6FQ4LoRqlapVuc--lug-Lq49fV0zVXvqn-Txz-EgkZf.MEUCIQC3SnA0i-BwZBkpO-0pwWbjG4t6eWRW_9h672B2RoOgNgIgDEQy47Yz2ZdmAKbzOVXvCLoPfK3QMKpv6Qq4Krp4kvI>


Content: two small and focused modules.
1) iana-msd-types
2) ietf-mpls-msd

One small technical issue in  module ietf-mpls-msd:

     identity msd-mpls {
       base msd-base-mpls;
       description
         "Base MPLS Imposition MSD.";
       reference
         "RFC 8491: Signaling Maximum SID Depth (MSD) using IS-IS.
          RFC 8476: Signaling Maximum SID Depth (MSD) using OSPF.";
     }


Question:
Why does this only specify [RFC8476] (OSPF) and [RFC8491] (ISIS)
and leave out PCE MSD [RFC8664] and BGP [RFC8814].
Is there some assumption that PCE and BGP will not set maximum
MSD depth for MPLS?


Editorial, Abstract: suggestion to combine last two


Old Text: /
   YANG [RFC7950] is a data definition language used to define the
   contents of a conceptual data store that allows networked devices to
   be managed using NETCONF [RFC6241] or RESTCONF [RFC8040].

   There are two YANG modules defined in this document.  Module iana-
   msd-types defines the identities for Maximum SID Depth (MSD) Types as
   the IANA the IGP MSD-Types registry.  This document also defines
   module ietf-mpls-msd augmenting the IETF MPLS YANG model [RFC8960],
   which itself augments [RFC8349], to provide operational state for
   various MSDs[RFC8662].  The module augments the base MPLS model with
   a list of various types of node MSDs, as well as various types of
   MSDs on links.

   The augmentation defined in this document requires support for the
   MPLS base model[RFC8960] which defines basic MPLS configuration and
   state.

   The YANG modules in this document conform to the Network Management
   Datastore Architecture (NMDA) [RFC8342].
/

New text: /
   YANG [RFC7950] is a data definition language used to define the
   contents of a conceptual data store that allows networked devices to
   be managed using NETCONF [RFC6241] or RESTCONF [RFC8040].


   There are two YANG modules defined in this document.  Module iana-
   msd-types defines the identities for Maximum SID Depth (MSD) Types as
   the IANA the IGP MSD-Types registry.  This document also defines
   module ietf-mpls-msd augmenting the IETF MPLS YANG model [RFC8960],
   which itself augments [RFC8349], to provide operational state for
   various MSDs[RFC8662].  The module augments the base MPLS model with
   a list of various types of node MSDs, as well as various types of
   MSDs on links.

   The augmentation defined in this document requires support for the
   MPLS base model[RFC8960] which defines basic MPLS configuration and
   state. The YANG modules in this document conform to the Network Management
   Datastore Architecture (NMDA) [RFC8342].

 /