[mpls] Genart last call review of draft-ietf-mpls-mldp-multi-topology-05

Roni Even via Datatracker <noreply@ietf.org> Fri, 03 May 2024 06:20 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: mpls@ietf.org
Delivered-To: mpls@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D3F7C1840E2; Thu, 2 May 2024 23:20:37 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Roni Even via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-mpls-mldp-multi-topology.all@ietf.org, last-call@ietf.org, mpls@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.11.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171471723730.25925.768615666182072142@ietfa.amsl.com>
Reply-To: Roni Even <ron.even.tlv@gmail.com>
Date: Thu, 02 May 2024 23:20:37 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/BseFmPyBx9ftjCriRune5_ueEDs>
Subject: [mpls] Genart last call review of draft-ietf-mpls-mldp-multi-topology-05
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 03 May 2024 06:20:37 -0000

Reviewer: Roni Even
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-mpls-mldp-multi-topology-??
Reviewer: Roni Even
Review Date: 2024-05-02
IETF LC End Date: 2024-05-02
IESG Telechat date: 2024-05-16

Summary:
The document is ready for publication as a standard track rfc with nits

Major issues:

Minor issues:

Nits/editorial comments:
1. This document is using the few types from iana fed type name space registry.
I think that the Iana section should ask to update the registry pointing to
this document and verify that all fields in the relevant entries are not
changed 2. The document is using 8 bits from the MT IP address for the IPA
field. Should this document title say that it updates RFC7307 or specify how to
prevent different use of these reserved bits?