IETF Logo Mail Archive

Re: [mpls] Comments on draft-gandhi-mpls-stamp-pw

Rakesh Gandhi <rgandhi.ietf@gmail.com> Fri, 09 February 2024 19:57 UTC

Return-Path: <rgandhi.ietf@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 40CF7C151087; Fri, 9 Feb 2024 11:57:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.104
X-Spam-Level:
X-Spam-Status: No, score=-7.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SKrZemnc9g4z; Fri, 9 Feb 2024 11:57:22 -0800 (PST)
Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19F57C14CE40; Fri, 9 Feb 2024 11:57:19 -0800 (PST)
Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-6049ffb9cedso15780817b3.0; Fri, 09 Feb 2024 11:57:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707508638; x=1708113438; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EaP+rvWD8l+G/1c7doAt0q75loU2nNQJ1Ct67VnFnq4=; b=WbNuzkuNgBlgSwdPiru3I93kqC3iASZ/ict9m39051iUiBrEZiY6wX2GOgHsk8WwRE PsUGSIO5HNonhX8sOBSgOir4Kf058/3b11G0siC03Bir4nsm9zvovKBfqDQy4IA228Bt oHbSr90yCoy+SfNWgnZ9GGMj1zA0susgpC9xTawWcVVGmKKntW8PaZ8Acdz865S/bPbP MLczQtdj7u16MwHkHgz7OvROuRkLoh8hxjFtslmM29ElxfRITRgQYXub4HKaTQdYQ2A/ Fan3pn/r4SEoBJS2UOy4cN3KJq5myQxGkcoTd6C5A3m5fDBzrN/CPrQhi1jsW3GgE6Pa qyhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707508638; x=1708113438; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EaP+rvWD8l+G/1c7doAt0q75loU2nNQJ1Ct67VnFnq4=; b=RUM1FPDBfDUUD2nLIHvNxPfqLtEA9ttE8ISEtiNbV6HOpjBnB9Xg5t8IccCyIFFPcT rz0apa759mhBVcN1URjYfFU5PBvVf8SlUa22P/w6CslUB4c5xV4lmwHtaCmhOCCz5VPh Zq+r2HRw+NzbVr8a7NEUzc8ubCmC65HUcS0WkQ+MKswvYZLUL7Lzv8ctOah4Wf/BUySr INUyxaMP6+y/dZ+4loStNoyaQdg+E9925BE6cBCcepClaXNGhe9r07JfAY1aA61YE2jp K6zzAD7pgd9yQQk05/A8YORm3x144QQV5BANCF1G/zpBSmD5kOkAjeekNLef8svADMj/ QbRA==
X-Gm-Message-State: AOJu0Yz8otO5QRVPFjZLWNGTQJzayHZk2KA4nSr8QiY1Qf4H86NnKY3E cI0EDP7e4A/U6YGtevRxCFkZsydopR1/+UAr8YkB91vs0D8bQDMPU4HpA1YTd6e7nYrdGVgsdgL whEPe7OUNobYofAuseD2NgdZAkmpj1AIP99wI
X-Google-Smtp-Source: AGHT+IGfdtv2F4E6t7DJqS95Tgv1UnuVe0xeEyI6u0xl+snsBf2K+29D7jOqs7f79UH70ZP3dyWrSXR6EQXxraM+Ag4=
X-Received: by 2002:a5b:c:0:b0:dc2:40d8:ac5e with SMTP id a12-20020a5b000c000000b00dc240d8ac5emr216636ybp.1.1707508638149; Fri, 09 Feb 2024 11:57:18 -0800 (PST)
MIME-Version: 1.0
References: <202311031456472738856@zte.com.cn> <CAMZsk6d5rpU7Dk8RCCuQcJebRL1Us7wpDNeB3GxMAskfZ3QUqQ@mail.gmail.com>
In-Reply-To: <CAMZsk6d5rpU7Dk8RCCuQcJebRL1Us7wpDNeB3GxMAskfZ3QUqQ@mail.gmail.com>
From: Rakesh Gandhi <rgandhi.ietf@gmail.com>
Date: Fri, 09 Feb 2024 14:57:07 -0500
Message-ID: <CAMZsk6dKFxvS_OovRRh3i1=f2BQBN6m6-ygaKB8Kn7q+j-VDSw@mail.gmail.com>
To: xiao.min2@zte.com.cn
Cc: draft-gandhi-mpls-stamp-pw@ietf.org, mpls@ietf.org
Content-Type: multipart/alternative; boundary="000000000000d3f2350610f855c0"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/GNpAR3WrbF4JfnFjEWBblxg1gcE>
Subject: Re: [mpls] Comments on draft-gandhi-mpls-stamp-pw
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Feb 2024 19:57:24 -0000

Thanks Xiao Min for the detailed review.

We have posted a new revision with the suggested changes:
https://www.ietf.org/archive/id/draft-gandhi-mpls-stamp-pw-05.html
DIFF:
https://author-tools.ietf.org/iddiff?url2=draft-gandhi-mpls-stamp-pw-05

Please see inline with <RG1>...


On Fri, Nov 3, 2023 at 8:16 AM Rakesh Gandhi <rgandhi.ietf@gmail.com> wrote:

> Hi Xiao Min,
>
> Thanks for your review comments. Please see replies inline with <RG>..
>
> On Fri, Nov 3, 2023 at 2:57 AM <xiao.min2@zte.com.cn> wrote:
>
>> Dear Authors,
>>
>>
>> I've read draft-gandhi-mpls-stamp-pw-04 and found it's valuable.
>>
>
<RG1> Great, thanks!


> In Section 4 and 5, two different packet formats are defined for STAMP
>> Session-Sender Test Packet and STAMP Session-Reflector Test Packet
>> respectively, a list of PW types on the application of each packet format
>> may be helpful, e.g., for Ethernet PW, I think the STAMP Test Packet
>> without IP/UDP Header should be used.
>>
> <RG> Yes, that's a good suggestion, we can include Ethernet PW in the next
> revision.
>
>
<RG1> Added this in Section 3.2.


> The idea is to require only one packet format for a specific PW type.
>>
> <RG> Yes, we could add a table for PW type and STAMP format to be used in
> the next revision. For example, the following PW could use STAMP packet
> without IP/UDP header.
>
>    1. MPLS Ethernet PW Data Traffic [RFC4448]
>    2. L2-Specific Sublayer (L2SS) used in L2TPv3 PW Data Traffic [RFC3931]
>    3. Private Line Emulation [draft-ietf-pals-ple] Data Traffic
>    4. TDM over IP [RFC5087] Data Traffic (no IP Header case)
>
>

 <RG1> Added this in Section 3.2.


>
>> Besides, RFC 5085 defines three types of VCCV Control Channel, it's
>> helpful if this draft can provide some analysis on how and why a specific
>> type of VCCV Control Channel is choosed for STAMP over PW encapsulation,
>> and I believe fate sharing between the PW data packet and the STAMP-over-PW
>> test packet is an important argument behind the selection.
>>
>
> <RG> Yes, that's a good point. There are three types defined in RFC 5085.
> The scope of the draft is type 3 (TTL expiry). We can add some text for
> other types for completeness.
>

<RG1> Added this in Section 3, last paragraph.



>
>
>> Although the current version of this document focuses on STAMP over PW
>> only, I don't see a reason why STAMP over LSP can't be included, I believe
>> one document covering both STAMP over PW and STAMP over LSP is preferable.
>>
>
> <RG> Yes, agree. We can include MPLS LSP in the next revision.
>

<RG1> Added this in Section 3.1.

Thanks,
Rakesh



>
> thanks,
> Rakesh
>
>
>
>>
>> Best Regards,
>>
>> Xiao Min
>>
>>
>> _______________________________________________
>> mpls mailing list
>> mpls@ietf.org
>> https://www.ietf.org/mailman/listinfo/mpls
>>
>

v2.23.0 | Report a Bug | By Email