Re: [mpls] MPLS-RT rreview of draft-sitaraman-mpls-rsvp-shared-labels

[Greg Mirsky <[e-mail]>]

And now with MPLS WG included.

Regards,
Greg

On Tue, Sep 26, 2017 at 12:44 PM, Greg Mirsky <[e-mail]> wrote:

> Dear Authors, WG chairs, et.al,
> below please find my review of draft-sitaraman-mpls-rsvp-shared-labels-02:
>
>    - the document is very well written and it was pleasure to read it;
>    - I believe that the proposed "pop and forward" functionality is
>    useful;
>    - the proposed solution is technically sound.
>
> Hence my conclusion - the draft is ready for WG adoption.
>
> Taking this opportunity I'd like to share my comments but I don't consider
> any gating WG adoption:
>
>    - Introduction refers to labels with pop and forward functionality as
>    transit labels. Later in the draft, as I understand, such labels referred
>    to as 'pop labels'. Please consider establishing that these terms are used
>    interchangeably or using only 'pop label' term;
>    - I think that in all examples it is assumed that the egress LER
>    advertises implicit NULL label. There's no need to change examples but it
>    may be helpful to clarify use of the implicit NULL label by the egress LER;
>    - the draft introduces Effective Transport Label-Stack Depth (ETLD)
>    parameter. On the other hand, in Sectio 4 of Entropy Label for SPRING
>    Tunnels
>    <https://tools.ietf.org/html/draft-ietf-mpls-spring-entropy-label-06> introduced
>    Entropy Readable Label Depth/Readable Label Depth. Could it be that these
>    are the same? That only one parameter is sufficient?
>    - section 8.1 I think it will be helpful to provide information on
>    what the label stack looks when a packet arrives at node F;
>    - extensions proposed in section Protocol Extensions will be easier to
>    understand and evaluate if these refer to figures.
>
> Regards,
> Greg
>
> On Fri, Sep 15, 2017 at 2:47 AM, Loa Andersson <[e-mail]> wrote:
>
>> Greg, Rajiv, Stewart, Yimin
>>
>> You have been selected as MPLS-RT reviewers for
>> draft-sitaraman-mpls-rsvp-shared-labels-02.
>>
>> Note to authors: You have been CC'd on this email so that you can know
>> that this review is going on. However, please do not review your own
>> document.
>>
>> Reviews should comment on whether the document is coherent, is it
>> useful (ie, is it likely to be actually useful in operational networks),
>> and is the document technically sound?
>>
>> We are interested in knowing whether the document is ready to be
>> considered for WG adoption (ie, it doesn't have to be perfect at this
>> point, but should be a good start). Please remember that it often is
>> easier to progress the document when it has become a working group
>> document. All comments in the MPLS-RT review needs to be addressed,
>> but please think carefully about whether a comment is gating the
>> adoption or could just as easily be addressed after the adoption.
>>
>> Reviews should be sent to the document authors, WG co-chairs and WG
>> secretary, and CC'd to the MPLS WG email list. If necessary, comments
>> may be sent privately to only the WG chairs.
>>
>> If you have technical comments you should try to be explicit about what
>> needs to be resolved before adopting it as a working group document, and
>> what can wait until the document is a working group document and the
>> working group has the revision control.
>>
>> Are you able to review this draft by August 29, 2017? Please respond
>> whether you are available to do the review in a timely fashion.
>>
>>
>> Thanks, Loa
>> (as MPLS WG co-chair)
>> --
>>
>>
>> Loa Andersson                        email: [e-mail]
>> Senior MPLS Expert                          [e-mail]
>> Huawei Technologies (consultant)     phone: [phone]
>>
>
>