IETF Logo Mail Archive

Re: [mpls] Yangdoctors early review of draft-ietf-mpls-static-yang-09

Tarek Saad <tsaad.net@gmail.com> Thu, 12 September 2019 15:27 UTC

Return-Path: <tsaad.net@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BC4EB12010D; Thu, 12 Sep 2019 08:27:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1iFwdA6-38x2; Thu, 12 Sep 2019 08:27:41 -0700 (PDT)
Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 54006120111; Thu, 12 Sep 2019 08:27:38 -0700 (PDT)
Received: by mail-io1-xd35.google.com with SMTP id f4so54967153ion.2; Thu, 12 Sep 2019 08:27:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :content-transfer-encoding:mime-version; bh=VwmYvBuBcSoHVSbp3gI7DLKpLK1Jsfk76IOi6La5wVU=; b=eT5Bh7jX19llVK5wZk1EFioWYNt9/WNgRFTOYG9zx+zLlfEndFWRBGvQssocrXVY2+ r6HP0H7awCiGgTyxu8XngQj9YoJ/HTSY83Xbrpbwvi5fSF+pUCXSoMGiKi2zDKwX9Io6 IE2cDlPmxjOwjKthbgu2LeMHPy9dQPXMCHKNPy87lzGv4bUS5KfWxyQSeCzKntY+4vod HvtLa+EvbfbQBT9P7xeatezI3KZfY2EpBXQMZJBG8w4jx95Oiasr1l/VqMG7vRwKJTJO 3UBcuA5qTsIy3xsr+Duc7xaD2XAKcpeAylqcqg/R1y+mY9XtDw/G6ytAcxO51+lpI6ef UNOw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:content-transfer-encoding:mime-version; bh=VwmYvBuBcSoHVSbp3gI7DLKpLK1Jsfk76IOi6La5wVU=; b=qxPHLiMlLVJxaqxbvUkh3bEbe73bKx3351cGzHyL7ycHPm2Dl5QxfGVGFdBwOmpwvg Jx89ssKs9skREikQC3IIdaQCLicVwqSdcNRuVsumpMMi3glfkTf6hd6yKASguOb76yg3 s1XNr4JCxF4VvHdaHZv3tzd5WDQEqx8Uuy82Pm5JGy0EL+/zNtvDeoCHSeYocbH6xHkR sBAQyz30qgARrSc9ozcv9DfRSOWJHjYbarq9qrVQkF9QrdsWD8hlFpnoKiX6v1tOg2F3 Rc4jM3lkI2De6rHrZ/ZY9ZCF8U56fqxZrfXnG6sOgcU4UfB6vCP3Me3DxioZ70834b+T N7eA==
X-Gm-Message-State: APjAAAV7Abo59HlCFZxGMeFrYwfVmE7IUqvjg03CfCVLH8+qU6Clld5u dYoHu4NCXKzFeslA/fK5ZoA+kbtn
X-Google-Smtp-Source: APXvYqxDX9tG3JPkAGPGsskuq83rTD2XW3miypAXK6vsvk7QcTW1tyC26r8npTUT09AtVJN+9uPsLA==
X-Received: by 2002:a02:3e8a:: with SMTP id s132mr36866165jas.66.1568302057498; Thu, 12 Sep 2019 08:27:37 -0700 (PDT)
Received: from BYAPR19MB3415.namprd19.prod.outlook.com ([2603:1036:307:293b::5]) by smtp.gmail.com with ESMTPSA id m67sm36531617iof.21.2019.09.12.08.27.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Sep 2019 08:27:37 -0700 (PDT)
From: Tarek Saad <tsaad.net@gmail.com>
To: Andy Bierman <andy@yumaworks.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>
CC: "draft-ietf-mpls-static-yang.all@ietf.org" <draft-ietf-mpls-static-yang.all@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: Yangdoctors early review of draft-ietf-mpls-static-yang-09
Thread-Index: ATc1NTUxGHi6xqa0qYEQyyZ6K5i2C7xoksqT
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Thu, 12 Sep 2019 15:27:36 +0000
Message-ID: <BYAPR19MB341509F6F116B65811BF0DB1FCB00@BYAPR19MB3415.namprd19.prod.outlook.com>
References: <156381448119.11357.2555532993158583807@ietfa.amsl.com>
In-Reply-To: <156381448119.11357.2555532993158583807@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-Exchange-Organization-SCL: -1
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/HgZrBN-J2aSCGiRaeQG_jdijjUw>
Subject: Re: [mpls] Yangdoctors early review of draft-ietf-mpls-static-yang-09
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Sep 2019 15:27:43 -0000

Hi Andy,

Thanks for your review and comments. We have uploaded a new revision that addresses your comments.
https://tools.ietf.org/html/draft-ietf-mpls-static-yang-10

Inline for more details.

On 7/22/19, 12:54 PM, "Andy Bierman via Datatracker" <noreply@ietf.org> wrote:

    Reviewer: Andy Bierman
    Review result: Ready with Nits
    
    - No pyang warnings or errors
    - No noticeable typos or omissions
    
    Nits:
     - contact info includes WG Chairs; this was removed in the new usage guidelines
[TS]: removed.

    Questions:
     - The ietf-mpls-static-extended module is used instead of a YANG feature.
       Is the generic name 'extended' appropriate? What will the next module used to
       avoid a YANG feature be called? extended2?
[TS]: there are multiple models (at IETF) that have adopted similar approach of grouping non-base data in a separate module named as 'xxx-extended'. One argument was to enforce the base model be supported without any feature check - and hence makes it simpler to understand. Not sure I have an answer for names of future extended modules, but maybe extended-<feature1>, extended-<feature2>, etc.?

Regards,
Tarek

v2.23.0 | Report a Bug | By Email