[mpls] draft-ietf-mpls-spring-lsp-ping: resolution of issues raised in my RTG-DIR review

Alexander Vainshtein <Alexander.Vainshtein@ecitele.com> Wed, 04 October 2017 08:53 UTC

Return-Path: <Alexander.Vainshtein@ecitele.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C6A013214D; Wed, 4 Oct 2017 01:53:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.589
X-Spam-Level:
X-Spam-Status: No, score=-4.589 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001, T_DKIM_INVALID=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=eci365.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W-NIYtxvJNqa; Wed, 4 Oct 2017 01:53:48 -0700 (PDT)
Received: from mail1.bemta5.messagelabs.com (mail1.bemta5.messagelabs.com [195.245.231.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2FD851330AE; Wed, 4 Oct 2017 01:53:47 -0700 (PDT)
Received: from [85.158.136.83] by server-15.bemta-5.messagelabs.com id 20/FD-01778-991A4D95; Wed, 04 Oct 2017 08:53:45 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA1WSbUhUWRjH59yXuTfxLqex8mlSGGajzHKwV26 UsB8E/dDWQlvQy27eqZtza15k7hQTBEllkK1lBlE2ogOzvVkZQ1DrWoYWZQXOTFPamEmoOJq9 YISVFs2do2375fJ7nv//nOd/Lg9PG/r1Rl72emS3U7Kb9SnMklnXvDmn/NENue+CmeLj8iOcG DsV5MS/KuaLsb8vsGKb7yMt1l3q58R7oTH0C1c4eMyHCgOBT1Th3Wc19G/0RlZxWl3eItbWGr ioL6l4jbxPDpRypSjYjspRCs/gQzQEGl5zWmHAlRSEmy/TpOhB0DkWTxRTeD3Og2B9t17jaTg bvpwfZzUTjbspGDjbkBTS8Cao8HVwxFQEwfCVxAw+wRaoOb5RazN4NnQ19rMaC3gzhF/6GY0R ngGjDy5RGtM4HWJ9tUkGjCHQ1E4Tng6DvV9Z4rdCT78fkb4JQgPVesKZEKk9knwa4EMcjLwcZ IiwGMorm1gtD+Bf4VxjFsGf4Vr8D2KvR1ATDk3MzYZYex9HeDMMd36eyLATOs7FOXIgykKssW dCyIBoJMoSoZ2F8voDyaQGvBXu+94z5AcZoTt6GBHOgPjzm2wlyqr+4dGEndD78HGSBTwV2k7 3MaS/AOr+HdETng9n/a/oSX50u5f6sV+HuIsoS5Xdu2V3zqJlFqtbKbZ5HJJiz1mYu9TikFVV KpbtklW1bHU5giixbPt0OnQDdZ1Y3YJm8pR5ulBWF91g+Mnq2rbHJqm2Le5ddlltQRk8bwaBT iylYapbLpa92xV7YmMnZeBTzdMEo3ZUUEskh6oUE+kBWsxffdY9TvG3tK+BcbqcsjFd6NWsWL Padjm/XzS5/RGUaUwTkE6nM6SWyG6H4vm/PoTSeWROExTtllTF6fk+bygRhUpE8e1PRvFI/0n GUmQa6zo650Xe26ZwVS3z4cveiMiued7x5+ha8dj4XH/e9ZS2FZT3cCiyZgTOzDu5klp51VRl aSj7MLycWqc8nfemYC0VKpgxZ1v9wVdFplWm6uZaZv2U90P/XG/5yObrZt2+s1dpbh0YLlCqR jN2ZO3I/307pmbebXWVsalxff4to5lRbdLCbNqtSt8AlzZjmvgDAAA=
X-Env-Sender: Alexander.Vainshtein@ecitele.com
X-Msg-Ref: server-14.tower-36.messagelabs.com!1507107220!123625818!1
X-Originating-IP: [52.27.180.120]
X-StarScan-Received:
X-StarScan-Version: 9.4.45; banners=ecitele.com,-,-
X-VirusChecked: Checked
Received: (qmail 9182 invoked from network); 4 Oct 2017 08:53:43 -0000
Received: from ec2-52-27-180-120.us-west-2.compute.amazonaws.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (52.27.180.120) by server-14.tower-36.messagelabs.com with AES256-SHA256 encrypted SMTP; 4 Oct 2017 08:53:43 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ECI365.onmicrosoft.com; s=selector1-ecitele-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ARGc+WIipjI1o8gctmmwXWCMAmjdmJHp9owipVRxLdo=; b=UF0UI3MSLhaQUMF+KYBVioMhCsIgojtDD7ij9SxyqN5jTglTRd21xIcUDNnQ6QK+ENj7KGjkpZeBf6R34ge6wKaOEY7w/nNAtDrHWll8hEiEhs83GP2OmhhY4XyODlHG8962gNsHC7lREiPoAaSDIYu/u+v/rQ1ppFx95UaDVWw=
Received: from AM4PR03MB1713.eurprd03.prod.outlook.com (10.167.88.15) by AM4PR03MB1553.eurprd03.prod.outlook.com (10.165.243.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 4 Oct 2017 08:53:38 +0000
Received: from AM4PR03MB1713.eurprd03.prod.outlook.com ([fe80::71db:1e06:ca8b:da77]) by AM4PR03MB1713.eurprd03.prod.outlook.com ([fe80::71db:1e06:ca8b:da77%14]) with mapi id 15.20.0077.018; Wed, 4 Oct 2017 08:53:38 +0000
From: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com>
To: "BRUNGARD, DEBORAH A" <db3546@att.com>
CC: "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>, "spring@ietf.org" <spring@ietf.org>, "Jonathan Hardwick (Jonathan.Hardwick@metaswitch.com)" <Jonathan.Hardwick@metaswitch.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-mpls-spring-lsp-ping.authors@ietf.org" <draft-ietf-mpls-spring-lsp-ping.authors@ietf.org>
Thread-Topic: draft-ietf-mpls-spring-lsp-ping: resolution of issues raised in my RTG-DIR review
Thread-Index: AdM87VBWMwQpWk20SYuuvpBxKKubvg==
Date: Wed, 4 Oct 2017 08:53:38 +0000
Message-ID: <AM4PR03MB1713BACBB06A4157DFE2F3889D730@AM4PR03MB1713.eurprd03.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [79.178.34.49]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM4PR03MB1553; 6:TLN2cEMBo2QNvpArtHE2O+KKCcFJOSeAaNMQQrvs69uOLN3qZPCxvPjSoTmVHF9s6EhTrkoRQUV373W6K+JMPBR9SRhlylVfZT8CxjygtoKiRWiliKn02EOEcK9QI3ykNwSBVdJ8F2GY7TQyK1zkyvhjlkbq8DDUBeAgmIRwxEWXRx7eEofHGPfFebwdeJUkpB0ZuOD4cwJU1Ih6UFZXCktY+4fFnOtFcIi2RLiBntAEasJ7Sjcv30dMbbD2pjpsCZpuQiP9umHA6OURs5ev8y0iDZctWlpT2mGEmAb0WMY+0MZ4bc7l+3sTHMTF59Lp2PTg/kdVP15r9p47HN7+ng==; 5:JIasw+BUN11aAr2AijnGtj2VEK0E3E/EacYtCbWmHaN9lMH/z20YMU1Xq1OF/neD977WtByTWgGFTkngN7s8ptMH892agHtkarc/O2yTIpOOQ4o2R92CEktKVqvrMAhFn9BboQ3QGA8nEEtb3E+NpA==; 24:/8fcqV4jZkGQYwW9a+s1+n7c1GVbU2/vaqL009ChmcHWpF0WzLK3xDS5O9OcOQro3YNy183Q3IQLqtgI0bGXiuENksM9dQaPJ2V3k/+7y3U=; 7:PCEPt18/WMetHQSaxo3e0veyki49yqccUw2O11t1bHa5Gu07EImEObaPHx5ZRY3U+mTawfK9f0/osSeJR2mkj6WZLg0IvtZhMWXx2M1ek/NU4VmbGMLclW1rv/bT8c0QnY/+NI4LSd4HYkTa8syfjEvTi+h+fWL5Sb6vayyN6KNHrX6+W8QQaaG/iYtIvTO15TNb7lvHeXR+BrhrZxb1bzWALR+RfXTGtNdnpDYsUJM=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR;
x-ms-office365-filtering-correlation-id: 3ce52aeb-462c-476c-9b15-08d50b056799
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:AM4PR03MB1553;
x-ms-traffictypediagnostic: AM4PR03MB1553:
x-exchange-antispam-report-test: UriScan:(120809045254105)(21748063052155)(279101305709854);
x-microsoft-antispam-prvs: <AM4PR03MB15534D630D726052E8F6ABE09D730@AM4PR03MB1553.eurprd03.prod.outlook.com>
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR03MB1553; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR03MB1553;
x-forefront-prvs: 0450A714CB
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(376002)(252514010)(199003)(189002)(51444003)(8676002)(561944003)(5660300001)(68736007)(316002)(6436002)(5250100002)(81166006)(2900100001)(189998001)(81156014)(53936002)(4326008)(8936002)(7736002)(54906003)(66066001)(606006)(7696004)(101416001)(14454004)(6306002)(99286003)(54896002)(54356999)(50986999)(3660700001)(86362001)(74316002)(6916009)(102836003)(6116002)(236005)(9686003)(55016002)(790700001)(3846002)(2906002)(3280700002)(72206003)(230783001)(106356001)(6506006)(105586002)(33656002)(478600001)(25786009)(97736004); DIR:OUT; SFP:1102; SCL:1; SRVR:AM4PR03MB1553; H:AM4PR03MB1713.eurprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: ecitele.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_AM4PR03MB1713BACBB06A4157DFE2F3889D730AM4PR03MB1713eurp_"
MIME-Version: 1.0
X-OriginatorOrg: ecitele.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2017 08:53:38.3030 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2c514a61-08de-4519-b4c0-921fef62c42a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR03MB1553
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/IN0ESB-ONaGtO4Boz4AYmfoxXHU>
Subject: [mpls] draft-ietf-mpls-spring-lsp-ping: resolution of issues raised in my RTG-DIR review
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Oct 2017 08:53:51 -0000

Deborah and all,

I have read the latest (-11) version of the draft in order to check to which extent my RTG-DIR review comments (that referred to the -06 version of the draft) have been addressed.

Here are the results of this check:

Major Issue #1 in the -06 version of the draft:
Section 7.4 "Segment ID Check" of the draft claims to update "the procedure defined in Step 6 of Section 4.4  of [RFC8029]". However, I have failed to integrate the logic defined by the pseudocode in this section with the logic defined by the referenced pseudocode.

-          I have suspected that the newly introduced logic should be part of the Egress FEC Validation logic defined in Section 4.4.1 of RFC 8029.  This suspicion has been acknowledged by the authors, and they plan to fix the wrong reference in the next revision of the draft.

-          From my POV the best way to avoid possible misinterpretation by the implementers would be inclusion of the updated version of the pseudocode (with explicit marking of the new logic) directly in the document. I have suggested this to the authors, but I did not get their response so far.

Status in the -11 version of the draft:
The problematic text has been replaced with pseudocode that integrates the logic that has been defined in Section 4.4.1 of RFC 8029 with the new, SR-specific pseudocode. So, in a way, the original issue has been resolved. However, I have several issues with the current text:

-          From my POV, the pseudocode could be made much more readable if it were better structured. One possible way to do so could be defining how IGP extensions for SR can be treated as distributing if they distributed labels (including Implicit Null) for Node Segment IDs, and using the results in the original pseudocode of RFC 8029

-          The proposed pseudocode seems to lack the check of Label-L matching the Node Segment ID in the SRGB of the responder

-          It is not obvious how the proposed pseudocode treats previously defined FECs in the target FEC stack

-          Interface-I (the ingress interface of the received LSP Ping request) is only mentioned in the check of Adjacency SID. It is also not clear to me why the check expects its match with the Remote Interface ID in the Adjacency SID TLV.
I did not raise these issues in my original review exactly because it was impossible to integrate the new validation logic with the logic defined in RFC 8029. Please consider these issues as my IESG LC comments.

Major Issue #2 in the -06 version of the draft:
I agree with the previous reviewer regarding the mismatch between the (presumed) claim and the actual scope covered by the draft. To the best of my understanding, the authors have already agreed to fix this in the next revision of the draft.
Status in the -11 version of the draft:
The title of the draft has been changed to reflect its actual scope, and both the Abstract and Introduction clearly indicate that only IGP IP Prefix and Adjacency SIDs are covered by the draft. From my POV, this is sufficient, and this issue is resolved.

Minor Issue #1 in the -06 version of the draft:
I wonder why the authors place such an emphasis on Service labels (which, AFAIK, have not been defined in any level of detail anywhere so far) - these labels are mentioned in Sections 4.2, 5 (that mentions them as "Service segments")  and 8, while so many types of Segment IDs that are already well defined both in the SRPING WG documents and in the extensions of the relevant routing protocols are left out of scope of the draft.  The authors have acknowledged this and plan to fix this issue (probably by removing the Service labels completely).
Status in the -11 version of the draft:
Service labels and service segments do not appear in the new version of the draft.

Minor Issue #2 in the -06 version of the draft:
The description of possible data plane malfunctions in section 4.1 seems to assume that all the nodes in the referenced topology (shown in Figure 1) us the same SRGB. If this assumption (which is not explicitly mentioned) is not correct, the LSP Ping Echo request packets would not be "delivered to their expected destinations but not via the expected path" (as the text in this section claims). I suggest making any such assumptions explicit in the text.
Status in the -11 version of the draft:
The new text of section 4.1 explicitly mentions the assumption about same SRGB.

Minor Issue #3 in the -06 version of the draft:
I am not sure if "OSPF" and ISIS" (without any reference to Segment Routing) are the proper names for the label distribution protocols in the proposed new IANA registry in Section 10.2. From my POV "OSPF/ISIS SR Extensions" would be more appropriate. The authors disagree with this proposal claiming that OSPF and ISIS are not used for label distribution in any other way. (RFC 8029 that encodes the label distribution protocol in the Downstream  Detailed Mapping TLV did not request a dedicated registry for this purpose, and I think that the authors have been right to request such a registry).
Status in the -11 version of the draft:
The new version uses the same protocol names as the previous one. Meanwhile, I have found that OSPF and IS-IS can be used for distriburing label ranges for BIER (see OSPF Extensions for BIER<https://datatracker.ietf.org/doc/draft-ietf-bier-ospf-bier-extensions/?include_text=1> and a similar draft for ISIS). From my POV, this supports my recommendation to change the names of protocols to differentiate between multiple extensions to OSPF and IS-IS that distribute label ranges. Please consider this as my IESG LC WG comment.

Minor Issue #4 in the -06 version of the draft:
I doubt the draft needs address any FRR issues even in future (as mentioned in the last statement in Section 5), since, to the best of my understanding, any form of FRR:

-          Is operated locally by the node that is upstream to the failure without passing any information to the initiator of LSP-Ping Request packets

-          In any case is just a transient state in the (presumably short) interval between the failure being detected by the upstream node and re-convergence of IGP
I also think that references to "future versions" are not quite appropriate in the document that is going to the IETF LC. I recommend removing any such references from the document.
Status in the -11 version of the draft:
All mention of FRR has been removed from the new version, as well as any references to future versions.

Minor Issue #5 in the -06 version of the draft:
Section 9 "Backward Compatibility with non-Segment Routing devices" defines the behavior for the two slightly different use cases:
-              LSP Ping Echo Request packets are initiated by an SR-capable node (and therefore their target FEC stack contains SR-related FECs), while the responder is legacy device that is not SR-capable. In this case the proposed solution (respond with the FEC-return-code "Replying router has no mapping for the FEC at stack-depth") looks as the only possibility since the legacy device cannot parse SR FECs in any case
-              LSP Ping Echo Request packets are initiated by a legacy device while the responder is SR-capable. The draft defines the same behavior in this case - but, IMHO and FWIW, the responder could provide slightly better diagnostics since it can parse the "old" target FEC and recognize the equivalent Node ID. An additional return code would be required to implement this behavior.
This issue has not been discussed with the authors due to lack of time.
Status in the -11 version of the draft:
The authors have responded that a legacy (LDP-only) initiator of LSP Pings request messages in any case would not be able to parse a new return code. I agree with this comment, and withdraw the issue.

All the nits I've noticed also have been resolved. In particular, early IANA allocations that have expired on 15.09.17, have been extended to one more year.


Regards,
Sasha

Office: +972-39266302
Cell:      +972-549266302
Email:   Alexander.Vainshtein@ecitele.com


___________________________________________________________________________

This e-mail message is intended for the recipient only and contains information which is 
CONFIDENTIAL and which may be proprietary to ECI Telecom. If you have received this 
transmission in error, please inform us by e-mail, phone or fax, and then delete the original 
and all copies thereof.
___________________________________________________________________________