Re: [mpls] I-D Action: draft-ietf-mpls-static-yang-08.txt

Tarek Saad <tsaad.net@gmail.com> Fri, 08 March 2019 19:13 UTC

Return-Path: <tsaad.net@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D841E127A73 for <mpls@ietfa.amsl.com>; Fri, 8 Mar 2019 11:13:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GqiBhv3nTpdy for <mpls@ietfa.amsl.com>; Fri, 8 Mar 2019 11:13:11 -0800 (PST)
Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 829EA1313F9 for <mpls@ietf.org>; Fri, 8 Mar 2019 11:13:11 -0800 (PST)
Received: by mail-io1-xd31.google.com with SMTP id x9so17594507iog.12 for <mpls@ietf.org>; Fri, 08 Mar 2019 11:13:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :content-transfer-encoding:mime-version; bh=9jl6foEU3yfiCEWKiECev4NhD2dZcgL1733BYG47xRA=; b=bZKaTwKfLfVtzCQ2rJVaBACWrjjRLv06t1ne2fAxOF6MAgzwtRhnDuxSsCilo1+Uv7 HxTKLFQUCGtLw+gFX20HRlSJGHgmCae5e1Uz/TeyZKaGT7lpFg5bDpxCXL4C9LV8NiDl iOsIjZ0mNeJEGWdhSprSGVgQQjURYvc653u5b0aMR0wPxNrCicJs4FT0sOg//SMhvK4z RVSKooFPcppovjBkxijLiH6/AllYkIEuhcOKgc+MaPrhvfHLv+odQCtmse0ZrwDsOt3U 3eDrBE8v1693LsTky902dlYLh2O22ugqT40huKjGV1c0ouBZxhi+A8Ed2d8m+6xYbcr9 5CIw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:content-transfer-encoding:mime-version; bh=9jl6foEU3yfiCEWKiECev4NhD2dZcgL1733BYG47xRA=; b=Q65PESCqNr8ujo+vP3rlt0893OeKxaugu94Madl4rE3l3QL3YdxRtcIrdx34tFCBcT 8s1NKPmyYAfn47n+9FzB4xgDmWMBwxxU4P71Kq0uEyF850Mn2oeo1UzcVZxSTWs0VOYg W4wa85tPAUpij5Gu/zLv6k67nyTHJfiNodD7ksPjdzhDv2NGUnIu9u7hNhdBslzYZ+qp b3vXqstjZNZnZXpIP4WPOUWp1Yu+hcVHblm9xWokehvdIY0+hsZH86oNRD+VnZqAOJh8 E44XMxG15Onpwr4oSr9xY3+0lYOTqTGMf3J4DG2f5vTQtkdD/UekAMj8+XbnJstNjqdX XNJA==
X-Gm-Message-State: APjAAAX0JuCAJfpG/Op6cNYpbHrOd5fNNxGcDZCgnuey0Fbx/QJ6TEH3 GLD595gVh/BzlBI1f/J2Uio=
X-Google-Smtp-Source: APXvYqz27zzWlhrfxjFnBncF+DUydR2w55XpkOrZm+mKbCc+lf/UuT4g2upPHhCE+UhC/HCmQuxGCA==
X-Received: by 2002:a6b:7941:: with SMTP id j1mr10709474iop.262.1552072390820; Fri, 08 Mar 2019 11:13:10 -0800 (PST)
Received: from BN8PR06MB6289.namprd06.prod.outlook.com ([52.96.29.13]) by smtp.gmail.com with ESMTPSA id k3sm3336954ioa.47.2019.03.08.11.13.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Mar 2019 11:13:10 -0800 (PST)
From: Tarek Saad <tsaad.net@gmail.com>
To: tom petch <ietfc@btconnect.com>
CC: "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: [mpls] I-D Action: draft-ietf-mpls-static-yang-08.txt
Thread-Index: ATAwNDMx/sjNOmVXteTg2ZbdmzWIITAxNDQ2x8nT5hg=
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Fri, 8 Mar 2019 19:13:09 +0000
Message-ID: <BN8PR06MB62891CBCD1C236D82C172682FC4D0@BN8PR06MB6289.namprd06.prod.outlook.com>
References: <155155736768.27158.1653954565392604255@ietfa.amsl.com> <016901d4d379$a1e91e60$4001a8c0@gateway.2wire.net> <CAHVfGYrtzs_Q+7Q1v2yeTmhjKRMarVZOD_1kynOJVxHFcpmZVw@mail.gmail.com> <068601d4d4e3$c5dc4980$4001a8c0@gateway.2wire.net> <BN8PR06MB62890074D29EA4440AC6F170FC4D0@BN8PR06MB6289.namprd06.prod.outlook.com>
In-Reply-To: <BN8PR06MB62890074D29EA4440AC6F170FC4D0@BN8PR06MB6289.namprd06.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-Exchange-Organization-SCL: -1
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/fY9lVsoPF6Wou8anL11I5Jh99YM>
Subject: Re: [mpls] I-D Action: draft-ietf-mpls-static-yang-08.txt
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Mar 2019 19:13:14 -0000

Thanks Tom. The comments are addressed in version -09: 
https://tools.ietf.org/html/draft-ietf-mpls-static-yang-09

And diff:
https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-static-yang-09

Regards,
Tarek

On 3/8/19, 1:14 PM, "Tarek Saad" <tsaad.net@gmail.com> wrote:

    Hi Tom,
    
    Thanks. We'll unify to "Mbps" and keep this consistent in units and description.
    
    Regards,
    Tarek
    
    On 3/7/19, 7:48 AM, "tom petch" <ietfc@btconnect.com> wrote:
    
        Tarek
        
        One point I keep noticing but do not think I have raised before is
        
              units mbps;
              description
                "Bandwidth in Mbps,
        
        I have known systems fail because one party was using mbps, another
        Mbps, so seeing a mix of the two, as here, raises a flag for me.  I note
        that
        draft-ietf-teas-yang-te-types
        has
               units "Mbps";
        which I prefer - if they really mean Mbps and not mbps; I have my
        doubts! - but then
         draft-ietf-l2sm-l2vpn-service-model-10
        has
                units "mbps";
                default "10";  description
                  "LACP speed. By default, the lacp speed is 10Mbps.";
        
        Perhaps in the context of MPLS there is no ambiguity but it would be
        nice to have consistency at least within an I-D.
        
        Tom Petch
        
        ----- Original Message -----
        From: "Tarek Saad" <tsaad.net@gmail.com>
        Sent: Wednesday, March 06, 2019 2:53 PM
        
        
        > Hi Tom,
        >
        > As usual, thanks for your review on this one and for your patience.
        More
        > Inline..
        >
        > On Tue, Mar 5, 2019 at 12:36 PM tom petch <ietfc@btconnect.com> wrote:
        >
        > > A long and winding road!
        > >
        > >  module ietf-mpls-static {
        > > .....
        > >    import ietf-routing-types {
        > >      prefix "rt-types";
        > >      reference "RFC8294: Common YANG Data Types";
        > >
        > > I see, in the RFC Index,
        > >
        > > 8294 Common YANG Data Types for the Routing Area.
        > > i.e. a different title
        > >
        > > [TS]: yes, unfortunately a deja vu (fixed in another module). We'll
        take
        > care of this in the new version.
        >
        > >
        > > module ietf-mpls-static-extended {
        > > ....
        > >   import ietf-routing {    prefix "rt";
        > >     reference "RFC6991: Common YANG Data Types";
        > > I suggest
        > >      reference "RFC8349: A YANG Data Model for Routing Management";
        > >
        > > [TS]: yes, will take of this.
        >
        >  reference "RFC XXXX: Extended YANG Data Model for MPLS Static LSPs";
        > > um - I see this I-D as titled
        > > A YANG Data Model for MPLS Static LSPs
        > >
        > > [TS]: OK for this one too.
        >
        > Regards,
        > Tarek
        >
        >
        > >
        > > Tom Petch
        > >
        > >
        > > ----- Original Message -----
        > > From: <internet-drafts@ietf.org>
        > > To: <i-d-announce@ietf.org>
        > > Cc: <mpls@ietf.org>
        > > Sent: Saturday, March 02, 2019 8:09 PM
        > >
        > > > A New Internet-Draft is available from the on-line Internet-Drafts
        > > directories.
        > > > This draft is a work item of the Multiprotocol Label Switching WG
        of
        > > the IETF.
        > > >
        > > >         Title           : A YANG Data Model for MPLS Static LSPs
        > > >         Authors         : Tarek Saad
        > > >                           Rakesh Gandhi
        > > >                           Xufeng Liu
        > > >                           Vishnu Pavan Beeram
        > > >                           Igor Bryskin
        > > > Filename        : draft-ietf-mpls-static-yang-08.txt
        > > > Pages           : 18
        > > > Date            : 2019-03-02
        > > >
        > > > Abstract:
        > > >    This document contains the specification for the MPLS Static
        Label
        > > >    Switched Paths (LSPs) YANG model.  The model allows for the
        > > >    provisioning of static LSP(s) on Label Edge Router(s) LER(s)
        and
        > > >    Label Switched Router(s) LSR(s) devices along a LSP path
        without
        > > the
        > > >    dependency on any signaling protocol.  The MPLS Static LSP
        model
        > > >    augments the MPLS base YANG model with specific data to
        configure
        > > and
        > > >    manage MPLS Static LSP(s).
        > > >
        > > >
        > > > The IETF datatracker status page for this draft is:
        > > > https://datatracker.ietf.org/doc/draft-ietf-mpls-static-yang/
        > > >
        > > > There are also htmlized versions available at:
        > > > https://tools.ietf.org/html/draft-ietf-mpls-static-yang-08
        > > >
        https://datatracker.ietf.org/doc/html/draft-ietf-mpls-static-yang-08
        > > >
        > > > A diff from the previous version is available at:
        > > > https://www.ietf.org/rfcdiff?url2=draft-ietf-mpls-static-yang-08
        > > >
        > > >
        > > > Please note that it may take a couple of minutes from the time of
        > > submission
        > > > until the htmlized version and diff are available at
        tools.ietf.org.
        > > >
        > > > Internet-Drafts are also available by anonymous FTP at:
        > > > ftp://ftp.ietf.org/internet-drafts/
        > > >
        > > > _______________________________________________
        > > > I-D-Announce mailing list
        > > > I-D-Announce@ietf.org
        > > > https://www.ietf.org/mailman/listinfo/i-d-announce
        > > > Internet-Draft directories: http://www.ietf.org/shadow.html
        > > > or ftp://ftp.ietf.org/ietf/1shadow-sites.txt
        > >
        > > _______________________________________________
        > > mpls mailing list
        > > mpls@ietf.org
        > > https://www.ietf.org/mailman/listinfo/mpls
        > >
        >