Re: [mpls] AD review of Soft Preemtion work

JP Vasseur <jvasseur@cisco.com> Mon, 27 July 2009 13:36 UTC

Return-Path: <jvasseur@cisco.com>
X-Original-To: mpls@core3.amsl.com
Delivered-To: mpls@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id D15783A6C86 for <mpls@core3.amsl.com>; Mon, 27 Jul 2009 06:36:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.269
X-Spam-Level:
X-Spam-Status: No, score=-9.269 tagged_above=-999 required=5 tests=[AWL=1.330, BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MkzkII-ECs5w for <mpls@core3.amsl.com>; Mon, 27 Jul 2009 06:36:23 -0700 (PDT)
Received: from ams-iport-1.cisco.com (ams-iport-1.cisco.com [144.254.224.140]) by core3.amsl.com (Postfix) with ESMTP id 372B63A6C80 for <mpls@ietf.org>; Mon, 27 Jul 2009 06:36:23 -0700 (PDT)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AkkAAONJbUqQ/uCLe2dsb2JhbACaAAEBFiQGnyiIKI19BYQN
X-IronPort-AV: E=Sophos;i="4.43,276,1246838400"; d="scan'208";a="45912419"
Received: from ams-dkim-2.cisco.com ([144.254.224.139]) by ams-iport-1.cisco.com with ESMTP; 27 Jul 2009 13:36:23 +0000
Received: from ams-core-1.cisco.com (ams-core-1.cisco.com [144.254.224.150]) by ams-dkim-2.cisco.com (8.12.11/8.12.11) with ESMTP id n6RDaMQp028427; Mon, 27 Jul 2009 15:36:22 +0200
Received: from xbh-ams-101.cisco.com (xbh-ams-101.cisco.com [144.254.74.71]) by ams-core-1.cisco.com (8.13.8/8.14.3) with ESMTP id n6RDaNpw015295; Mon, 27 Jul 2009 13:36:23 GMT
Received: from xfe-ams-331.emea.cisco.com ([144.254.231.72]) by xbh-ams-101.cisco.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 27 Jul 2009 15:36:23 +0200
Received: from dhcp-1263.meeting.ietf.org ([10.61.101.196]) by xfe-ams-331.emea.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 27 Jul 2009 15:36:22 +0200
From: JP Vasseur <jvasseur@cisco.com>
To: Adrian Farrel <adrian@olddog.co.uk>, Lou Berger <lberger@labn.net>
In-Reply-To: <94732346-1248697436-cardhu_decombobulator_blackberry.rim.net-798547217-@bxe1172.bisx.prod.on.blackberry>
X-Priority: Normal
References: <B5DC6E5281A14B378B851F457DDF2D9B@your029b8cecfe><4A59E491-CFFB-44F9-AE4F-8E14F7E5A811@cisco.com> <94732346-1248697436-cardhu_decombobulator_blackberry.rim.net-798547217-@bxe1172.bisx.prod.on.blackberry>
Message-Id: <0A93208D-CFBA-40C6-B86B-AE29F42E5288@cisco.com>
Content-Type: text/plain; charset="US-ASCII"; format="flowed"; delsp="yes"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v935.3)
Date: Mon, 27 Jul 2009 15:36:21 +0200
X-Mailer: Apple Mail (2.935.3)
X-OriginalArrivalTime: 27 Jul 2009 13:36:22.0583 (UTC) FILETIME=[3B0E8470:01CA0EBF]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; l=4860; t=1248701782; x=1249565782; c=relaxed/simple; s=amsdkim2001; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=jvasseur@cisco.com; z=From:=20JP=20Vasseur=20<jvasseur@cisco.com> |Subject:=20Re=3A=20AD=20review=20of=20Soft=20Preemtion=20w ork |Sender:=20; bh=4meLuqjvmVHMlfVU+Jw3kRbpaNxFoaVU+7vYnEB6QCg=; b=MNwqG2uIEmCFgYuVlVwNksIq/3a9AM1NOhxg5dIwGPN6HgHMjSfJ4MxchM 73hVeLQ/chZsyCCzV4srbaU+wdDJpkEN6vx8ymCm1tBP8+Gk5l7K/eawQY85 BGiHxwIZOx;
Authentication-Results: ams-dkim-2; header.From=jvasseur@cisco.com; dkim=pass ( sig from cisco.com/amsdkim2001 verified; );
Cc: mpls@ietf.org, draft-ietf-mpls-3209-patherr@tools.ietf.org, "Deborah Beebe (dbeebe)" <dbeebe@cisco.com>, draft-ietf-mpls-gmpls-lsp-reroute@tools.ietf.org, draft-ietf-mpls-soft-preemption@tools.ietf.org, mpls-ads@tools.ietf.org, mpls-chairs@tools.ietf.org
Subject: Re: [mpls] AD review of Soft Preemtion work
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mpls>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jul 2009 13:36:24 -0000

Hi Lou,

On Jul 27, 2009, at 2:23 PM, Lou Berger wrote:

> JP,
>
> Why do you say MPLS only?
>

It does but a fatal error in the packet case is quite different than  
in the non packet case. That said, the signaling of a fatal error is  
unchanged.

> It seems to me that this draft could be applied to gmpls as wellll  
> The definition of "fatal error" may be different for gmpls and mpls,

Exactly.

> but as this term isn't defined anywhere there is no issue.
>

Fine with me for sure. Adrian ?

Thanks.

JP.

> Lou
> -----Original Message-----
> From:  JP Vasseur <jvasseur@cisco.com>
>
> Date: Sun, 26 Jul 2009 22:12:14
> To: Adrian Farrel<adrian@olddog.co.uk>; Lou  
> Berger<lberger@labn.net>; Deborah Beebe (dbeebe)<dbeebe@cisco.com>
> Cc: <draft-ietf-mpls-soft-preemption@tools.ietf.org>; <draft-ietf-mpls-3209-patherr@tools.ietf.org 
> >; <draft-ietf-mpls-gmpls-lsp-reroute@tools.ietf.org>; <mpls-chairs@tools.ietf.org 
> >; <mpls-ads@tools.ietf.org>; <mpls@ietf.org>
> Subject: Re: AD review of Soft Preemtion work
>
>
> Hi Adrian,
>
> I basically agree with all your comments ...
> Few comments/replies:
> With regards to the path-error ID, it is IMO MPLS focussed, Lou/
> Deborah may want to chime in.
> I definitely agree to insert of reference to 5511. For the other
> changes, I tend to think that they could be addressed with an editor
> note but your call of course.
>
> Thanks.
>
> JP.
>
> On Jul 26, 2009, at 1:32 PM, Adrian Farrel wrote:
>
>> Hi,
>>
>> I've been reading draft-ietf-mpls-3209-patherr-04.txt,
>>
>> prior to kicking off IETF last call.
>>
>> I don't have many questions...
>>
>> The Abstract and Introduction to draft-ietf-mpls-3209-patherr-04.txt
>> explicitly call out MPLS when discussing RSVP-TE PathErr messages.
>> But they do not mention GMPLS. In fact, the only reference to
>> RFC3473 is in section 2.2. I think that the text needs to be clear
>> on whether or not it is intended to apply to GMPLS signaling. This
>> obviously affects how the document is read and applied, and should
>> not be left for people to assume (one way or the other).
>>
>> draft-ietf-mpls-3209-patherr-04.txt uses some BNF (copied from RFC
>> 2205). New "rules" require that any document that uses a formal
>> language includes a reference to the definition of the formal
>> language. Your choice here is:
>> - leave out the text copy from 2205
>> - insert a reference to RFC 5511
>>
>> draft-ietf-mpls-3209-patherr-04.txt Page 4
>> Additionally, PathErr messages may be used in two circumstances:
>> Strike "Additionally,"
>>
>> The RFC Editor will require the first section of draft-ietf-mpls-
>> soft-preemption-17.txt to be the Introduction. I think you can
>> simply re-order the sections you already have, and expand the
>> acronyms in the Introduction section.
>>
>> I am trying to not re-open my mailing list discussions of draft-ietf-
>> mpls-soft-preemption-17.txt from the last couple of years. :-) In
>> section 6.1 you have
>> For each preempted TE LSP, instead of sending an RSVP Path Tear
>> message after the receipt of an RSVP PathErr message notifying a
>> fatal action as documented in [I-D.ietf-mpls-3209-patherr] upon
>> preemption as with hard preemption (which would result in an
>> immediate traffic disruption for the preempted TE LSP), the
>> preempting node's local bandwidth accounting for the preempted TE LSP
>> is zeroed and a PathErr with error code "Reroute" and a error value
>> "Reroute request soft preemption" for that TE LSP is issued upstream
>> toward the head-end LSR.
>> I can't parse this single-sentence paragraph. Can you look at how to
>> break it up? I think the node being described is the preempting
>> node. But the preempting node does not receive a PathErr so the
>> first part of the sentence confuses me.
>>
>> draft-ietf-mpls-soft-preemption-17.txt section 6.1
>> Should a refresh event for a soft preempted TE LSP arrive before the
>> soft preemption timer expires, the soft preempting node MUST continue
>> to refresh the TE LSP.
>> This is the first mention of a soft preemption timer. I think you
>> need to swap the text around so the definition of the timer (2 paras
>> later) is introduced first.
>>
>> draft-ietf-mpls-soft-preemption-17.txt Section 13.2
>> [I-D.ietf-mpls-3209-patherr] should be a Normative reference
>>
>>
>> I have marked the documents as:
>> draft-ietf-mpls-soft-preemption  "AD Evaluation : Revised I-D Needed"
>> draft-ietf-mpls-3209-patherr  "AD Evaluation : Revised I-D Needed"
>> draft-ietf-mpls-gmpls-lsp-reroute  "AD Evaluation : External Party"
>>
>> I'm willing to discuss:
>> a. whether these changes are needed
>> b. whether the changes need a respin or an RFC Editor note
>>
>> Cheers,
>> Adrian
>>
>>
>>
>
>