Re: [mpls] WGLC for draft-ietf-mpls-ldp-yang

tom petch <ietfc@btconnect.com> Sat, 28 July 2018 10:31 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F30C2130E3E; Sat, 28 Jul 2018 03:31:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 3.188
X-Spam-Level: ***
X-Spam-Status: No, score=3.188 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RATWARE_OUTLOOK_NONAME=2.95, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5xzfO1f4zrix; Sat, 28 Jul 2018 03:31:55 -0700 (PDT)
Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30131.outbound.protection.outlook.com [40.107.3.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0481F130E4F; Sat, 28 Jul 2018 03:31:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector1-btconnect-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxkaaFJ/y0GQa1+0u87gWVfeMlIfWSXjl8yKs+8VbSw=; b=eazv11WZ8GZAFODTfHK5m+Odmx9/T3oaY5eEIKWNQNAzS+FFlNvcHHj32pz2edU64ULKLPuD9XeL3K2S2mN6x5V99lin9bJdgoOfs3yLw9oLJhxhZxNPSofIVB9tGNJLvijUgL3ajxGLRpJ9Y0vnkZMMSwr6VtdYfENdK6mx7VM=
Received: from VI1PR07MB0831.eurprd07.prod.outlook.com (10.161.107.154) by VI1PR07MB3966.eurprd07.prod.outlook.com (52.134.28.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.10; Sat, 28 Jul 2018 10:31:52 +0000
Received: from VI1PR07MB0831.eurprd07.prod.outlook.com ([fe80::6d94:2d16:29ed:70d9]) by VI1PR07MB0831.eurprd07.prod.outlook.com ([fe80::6d94:2d16:29ed:70d9%7]) with mapi id 15.20.0995.019; Sat, 28 Jul 2018 10:31:52 +0000
From: tom petch <ietfc@btconnect.com>
To: "N.Leymann@telekom.de" <N.Leymann@telekom.de>, "mpls@ietf.org" <mpls@ietf.org>
CC: "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "draft-ietf-mpls-ldp-yang@ietf.org" <draft-ietf-mpls-ldp-yang@ietf.org>
Thread-Topic: [mpls] WGLC for draft-ietf-mpls-ldp-yang
Thread-Index: AQHUJl4xVpN2cQ2xl0mJhGdT3lNtHA==
Date: Sat, 28 Jul 2018 10:31:52 +0000
Message-ID: <003401d4265d$c89c7da0$4001a8c0@gateway.2wire.net>
References: <LEJPR01MB0377B9F7593FC090FEC40B5F98540@LEJPR01MB0377.DEUPRD01.PROD.OUTLOOK.DE>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: DB6PR0902CA0005.eurprd09.prod.outlook.com (2603:10a6:6:2::18) To VI1PR07MB0831.eurprd07.prod.outlook.com (2a01:111:e400:508e::26)
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [86.165.129.102]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; VI1PR07MB3966; 6:WyIGPqDCS7Nf2ikOMj3zZX1JSPww5w9GTmK8lmZ2oeQWwgUra3yp510yV1++YSx7pESN2km2wxUbgjW6lJrBBP6jytYUXqtRDwCTBcZ5GePdmAZkEvlRpNpGLkbaPzPd8bNaXnFumwuFh/yfew3y3VavQgD615wwjFHx8FFDCzofL0ogWdPM6HCbzouAaG1QVg3fOoHJDJVPZzE5VAynu5QaRE3jRtyZGUtO777mpClDEqkBuiV5pikiy4tT3Whu1vH5t7ItxGTuVxx3UGLtUzDMBXO8V6u98wNWdl5v6oXdf32BdETtcwp1noG9H+xvsvVBmweewurLG9b1bRHYC42tYGaCc0o4gyqqsvGs37QxHZGfQcsB+aJuVW6pOw6NpbKGMjMcLQTu67E9JL92acHJ0QLUsjIuXXJ2BsT7IsCuIbfoyz6PKbTiOwzkpgPZOqwcfCpJwXI80AQ339t6lw==; 5:/RRd/tC7jrCZWdDK6U6P/VkHnklXWl+NN/IRHKOVlQFWFOOrhoeYVvSI0vBW88vk9i1ZYPyLXYLDBmdG94xrZ04tKWgqHa9FmMYdwpFwZWUCck8Q4b5blT8Y2NaaUGk4Ew/AaSkTpui05MMmt0lcFS1rRSCC0lkwpMQNlV+3L30=; 7:R51uXGYmsKaKOAhoR/+UUDYKyRBvuiDwAGv7VFLoRSL4Zn5HRd0plZ0/prmjGGEVWgQxn94ndLngPnkKGgY/70t9Ya+A9UR5ReywFp70GaDYmPkVW+LiCfPEqCVPGq0LfMC1dBD/hmcvfe5cTi19lpjJpVUBGqQ0cmJBGCunaQyFw6Ou105xNHaX1lX7yhceMOsmAYwKvzhSsz7EvmxVqj0c2QQdJ5s6oSuuBy56Nq9SAkACPgw53mc+Tk+IWJJT
x-ms-office365-filtering-correlation-id: 9303d324-82e4-4fc0-dd76-08d5f4755404
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7193020); SRVR:VI1PR07MB3966;
x-ms-traffictypediagnostic: VI1PR07MB3966:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-microsoft-antispam-prvs: <VI1PR07MB3966F997E306C7D7EFDAF78EA0290@VI1PR07MB3966.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(192374486261705)(260130700054247)(788757137089);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:VI1PR07MB3966; BCL:0; PCL:0; RULEID:; SRVR:VI1PR07MB3966;
x-forefront-prvs: 07473990A5
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(39860400002)(396003)(136003)(376002)(199004)(189003)(13464003)(81166006)(81156014)(68736007)(7736002)(99286004)(6246003)(4326008)(25786009)(5660300001)(305945005)(54906003)(1556002)(97736004)(316002)(14444005)(8936002)(66066001)(3846002)(6116002)(53936002)(84392002)(256004)(110136005)(86152003)(486006)(9686003)(8676002)(6512007)(478600001)(6306002)(6436002)(446003)(44736005)(6486002)(14454004)(106356001)(86362001)(2906002)(476003)(26005)(229853002)(186003)(102836004)(14496001)(2900100001)(105586002)(386003)(6506007)(52116002)(966005)(76176011)(33896004)(5250100002)(2501003); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR07MB3966; H:VI1PR07MB0831.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:1;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: vjQYdNIo+YE1A/xL/oYBWpxCjO6WokLz38cdFKw6MQz0l9keJw2Vl4b0OkNoyKcpaKYxdlUENMTCLSdZfPvRINd5LA+YI5wjObXD8wFdQBf601s6PQTje3xLceoYuKSygtR0PNiOJylDEaw6RHQKMPpUM/Jh2hsBatPBrxWK1FnmW175lY7yh19b5nxzM0wkFoHBC9aJkF7WAoKyi5WAn3btxRhA9wA470g3OWIIom4JwFWUqeRIcFyr1IEi8/D8W72hVuoSEQPhflaV/Dq70PsyZ/Sh+wQK4ao8KYLoRkNc6XkBbjJipdnKAwq+fecjXL/ZLdt/i69WH6cV5pyu9rI04PpLhQ8Bla0jr+UxTtI=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <E774D4CEF58F9A43927B9226F09E808E@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9303d324-82e4-4fc0-dd76-08d5f4755404
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2018 10:31:52.3248 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB3966
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/ZeG8BnunVb-FMcIBEiF8dfMWiuc>
Subject: Re: [mpls] WGLC for draft-ietf-mpls-ldp-yang
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Jul 2018 10:31:58 -0000

The YANG module is deficient in a number of respects, which I have come
to think of as boiler plate issues, since they are deficient in almost
all the I-Ds from the Routing Area:-)

- RFC2119 boiler plate lacks reference to RFC8174 and you have lower
case 'should'

- NMDA is mentioned in the Introduction but it is usually called out in
the Abstract as well

- no Note to RFC Editor asking them to replace XXXX with the number
assigned to this RFC

- no Note to RFC Editor asking them to replace the four dates in the
YANG modules with the date of publication

- no YANG Version statement in the YANG modules

- no mention of the current YANG 1.1 RFC

- no reference statements for the import modules in the YANG modules and
their RFC are missing from the Normative References of the I-D

- no Informative Reference to the Tree Diagrams RFC8340

- Security Considerations do not conform to rfc6087bis and lack the
Normative References that that calls for

- you MUST have IANA Considerations else you do not have a YANG module

- the reference for
   [I-D.ietf-netmod-revised-datastores]
is out of date

- RFC6536 has been superseded

- the reference for
[I-D.ietf-mpls-mldp-yang]
is out of date

Incidentally, the authors of
draft-ietf-mpls-mldp-yang-04
might learn something from this list.

Tom Petch

----- Original Message -----
From: <N.Leymann@telekom.de>
To: <mpls@ietf.org>
Cc: <mpls-chairs@ietf.org>; <draft-ietf-mpls-ldp-yang@ietf.org>
Sent: Wednesday, July 25, 2018 4:11 PM

> Dear Working Group,
>
> This mail initiates the two week working group last call on
draft-ietf-mpls-ldp-yang- which is considered
> mature and ready for a final working group review.
>
> Please read this document if you haven't read the most recent version
yet, and send your comments to
> the list, not later than 10th of August.
>
> There are no IPR disclosures against draft-ietf-mpls-ldp-yang.
>
> This working group last call ends August 10th, 2018.
>
> Best regards
>
>    Nic
>
> _______________________________________________
> mpls mailing list
> mpls@ietf.org
> https://www.ietf.org/mailman/listinfo/mpls