Re: [mpls] Rtgdir early review of draft-ietf-mpls-mna-requirements-12

["Matthew Bocci (Nokia)" <[e-mail]>]

Hi Sue

Thanks for your review. These overlapped with addressing some comments from the review by our AD. I will make updates to v13, which I just posted, based on your review.

I am fine with your nits and will address them.

Regarding your technical suggestion to pull in more from the MNA framework security considerations, I am a little reticent to just take a snippet from the framework security considerations without the broader context of how MNA might be deployed. We already have a cross reference to the MNA framework security considerations, but maybe that sentence could be strengthened to indicate that the frameworks security considerations should be taken together with those in the requirements document?

Matthew


From: Susan Hares via Datatracker <[e-mail]>
Date: Sunday, 21 April 2024 at 13:03
To: [e-mail] <[e-mail]>
Cc: [e-mail] <[e-mail]>, [e-mail] <[e-mail]>
Subject: Rtgdir early review of draft-ietf-mpls-mna-requirements-12

CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



Reviewer: Susan Hares
Review result: Has Nits

Status: Ready with NITS

Summary: No Technical issues were found when examined with:
- draft-ietf-mpls-mna-usecases-04
- draft-ietf-mpls-mna-fwk-07

One technical suggestion:
I think more of the MNA framework security consideration should be pulled into
this document to cover: - current network boundaries using filters that form a
trust boundary, - differences with new boundaries that impact that trust
boundary.

By reference of draft-ietf-mpls-mna-fwk, one can find the technical material.
However, a bit more in the text would help the reader.

MPLS-chairs,
Thank you for your patience in waiting for this early review.
Sue

=====================
NITS
1. Requirement #33
Why: Grammar and sentence clarity
Old text:/
   33.  NAIs MUST only be inserted at LSRs that push a label onto the
        stack, e.g. head end LSRs and points of local repair (PLR), but
        can be processed by LSRs along the path of the LSP./

comment: The text
"/, the use of ".e.g. head end LSR and points of local report (PLR), /

is confusing and difficult to read.  Consider rewriting the sentence.

#2 Requirement #39.
Why: Grammar and sentence clarity - the "i.e." detracts from clarity without
adding value. Text:/
   39.  A network action solution specification MUST state where the
        NAIs are to be placed in the packet i.e. in-stack or post-stack.
     /
Suggested New text:/
   39.  A network action solution specification MUST state where the
        NAIs are to be placed in the packet i.e. in-stack or post-stack.
     /

#3 Requirement #47
Why: Grammar and sentence clarity. "inserting" and "that"
Current text:/
   47.  An MNA solution MUST allow an LER inserting ancillary data to
        determine that each node that needs to process the ancillary
        data can read the required distance into the packet at that node
        (compare with the mechanism in [RFC9088])./
Suggested text:/
   47.  An MNA solution MUST allow an LER that inserts ancillary data to
        determine whether each node that needs to process the ancillary
        data can read the required distance into the packet at that node
        (compare with the mechanism in [RFC9088])./

#4: Section 5, paragraph 2, second sentence
Why: Grammar - Commas in sentence make it difficult to read, "labelled"
(spelling ?).

Current text:/
   Furthermore, an LSR may insert information into the
   labelled packet such that the forwarding behavior is no longer purely
   a function of the top label, or other label with forwarding context,
   but instead is the result of a more complex heuristic./

Perhaps consider a rewrite.
New text:/
   An LSR may insert information into a label packet such that the
   forwarding behavior is no longer a function of either the top label or
   another label within the forwarding context, but a result
   complex heuristic. /

Thank you for your patience in receiving this early