Re: [mpls] Routing directorate QA review of draft-filsfils-spring-segment-routing-ldp-interop

Alexander Vainshtein <Alexander.Vainshtein@ecitele.com> Tue, 28 July 2015 16:37 UTC

Return-Path: <Alexander.Vainshtein@ecitele.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3460A1ACE96; Tue, 28 Jul 2015 09:37:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FSL_MY_NAME_IS=0.001, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Virb1jnAdgSq; Tue, 28 Jul 2015 09:37:27 -0700 (PDT)
Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0797.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe04::797]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 961731ACE80; Tue, 28 Jul 2015 09:37:13 -0700 (PDT)
Received: from DB3PR03MB299.eurprd03.prod.outlook.com (10.242.131.144) by DB3PR03MB0794.eurprd03.prod.outlook.com (10.161.55.139) with Microsoft SMTP Server (TLS) id 15.1.225.19; Tue, 28 Jul 2015 16:36:52 +0000
Received: from DB3PR03MB0780.eurprd03.prod.outlook.com (10.161.55.12) by DB3PR03MB299.eurprd03.prod.outlook.com (10.242.131.144) with Microsoft SMTP Server (TLS) id 15.1.225.19; Tue, 28 Jul 2015 16:36:51 +0000
Received: from DB3PR03MB0780.eurprd03.prod.outlook.com ([10.161.55.12]) by DB3PR03MB0780.eurprd03.prod.outlook.com ([10.161.55.12]) with mapi id 15.01.0225.018; Tue, 28 Jul 2015 16:36:51 +0000
From: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com>
To: "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
Thread-Topic: Routing directorate QA review of draft-filsfils-spring-segment-routing-ldp-interop
Thread-Index: AdDJU4rozHs9zgL9Q6awOhnek/vb5w==
Date: Tue, 28 Jul 2015 16:36:51 +0000
Message-ID: <DB3PR03MB0780A7F30E35B8D04B020BE79D8D0@DB3PR03MB0780.eurprd03.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: tools.ietf.org; dkim=none (message not signed) header.d=none;
x-originating-ip: [109.66.1.206]
x-microsoft-exchange-diagnostics: 1; DB3PR03MB299; 5:LuXU3qcBFkxCpaqMksnRLY9KxxecbQJde2LhOdgAWz1ljBaIkVXnCOxmQqnD1ftkFTywHZVmun1dxK/kAi2vd9OHq18pqg00X/EB179tiMp8KxL4ZmzMjMGkNSHd6KlisrjF6d4J8G7CPMoWzc42mw==; 24:+isdw1zhettUGkoNKUsxiHUjSqxBzub/Uj7xB+0NqUDkaGLlbxUxRETWgnQkJYRpAzMkvS2Y/vhfLQqsPXLuWOBkQGLg1lD/u7i3yi3qCGo=; 20:l7952jHuXANBn2vKaHunrOLaXu+3XWlcYW3REnQqnnV+hP1tt/+DDPVuhAEpS5PMCP8HZr+BofmD6Lwycd1sQw==
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:; SRVR:DB3PR03MB299; UriScan:; BCL:0; PCL:0; RULEID:; SRVR:DB3PR03MB0794;
db3pr03mb299: X-MS-Exchange-Organization-RulesExecuted
x-microsoft-antispam-prvs: <DB3PR03MB299C8B3519E077F43A87C309D8D0@DB3PR03MB299.eurprd03.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(108003899814671);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:DB3PR03MB299; BCL:0; PCL:0; RULEID:; SRVR:DB3PR03MB299;
x-forefront-prvs: 06515DA04B
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(252514010)(377454003)(37854004)(51444003)(66654002)(122556002)(86362001)(2656002)(66066001)(2900100001)(19617315012)(19580395003)(87936001)(40100003)(54356999)(19300405004)(92566002)(555904002)(2351001)(50986999)(62966003)(46102003)(230783001)(189998001)(5003600100002)(110136002)(5002640100001)(16236675004)(77156002)(19625215002)(76576001)(5001960100002)(2501003)(19580405001)(77096005)(33656002)(102836002)(15975445007)(74316001)(7059030)(579004)(559001)(36394004); DIR:OUT; SFP:1102; SCL:1; SRVR:DB3PR03MB299; H:DB3PR03MB0780.eurprd03.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_DB3PR03MB0780A7F30E35B8D04B020BE79D8D0DB3PR03MB0780eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2015 16:36:51.5188 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2c514a61-08de-4519-b4c0-921fef62c42a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR03MB299
X-Microsoft-Exchange-Diagnostics: 1; DB3PR03MB0794; 2:AxLS0cb3yHFJiQjue9bbyc16tbkxQITgAtfzOUp+6be4E5UTswYaqsmJOfFGz5op2bkhGTx1S9Weu9FNxuGhCJDGZzxrPXlVZ3zGiti4U+rFRBXlSR9LKZuuUjJB8PqLBjBCSuc+jBKsHrgdJEuAqpUGLgisPS9AIyqaf2UYR9c=; 3:3hT4y0Ct7H14Q6LETIspbbaOYEWTYNrRoT9dquiFG1ipsFg+U7i4+QvkeVsu9D0encu2jKy4MK4UMnNUccnLrBNhfjNgMBbCZA7pAD4y1PrsMXKmr9v127Eqh/44EE1abxzanCcCDxU4zs4Wa0abng==; 25:Kx7LkEtX0L+B9ZHGKGCzZSvNSmUTxrh/nXogiolAxGDjPpfvxiDGW7L1xsM0mCr0w7zW6T/fLe2TQkemaVGnmS0vqJpcZ8MpNoxoJgxm5PSiHG7e2YMvf+Ho3HuSpxDak1zgi5b4LJ4btKhPALra40XVo9Regv1OJSo/YoTF0+roZPgI6TcLDYpp1y9RzZ8sBRV44geRd+Fr657/m0/UMMe6EYYYycg5Il+937/RdaxlOsBKoZ5IgiZrnAxmZpF0PkhkBptxazvUw1e3+FEAFw==; 20:Lm0L75f5tG0oBF/sMl+4B0TgWWHk7eHajJB3ytwzJKvlqJwr8bY84fIGCfbZVg78d7gGHRV+96RYgZDt4tHzHw==; 23:XqzhgXKEF+GUsghdxYbxQ8oSxBJymT/k/ZivXFICPkGFLeRW608unbOneM7BFpaF+umbTVsJK1hmxTWeml+NyT5cn4qjp8C2NE//7f4s+DP/BKMd1eQCZrhI6DRyB2pyw+YSXSVv6vstrwGV0VrB+K0GMPweWnNnyX2POHn2xpOqN2kmtU/QABNNyBVi4L8l4kmHrWwJq3neiR2I8B8yEvjz3qxrvGkCiWBnCgpQjUrpuspSEWvCyBgOdubs68gZ
DB3PR03MB0794: X-MS-Exchange-Organization-RulesExecuted
X-OriginatorOrg: ecitele.com
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/c4VwFqDWvmRaUFISWWjjO2YFWWo>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "spring@ietf.org" <spring@ietf.org>, "Martin.Horneffer@telekom.de" <Martin.Horneffer@telekom.de>, "cfilsfil@cisco.com" <cfilsfil@cisco.com>, "mpls@ietf.org" <mpls@ietf.org>, "edward.crabbe@gmail.com" <edward.crabbe@gmail.com>, "igormilojevic@telekom.rs" <igormilojevic@telekom.rs>, "rob.shakir@bt.com" <rob.shakir@bt.com>, "sprevidi@cisco.com" <sprevidi@cisco.com>, Jon Hudson <jon.hudson@gmail.com>
Subject: Re: [mpls] Routing directorate QA review of draft-filsfils-spring-segment-routing-ldp-interop
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2015 16:37:33 -0000

Hi,

My name is Sasha Vainshtein, and  I have been asked to perform the QA review of https://datatracker.ietf.org/doc/draft-filsfils-spring-segment-routing-ldp-interop/.



Due to health problems I have been very late (but, hopefully, not too late) with this review, and here it is.



Does the draft solves a real problem? From my POV, definitely yes.

          1.         The problem stems from the following combination of facts fact that:

a.       LDP distributes labels for FECs represented by IP prefixes (among other things).

b.      LDP-based MPLS network are very widely deployed

c.       SR operating over the MPLS DP allocates labels for SIDs that can represent IP prefixes (again, among other things)

d.      As a consequence, LDP and SR may effectively map the same IP prefix to different labels.

          2.         As SR using the MPLS DP is gaining acceptance in the industry, the following deployment scenarios look as realistic to me:

a.       Coexistence  between LDP-based and SR-based control planes in the same network

b.      Partial deployment of SR in some sub-domains of a network combined with the operators' need to use the benefits of SR where it is already deployed

c.       Gradual transition of services  (especially L2 and L3VPN) tunnelled over LDP-created LSPs to LSPs set up using SR (and, possibly, vice versa)



Is the draft a good enough start for a WG document? From my POV, yes.

1         The draft covers multiple (if not all) realistic use cases for coexistence of LDP-based and SR-based control planes and provides  what looks to me as reasonable solutions for these scenarios.

2         At the same I would think that additional work is required to complete the work.



Specific issues with the current draft:

1         Editorial: SR-related abbreviations (e.g., SRGB, SID etc.) are used without expansion at the first use, and there is no "Abbreviation" section in the draft.

2         Process/Editorial: The draft currently lists 12 authors on its title page exceeding the recommended RFC Editor maximum of 5 authors.

          3.         Technical: The draft does not analyse the use case  of coexistence between SR and LDP with enabled extension for multi-area LSPs as per RFC 5283<https://datatracker.ietf.org/doc/rfc5283/?include_text=1>=1>. I think that this use case deserves special consideration in the draft because:

a.       It mentions the use case of seamless MPLS and refers to the (expired) Seamless MPLS Architecture<https://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDirDocQahttps:/www.ietf.org/archive/id/draft-ietf-mpls-seamless-mpls-07.txt> draft

b.       The seamless MPLS Architecture draft, in its turn, explicitly refers to RFC 5283 in Section 5.1.1 to facilitate binding of labels received via the DoD LDP session while only default route is configured in the RIB of the access node in the seamless MPLS architecture

c.       It is possible that this use case would not add anything to the draft - but I would prefer to see it in the document with the appropriate explanation

          4.         Technical: Section 8 "Manageability Considerations" is currently left empty. When this section is written, I would expect at least the following:

a.       Some level of detail regarding local  policies defining whether LDP-created or SR-created LSPs should be used etc.

b.      Discussion of using LSP Ping for LSPs that are produced by stitching an LDP segment with an SR one.

c.       Alternatively, it is possible to move this section to a separate dedicated draft

          5.         Technical: I think more information should be provided in Section 5 to explain operational aspects of SR-assisted LDP FR:

a.       In Section 5.1 I would expect the draft to explain that:

                                                               i.      Node D is selected as the RLFA using the same logic  that is defined for selecting RLFA in RFC 7490

                                                             ii.      The "bypass LSP" is set up by the SR CP automatically without any need for management intervention

                                                            iii.      I would like to understand why dynamically set up Targeted LDP sessions are an operational concern. Such sessions appear also when BGP-based auto-discovery for L2VPN is used, and, according to the analysis in RFC 7490, the scalability problems associated with these sessions look as negligible.

b.      In Section 5.2 I would expect the draft to explain that:

                                                               i.      The resulting solution is similar to using a bypass LSP to a manually selected RLFA that is set up by RSVP-TE (the difference is that a Targeted LDP session to such an RLFA would be still needed)

                                                             ii.      Set up of the  "traffic-engineered bypass LSP" by the SR CP is triggered by an appropriate management operation

                                                            iii.      What information should be provided by the Management Plane for computing the RLFA and the traffic-engineered  bypass LSP? Should it be similar to configuration parameters used with RSVP-TE?

                                                           iv.      Which kind of logic should be responsible for computing the RLFA and the path to be taken by the engineered bypass LSP: should it be similar to the CSPF used with RSVP-TE?

                                                             v.      How the traffic-engineered bypass LSP hat is set up by the SR CP would react to additional changes in the network topology (the behaviour of the bypass LSP that is set by RSVP-TE in these situations is well known).



Neither of the issues listed above should be considered as preventing adoption of the draft as a WG document IMO. Actually I think that resolving these issues in the context of a WG document would be more effective.



Hopefully these notes will be useful.



Regards,

Sasha



Office: +972-39266302

Cell:      +972-549266302

Email:   Alexander.Vainshtein@ecitele.com



From: Jonathan Hardwick [mailto:Jonathan.Hardwick@metaswitch.com]
Sent: Wednesday, May 20, 2015 12:46 PM
To: Alexander Vainshtein
Cc: bruno.decraene@orange.com; jgs@juniper.net; Alvaro Retana (aretana); Jon Hudson
Subject: Routing directorate QA review of draft-filsfils-spring-segment-routing-ldp-interop



Hi Sasha



Please would you be the routing directorate QA reviewer for draft-filsfils-spring-segment-routing-ldp-interop?

https://datatracker.ietf.org/doc/draft-filsfils-spring-segment-routing-ldp-interop/



This initial review has been prompted by the spring WG chairs in parallel with a call for WG adoption.  As such, this document qualifies for "initial QA review".  Please could you provide your initial comments in the next 3 weeks?  As per the QA process, we would also like you to stay with the document and review it again when it goes to WG last call.



The following web page contains a briefing on the QA process, and guidance for the QA reviewer.

https://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDirDocQa



Please copy your comments to the spring and rtgdir mailing lists.



Please let me know whether you can do it, or not.



Many thanks

Jon