Re: [mpls] [Last-Call] Rtgdir last call review of draft-ietf-mpls-lspping-norao-06

Dhruv Dhody <dhruv.ietf@gmail.com> Wed, 07 February 2024 03:41 UTC

Return-Path: <dhruv.ietf@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F318C14F6E4; Tue, 6 Feb 2024 19:41:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KQEK3Xw-bDea; Tue, 6 Feb 2024 19:41:44 -0800 (PST)
Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3E0D5C14F600; Tue, 6 Feb 2024 19:41:44 -0800 (PST)
Received: by mail-ua1-x931.google.com with SMTP id a1e0cc1a2514c-7ce603b9051so65327241.2; Tue, 06 Feb 2024 19:41:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707277303; x=1707882103; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=883kcjL1N2FTrFU5ASe5DBYViREV3YohThImDHwXMsA=; b=hZ6NI5x6hmlG/0VfBvJifT/m50Pm5uCUXjqlOZ2Q7v4z4H8n0e0LK5S4ku31Qnn/3R DjBAvmYNAegMAuJV6nQnkQFVITN8VwRj1y9WI1GdWrAdZpV8Ai37ngIgdqSaMeW3T3AQ GNK/Vvwjyy8yToL2kmAsw/Ud9K2s3F699adEOLWNzLCIn458Wxru8ETqeYvc6kyZWswS guHOkcx5f2hDNC5gZWje5SAflS0vj2448H9HhdI6otqZzOOmClLKvq/2erkxWWCKgWTG jojy9jgTcjCQOu0rPEoFYT8+tXZGOXxcmR49JT8vyzVQxenEQ6li2N64iiVusoCuVDPv 3LKg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707277303; x=1707882103; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=883kcjL1N2FTrFU5ASe5DBYViREV3YohThImDHwXMsA=; b=FUvsbt8UKjZM74vR55nitiIje2AhIqKhCS3tSdbSZBJCeJSF/mQdv2q2VwWE7VQaYD QV+MAsbH/gIhnHsNF1pXoRRYPU847HN43+XW+F89OWZjrpvBWkyHCPjk547SKDinUmOj Sh9soem8kV6ljXuAHzeE9C3wbRL9tA+XdqwNOloej1Us72FIbBcdmu4+WYIBnxmxWESE OsdUbZl8Up+7nR5zvWFsbf9BjCP5QKwppg+vf7IQjA6UrDZH7k747aD0iM7M2frR0AOo X0RmjjiVi3QPBvNxFJ5P9OY2N96DveW/9Wgmu7MCKIoTgviY8h8qfxAktzGGC/pHfUyk AoqQ==
X-Gm-Message-State: AOJu0YxfdZvWVfJK9kPB4sa2b/l0n3ECFtNX2a/Y4vcMxI2+cOYrmjg8 QW1oUS9giYlH7l3NwOXvZqOfhtuFiWu+ucsKZMZicmIQTNxcJEMhZIx+LRTaPB0uZF0C6jd6Xks HgDOJeKC48+/JpvBGjQdAtkpeBsY=
X-Google-Smtp-Source: AGHT+IFQ/+FDPhmRMIGo0Dq8t9B/+Hb/gvoAyIOTcnBJydlphCXi7Elu20b789/9Cp2j//Y3DiicYocvBLc8MNm/rnU=
X-Received: by 2002:a05:6102:4a6:b0:46d:20a4:2649 with SMTP id r6-20020a05610204a600b0046d20a42649mr1652383vsa.9.1707277301626; Tue, 06 Feb 2024 19:41:41 -0800 (PST)
MIME-Version: 1.0
References: <170712440103.40611.16663211097190972973@ietfa.amsl.com> <CA+RyBmWdCwaW1JvfGb8rFntWGpkbse+ZtiDP167kt+k_GL32vQ@mail.gmail.com>
In-Reply-To: <CA+RyBmWdCwaW1JvfGb8rFntWGpkbse+ZtiDP167kt+k_GL32vQ@mail.gmail.com>
From: Dhruv Dhody <dhruv.ietf@gmail.com>
Date: Wed, 07 Feb 2024 09:11:05 +0530
Message-ID: <CAB75xn5UAh0_b5LNjkZO+T_yeivgmAzjnrk3_X9Q0jSdPEco6Q@mail.gmail.com>
To: Greg Mirsky <gregimirsky@gmail.com>
Cc: Dhruv Dhody <dd@dhruvdhody.com>, rtg-dir@ietf.org, draft-ietf-mpls-lspping-norao.all@ietf.org, last-call@ietf.org, mpls@ietf.org
Content-Type: multipart/alternative; boundary="00000000000018bcf60610c279ef"
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/gVLvaRl8aM3LqicuPfzKyig35gE>
Subject: Re: [mpls] [Last-Call] Rtgdir last call review of draft-ietf-mpls-lspping-norao-06
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2024 03:41:48 -0000

HI Greg,

Thanks for taking my comments into consideration.

>
>> ## Major
>>
>> - It would be incorrect to put RFC 7056 (which is being made historic) in
>> the
>> "updates:" list at the top of the page. Note that, one needs to follow the
>> "status-change" document process to mark the RFC as historic which should
>> be
>> triggered by the AD. The job of this I-D is to articulate the reasons why
>> the
>> RFC7506 should be made historic. Update section 1 and section 3
>> accordingly.
>> Section 3 could list or refer to existing sections on why RFC 7506 should
>> be
>> historic.
>>
> GIM>> Thank you for pointing this out. Updated the header accordingly.
>

Dhruv: I think this text in (1) abstract - "It reclassifies RFC 7506 as
Historic..." and this text in (2) introduction "...and reclassifies RFC
7506 [RFC7506] as Historic." and section 3 (3) "This document reclassifies
RFC 7506 [RFC7506] as Historic." are incorrect.

It should stay instead that "this document explains why RFC 7560 has been
reclassified as Historic" in all places. I would also suggest to update
section 3 accordingly

This IESG statement has some useful information -
https://www.ietf.org/about/groups/iesg/statements/designating-rfcs-historic

There now exists a new type of document, "status-change" documents, to fill
> this gap. These documents are kept in the datatracker, are not Internet
> drafts, and are not published as RFCs, but they are archival documents that
> are linked to the RFCs whose status is changed


An example -

RFC that is marked as Historic - https://datatracker.ietf.org/doc/rfc3540/
via this status change -
https://datatracker.ietf.org/doc/status-change-ecn-signaling-with-nonces-to-historic/
which links to the explanation in draft-ietf-tsvwg-ecn-experimentation
<https://datatracker.ietf.org/doc/draft-ietf-tsvwg-ecn-experimentation/> /
https://datatracker.ietf.org/doc/rfc8311/

Hope this helps!




>
>> - RFC 8029 includes text outside of sections 2.1 and 2.2 that mentions
>> router
>> alert. For instance,
>> https://datatracker.ietf.org/doc/html/rfc8029#section-4.5
>> tells how to handle it with "MUST" when we now are asking implementation
>> to
>> ignore it - ````
>>    If the Reply Mode in the echo request is "Reply via an
>>    IPv4 UDP packet with Router Alert", then the IP header MUST contain
>>    the Router Alert IP Option of value 0x0 [RFC2113] for IPv4 or 69
>>    [RFC7506] for IPv6.  If the reply is sent over an LSP, the topmost
>>    label MUST in this case be the Router Alert label (1) (see
>>    [RFC3032]).
>>
>  GIM>> Thank you for catching another reference to the Reply mode 3.
> Appended the following text to Section 4:
> NEW TEXT
>    Resulting from the removal of the Reply mode 3 "Reply via an IPv4/
>    IPv6 UDP packet with Router Alert" (see Section 2.2), this
>    specification updates Section 4.5 of [RFC8029] by removing the
>    following text:
>
>    If the Reply Mode in the echo request is "Reply via an IPv4 UDP
>    packet with Router Alert", then the IP header MUST contain the Router
>    Alert IP Option of value 0x0 [RFC2113] for IPv4 or 69 [RFC7506] for
>    IPv6.  If the reply is sent over an LSP, the topmost label MUST in
>    this case be the Router Alert label (1) (see [RFC3032]).
>
>
Dhruv: Looks good!



> ````
>> - If you do update the text, note that there is an erratum
>> https://www.rfc-editor.org/errata/eid7639. Please do a check of all other
>> instances of "alert" as well in RFC 8029.
>>
> GIM>> That was my errata. What would be the right way to handle it?
>

Dhruv: Since you are removing the text with this update, I guess nothing!

I have my doubts about one more instance -

https://datatracker.ietf.org/doc/html/rfc8029#section-4.3

The Router Alert IP Option of value 0x0 [RFC2113] for IPv4 or value 69
> [RFC7506] for IPv6 MUST be set in the IP header.


Hope you did a check on other instances of "alert" in RFC 8029.


--

In one edit in Section 4, where you list the OLD text from RFC 8029, do not
add a reference to RFC 1122 in OLD text as this should be as listed in RFC
8029. It is good that you added reference in the NEW text!

Thanks!
Dhruv