Re: [mpls] Ben Campbell's No Objection on draft-ietf-mpls-mldp-node-protection-05: (with COMMENT)

IJsbrand Wijnands <ice@cisco.com> Wed, 16 September 2015 10:04 UTC

Return-Path: <ice@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22ADB1B3B36; Wed, 16 Sep 2015 03:04:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q9uNAwzlUkfw; Wed, 16 Sep 2015 03:04:23 -0700 (PDT)
Received: from aer-iport-2.cisco.com (aer-iport-2.cisco.com [173.38.203.52]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7AE1D1B3B1C; Wed, 16 Sep 2015 03:04:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2935; q=dns/txt; s=iport; t=1442397855; x=1443607455; h=mime-version:subject:from:in-reply-to:date:cc: content-transfer-encoding:message-id:references:to; bh=BqE2W70Y+fRUhvN2v6rzYAywsewlVVGPYqQdyuVKHqQ=; b=Z7C1gJT4OIQ0+sHwgixt0r/Nohj/P250MXpzjJAVoIDOE5DeQy1g7XNJ 9Hfv2czyyC5MCqAdtj/qtVX/6fiBPk8r6iozUCxzDo5xkRNRlLrZW7SX4 MiBuBPma6V6P7q1y9xr6OKx/Akeb+hmYZJaOFtCUqtofv90KRejXvTsN5 Q=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0A7BQAzPvlV/xbLJq1drXoBAQEBAQEFAYEKkxCHcgKBfRIBAQEBAQEBgQqEJAEBAwEjVhALGgImAgJXBog5CLUUlEwBAQEBAQEBAQEBAQEBAQEBAQEBGYEihQqCVoJuhFozB4JpL4EUAQSSNoMojQOBTZVXg2wnATuCQ4FAPIpdAQEB
X-IronPort-AV: E=Sophos;i="5.17,538,1437436800"; d="scan'208";a="611637814"
Received: from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com) ([173.38.203.22]) by aer-iport-2.cisco.com with ESMTP; 16 Sep 2015 10:04:12 +0000
Received: from ams-iwijnand-8816.cisco.com (ams-iwijnand-8816.cisco.com [10.60.202.87]) by aer-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id t8GA4AJj006600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Sep 2015 10:04:11 GMT
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
From: IJsbrand Wijnands <ice@cisco.com>
In-Reply-To: <20150914220331.5981.89192.idtracker@ietfa.amsl.com>
Date: Wed, 16 Sep 2015 12:04:10 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <7DD892A2-37EF-435E-A8F5-9167436DA808@cisco.com>
References: <20150914220331.5981.89192.idtracker@ietfa.amsl.com>
To: Ben Campbell <ben@nostrum.com>
X-Mailer: Apple Mail (2.1993)
Archived-At: <http://mailarchive.ietf.org/arch/msg/mpls/gkr6v7UDMeA6YM8HU5A20rCdxKQ>
Cc: mpls@ietf.org, mpls-chairs@ietf.org, The IESG <iesg@ietf.org>, draft-ietf-mpls-mldp-node-protection.shepherd@ietf.org, draft-ietf-mpls-mldp-node-protection.ad@ietf.org, draft-ietf-mpls-mldp-node-protection@ietf.org
Subject: Re: [mpls] Ben Campbell's No Objection on draft-ietf-mpls-mldp-node-protection-05: (with COMMENT)
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Sep 2015 10:04:25 -0000

Hi Ben,

> -- 2.3, last paragraph: "Along with the PLR MP Status a MP FEC TLV MUST
> be included"
> Does that mean that both MUST be included, or if the first is included,
> the second MUST also be?

Both MUST be included.

> 
> -- 4.1.3, last paragraph:
> Just “recommended”? Is link flapping a minor enough that it doesn't
> justify a MUST?

Well, its really an implementation choice to save resources being using in deleting and re-creating the tLDP session. If the implementation has means to deal with this or has other mechanism to solve this problem, that is fine too. 

> 
> -- 6:
> It would be nice to show your work a bit more in the security
> considerations. This draft adds new protocol elements and procedures. If
> the working group has determined that those new bits add no new security
> concerns, it would be good to say why.

Yep, that is done.

> 
> Editorial and Nits:
> 
> A (probably first) paragraph in the intro that defined exactly what the
> draft means by "protection" would be helpful. (The existing first
> paragraph talks about how you provide protection, but one must infer what
> this protects _against_.
> 
> -- 1, 2nd paragraph: Lots of the terms here could use (informative)
> citations.
> 
> -- 2.1, first paragraph: Consider s/"we are describing"/"we describe"
> -- 2.1, last paragraph, 2nd to last sentence, "See section 5":
> unbalanced parentheses.
> 
> -- 2.2, 1st paragraph:
> s/"we are describing"/"we describe"
> 
> -- 2.2, last paragraph: 
> "protection mechanism don’t" -- Noun/verb disagreement (singular/plural)
> s/ help restoring/help restore
> 
> -- 2.3, 2nd to last paragraph:
> I suggest the “A node N” phrase be moved to the first mention of N in
> this paragraph.
> 
> "Removing a PLR address is likely due to a link failure, see the
> procedures as documented in Section 4.1. ":
> Comma splice. Consider a semicolon.

Ok, I think I fixed the above.

> 
> "MUST encode PLR Status Value Element": Missing article.

What do you mean here?

> 
> -- 3, 2nd paragraph:
> "Ln that was assigned to N via the normal mLDP procedures, and Label Lpx
> that was assigned for PLR (LSR1) for the purpose of node protecting MP
> LSP via node N."
> I can’t parse this sentence. (Incomplete sentence?)

Ok, updated it, hope its better now.

> 
> -- 3, 3rd paragraph: "For this reason, the FEC Label Mapping (FEC <R,X> :
> Lpx) sent by the MPT over the tLDP session to the PLR MUST include a
> Status TLV with
>   MP Status including a new LDP MP status Value Element called the
> "Protected Node Status Value Element"."
> Convoluted sentence. Consider breaking into multiple, simpler sentences.
> 
> -- 5, 1st sentence:
> s/we are organizing/we organize/
> 
> 

Ok,

Thx!

Ice.