Re: [mpls] working group adaption poll (wgap) for draft-hegde-mpls-spring-epe-oam

[Shraddha Hegde <[e-mail]>]

Hi Dhruv,

Thanks for the review and comments. Pls see inline


Juniper Business Use Only

-----Original Message-----
From: Dhruv Dhody <[e-mail]> 
Sent: Tuesday, May 12, 2020 1:31 PM
To: Loa Andersson <[e-mail]>
Cc: [e-mail]; [e-mail]; [e-mail]
Subject: Re: [mpls] working group adaption poll (wgap) for draft-hegde-mpls-spring-epe-oam

[External Email. Be cautious of content]


Hi Loa, WG,

I support the adoption of this work, it provides a useful functionality that has been described well enough to be adopted by the WG.

I do have a few suggestions and nits that the authors could take up later -

--

- I suggest adding a few more lines to build some context in your Introduction section, the current text works for someone in the know-how of MPLS-OAM/SR but fails to provide context for a general reader.
<shraddha> Sure. -07 will address this

- I suggest to expand the text in section 4, to clearly state that this I-D is further specifying 3 more new sub-TLVs and also which TLVs would carry these sub-TLVs etc.
<Shraddha> yes. -07 will address this

- Some of the references mentioned as Informative are more suitable as Normative, namely - [I-D.ietf-spring-segment-routing-central-epe], RFC 2119, RFC 8174, RFC 8690 (?)
<shraddha> I have moved RFC 2119, RFC 8174, RFC 8690 To normative but I-D.ietf-spring-segment-routing-central-epe Doesn't seem to be normative. The IDR protocol extension for BGP-EPE is already a normative document.

Nits
- Abstract, you expand Segment Identifiers (SID) NOT on first use but much later.
- Introduction, s/mpls/MPLS (multiple places)
- Section 2, s/e-BGP/EBGP (as per RFC Editor abbreviation preference)
- Section 4.1, Change ipv4/ipv6 to IPv4/IPv6 (multiple places)
- Section 4.1, Expand FFS!
- Section 5, s/SHOuLD/SHOULD
- Section 5, fix the over-running lines (exceeding 80 chars)

--
<shraddha> Thanks for catching these. Will address all of them in -07
Regards,
Dhruv

On Thu, Apr 30, 2020 at 8:27 AM Loa Andersson <[e-mail]> wrote:
>
> Working Group,
>
> This is to start a two week poll on adopting 
> draft-hegde-mpls-spring-epe-oam as a MPLS working group document.
>
> Please send your comments (support/not support) to the mpls working 
> group mailing list ([e-mail]). Please give a technical motivation 
> for your support/not support, especially if you think that the 
> document should not be adopted as a working group document.
>
> There is one IPR disclosure against this document.
>
> The authors have stated on the MPLS wg mailing list that they are 
> unaware of any IPRs that relates to this document.
>
> The working group adoption poll ends May 15, 2020.
>
> /Loa
> --
>
> My mail server it under a DOS attack, we are working to fix it but it 
> may take some time.
>
>
> Loa Andersson                        email: [e-mail]
> Senior MPLS Expert
> Bronze Dragon Consulting             phone: [phone]
>
> _______________________________________________
> mpls mailing list
> [e-mail]
> https://urldefense.com/v3/__https://www.ietf.org/mailman/listinfo/mpls
> __;!!NEt6yMaO-gk!QuF1vXKGokb2IcgR-VF6pRxK2p1Cd9bR5yomBlNiRpKzR75-DFco5
> 20tuchQkvLp$