Re: [mpls] Rtgdir early review of draft-ietf-mpls-sr-epe-oam-08

Loa Andersson <loa@pi.nu> Tue, 22 August 2023 10:17 UTC

Return-Path: <loa@pi.nu>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0BE10C14F5E0; Tue, 22 Aug 2023 03:17:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.998
X-Spam-Level:
X-Spam-Status: No, score=-6.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.091, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e8bDaG4U111h; Tue, 22 Aug 2023 03:17:28 -0700 (PDT)
Received: from pipi.pi.nu (pipi.pi.nu [83.168.239.141]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 95B3AC14F736; Tue, 22 Aug 2023 03:17:27 -0700 (PDT)
Received: from [192.168.1.241] (c-72eb70d5.1063529-0-69706f6e6c79.bbcust.telenor.se [213.112.235.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: loa@pi.nu) by pipi.pi.nu (Postfix) with ESMTPSA id 5F96735CF04; Tue, 22 Aug 2023 12:17:24 +0200 (CEST)
Message-ID: <19d08051-47fb-7feb-7277-24ce9d824dd6@pi.nu>
Date: Tue, 22 Aug 2023 12:16:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0
Content-Language: en-CA
To: "Matthew Bocci (Nokia)" <matthew.bocci@nokia.com>, Shraddha Hegde <shraddha@juniper.net>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
Cc: "draft-ietf-mpls-sr-epe-oam.all@ietf.org" <draft-ietf-mpls-sr-epe-oam.all@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
References: <169150312632.28573.16831391846278800329@ietfa.amsl.com> <CO1PR05MB83142FB8A461DAE74915841BD517A@CO1PR05MB8314.namprd05.prod.outlook.com> <DU0PR07MB9218DB062DA4215D65C95611EB17A@DU0PR07MB9218.eurprd07.prod.outlook.com>
From: Loa Andersson <loa@pi.nu>
In-Reply-To: <DU0PR07MB9218DB062DA4215D65C95611EB17A@DU0PR07MB9218.eurprd07.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/vDoDxxbnCyJfF7Q0gq6_2VUfhB4>
Subject: Re: [mpls] Rtgdir early review of draft-ietf-mpls-sr-epe-oam-08
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Aug 2023 10:17:33 -0000

Shraddha,

I have not seen a response on this, I might have missed. If you are OK 
with MAtthew's proposal can you update and will start first the IPR and 
when that is done the WGLC.

/Loa

On 2023-08-14 15:18, Matthew Bocci (Nokia) wrote:
> Hi Shraddha
> 
> Thanks for addressing most of my comments in the revised draft. I don’t see a response to my opening comment below:
> 
> “However, it does rely on the head end of the SR Policy / SR-TE LSP knowing the types of the SIDs along the path.”
> 
> This really relates to the following text in the draft which is buried in the “Theory of Operation” section. The ability of the head end to determine the SID type and so construct the FEC stack TLV is fundamental to whether this solution is feasible.
> 
> [I-D.ietf-idr-segment-routing-te-policy<https://datatracker.ietf.org/doc/html/draft-ietf-idr-segment-routing-te-policy-23>] and [RFC8664<https://www.rfc-editor.org/info/rfc8664>] do not define how to carry the details of the SID that can be used to construct the FEC. Such extensions are out of scope for this document. The node initiating the data plane monitoring may acquire the details of EPE-SIDs through BGP-LS advertisements as described in [RFC9086<https://www.rfc-editor.org/info/rfc9086>]. There may be other possible mechanisms to learn the definition of the SID from controller. Details of such mechanisms are out of scope for this document.
> 
> I would propose to address this by adding a sentence up front in the introduction that states something like “This solution requires that the node constructing the target FEC stack is able to determine the type of the SIDs along the path of the LSP.”, or something similar, to help scope the applicability of the draft.
> 
> Best regards
> 
> Matthew
> 
> 
> 
> From: Shraddha Hegde <shraddha@juniper.net>
> Date: Monday, 14 August 2023 at 11:17
> To: Matthew Bocci (Nokia) <matthew.bocci@nokia.com>, rtg-dir@ietf.org <rtg-dir@ietf.org>
> Cc: draft-ietf-mpls-sr-epe-oam.all@ietf.org <draft-ietf-mpls-sr-epe-oam.all@ietf.org>, mpls@ietf.org <mpls@ietf.org>
> Subject: RE: Rtgdir early review of draft-ietf-mpls-sr-epe-oam-08
> [You don't often get email from shraddha@juniper.net. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
> 
> 
> 
> Hi Matthew,
> 
> Thank you for careful review and comments.
> Pls see inline for replies..
> 
> I have posted -09 version with updates.
> Let me know any further comments.
> 
> Rgds
> Shraddha
> 
> 
> Juniper Business Use Only
> -----Original Message-----
> From: Matthew Bocci via Datatracker <noreply@ietf.org>
> Sent: Tuesday, August 8, 2023 7:29 PM
> To: rtg-dir@ietf.org
> Cc: draft-ietf-mpls-sr-epe-oam.all@ietf.org; mpls@ietf.org
> Subject: Rtgdir early review of draft-ietf-mpls-sr-epe-oam-08
> 
> [External Email. Be cautious of content]
> 
> 
> Reviewer: Matthew Bocci
> Review result: Has Nits
> 
> RtgDir Early review: draft-ietf-mpls-sr-epe-oam-08.txt
> 
> Hello
> 
> I have been selected to do a routing directorate “early” review of this draft. https://urldefense.com/v3/__https://datatracker.ietf.org/doc/draft-foo-name/__;!!NEt6yMaO-gk!DHrhtn6R3nI56afrsFP8kYO_p0FvEFYRLjw5YylcakWYc2q5QCytHRyn7o9cVE0zOhb0wtzKi3uIZ-rn$<https://urldefense.com/v3/__https:/datatracker.ietf.org/doc/draft-foo-name/__;!!NEt6yMaO-gk!DHrhtn6R3nI56afrsFP8kYO_p0FvEFYRLjw5YylcakWYc2q5QCytHRyn7o9cVE0zOhb0wtzKi3uIZ-rn$>
> 
> The routing directorate will, on request from the working group chair, perform an “early” review of a draft before it is submitted for publication to the IESG. The early review can be performed at any time during the draft’s lifetime as a working group document. The purpose of the early review depends on the stage that the document has reached.
> 
> As this document is in working group last call, my focus for the review was to determine whether the document is ready to be published. Please consider my comments along with the other working group last call comments.
> 
> For more information about the Routing Directorate, please see https://urldefense.com/v3/__https://wiki.ietf.org/en/group/rtg/RtgDir__;!!NEt6yMaO-gk!DHrhtn6R3nI56afrsFP8kYO_p0FvEFYRLjw5YylcakWYc2q5QCytHRyn7o9cVE0zOhb0wtzKix3GFrlE$<https://urldefense.com/v3/__https:/wiki.ietf.org/en/group/rtg/RtgDir__;!!NEt6yMaO-gk!DHrhtn6R3nI56afrsFP8kYO_p0FvEFYRLjw5YylcakWYc2q5QCytHRyn7o9cVE0zOhb0wtzKix3GFrlE$>
> 
> Document: draft-ietf-mpls-sr-epe-oam-08.txt
> Reviewer: Matthew Bocci
> Review Date: 8th August 2023
> Intended Status: Standards Track
> 
> Summary:
> 
> I have some minor concerns about this document that I think should be resolved before it is submitted to the IESG.
> 
> Comments:
> 
> The draft is generally very readable - thanks! There are one or two paragraphs, particularly in the introduction where the definite article (the/a, etc) is missing or not used correctly. I have tried to capture some examples in my list of 'nits' below.
> 
> In general, I don't have an issue with the mechanism described in the draft

-- 
Loa Andersson                        email: loa@pi.nu
Senior MPLS Expert                          loa.pi.nu@gmail.com
Bronze Dragon Consulting             phone: +46 739 81 21 64