Re: [mpls] Working Group Last Call on draft-ietf-mpls-msd-yang

Tarek Saad <tsaad.net@gmail.com> Tue, 09 April 2024 14:17 UTC

Return-Path: <tsaad.net@gmail.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5DF0BC14F616; Tue, 9 Apr 2024 07:17:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.094
X-Spam-Level:
X-Spam-Status: No, score=-7.094 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jErGKxx_9hU2; Tue, 9 Apr 2024 07:17:36 -0700 (PDT)
Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C8275C14F60D; Tue, 9 Apr 2024 07:17:31 -0700 (PDT)
Received: by mail-qt1-x833.google.com with SMTP id d75a77b69052e-434c3d21450so5889511cf.0; Tue, 09 Apr 2024 07:17:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712672250; x=1713277050; darn=ietf.org; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=pP0Bpm7TGa9gHYdal8cMMNdpz5HHCY5Zc6vpet6SFtc=; b=EsLKs+A/x8DPN4wq71coSHz0d5YRnN1/KQP3Fbx7l9OkNuemh1rUkj1kWFbz+FLKC+ WJZwhTu2mCtjElknUKlR4zIzlWaCywGKGt1QmkFBTINvRmvbUA4RZEwf+bISu5+FNsX+ DohZSQWmPJQ/fphPN+7wt6Na0LDXTwyEe9s0tmmUerLQuMmj8DhFzjFTqYeM4fxdTgka LPAH9ploj1fymWfY0cky1nwSkkM05/+I8Xr81/OGznOhVW4XMGE+2mCbHMNkbZlhU8M2 41NWRuCzEkri8OXdFgpXknvmHOPOAeZCwMny2mQr+8LGytEVBJKQKo3FJtnANjo4BbA0 cfTg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712672250; x=1713277050; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pP0Bpm7TGa9gHYdal8cMMNdpz5HHCY5Zc6vpet6SFtc=; b=Qs4pQb0ynqvf1E+9+5ruWab5ksrENG6OJoaRimlj0O6z0FpBuB6NkYFCJnl6bnyGdO AfgCmLx/y5TgfeggjDpFrz6JYbU5Grvm7DZO6QTL0Gbj1No1HaA5uZGS6vPGZ34z03IH zsDBOlfrtpBOxa2XHxw2xWj8qdiqux3mdKaQeispQ90+cAuyoXkzU7QCker9X7b7QKes anX6Yag197AFitXSfvWP5ThoYwb0awz+eA5VWdLC3GxEfp5DTjhmR4MhfjlvMoR0iDk3 4rE//U0F7yOmMr1hcIi0nxZCSXWWq62xuRxTiSExrX4T++LmDhnHvfn/fSJPypQpdzjd OfFg==
X-Forwarded-Encrypted: i=1; AJvYcCXwK/xaYJv2HTSjWQPHJ+7KRBhl79ignyFU9hr7TAhjcV8ldluPKVh81i68k2HWBhRqop9PArv7bcQQgvBJA3TH6hFClEsDOyNJN7A5Lo1xPx4LI7b36F3Kz8uP2sVvLjytYyk96ieYUWdnw4YqtVHufxigO1DU
X-Gm-Message-State: AOJu0YzMgjcjqgS2EreLpyU9WQpeJcrDy1+EuHw6AbLvyxoVBnmXPXZW 0Qff3z8OIoGOIoC/PB5xRbv/YOGtq8Y+mACLQyBAKb+EfhaKzfF0
X-Google-Smtp-Source: AGHT+IGYd1bz8AROdX8tK+FuZ7yGRulllR9QpUC2cdklBg/UQlIFRCZc738cW32082/zxKAKo15idQ==
X-Received: by 2002:a05:622a:180a:b0:434:a4fd:29e2 with SMTP id t10-20020a05622a180a00b00434a4fd29e2mr6466354qtc.31.1712672250432; Tue, 09 Apr 2024 07:17:30 -0700 (PDT)
Received: from DS0PR19MB6501.namprd19.prod.outlook.com ([2603:1036:5:f::5]) by smtp.gmail.com with ESMTPSA id ff9-20020a05622a4d8900b00432ff1e29easm4637654qtb.97.2024.04.09.07.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 07:17:30 -0700 (PDT)
From: Tarek Saad <tsaad.net@gmail.com>
To: Yingzhen Qu <yingzhen.ietf@gmail.com>, Mahesh Jethanandani <mjethanandani@gmail.com>, Reshad Rehman <reshad@yahoo.com>
CC: "<liu.yao71@zte.com.cn>" <liu.yao71@zte.com.cn>, Acee Lindem <acee.ietf@gmail.com>, "draft-ietf-mpls-msd-yang@ietf.org" <draft-ietf-mpls-msd-yang@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>, MPLS Working Chairs <mpls-chairs@ietf.org>
Thread-Topic: [mpls] Working Group Last Call on draft-ietf-mpls-msd-yang
Thread-Index: AQHabwalGAv3nNAzcU68QJ8lBLNfa7EqW1OAgBgKYgCABxJ5AIAAIvCAgBUfhnqAAIYbgIAA8h1F
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Tue, 09 Apr 2024 14:17:28 +0000
Message-ID: <DS0PR19MB6501CD6E4A307BF7FDC7D49FFC072@DS0PR19MB6501.namprd19.prod.outlook.com>
References: <DS0PR19MB6501FE43E342ED2BCB8BCEEDFC222@DS0PR19MB6501.namprd19.prod.outlook.com> <202403061602534066454@zte.com.cn> <56428E20-6D78-47DC-9CB9-C767289DFF9C@gmail.com> <434997813.1033476.1711422612805@mail.yahoo.com> <99688001-65BE-4A2C-8B4A-7829F74C7DE7@gmail.com> <DS0PR19MB6501D3CD21D47B157A21FBC0FC002@DS0PR19MB6501.namprd19.prod.outlook.com> <CABY-gONEcV7wr5pV=x6gs-HLs6nYzk+5-0_zFW+sU_gpeKFwLw@mail.gmail.com>
In-Reply-To: <CABY-gONEcV7wr5pV=x6gs-HLs6nYzk+5-0_zFW+sU_gpeKFwLw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-CA
X-MS-Has-Attach:
X-MS-Exchange-Organization-SCL: -1
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: multipart/alternative; boundary="_000_DS0PR19MB6501CD6E4A307BF7FDC7D49FFC072DS0PR19MB6501namp_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/vyIX3_uvhw6UkhrOhy1S6cAmIn8>
Subject: Re: [mpls] Working Group Last Call on draft-ietf-mpls-msd-yang
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Apr 2024 14:17:41 -0000

Hi Reshad and Mahesh,

>> I'm not sure we want to change the file name. One possible solution is to remove the identities about SRv6 MSD in the iana-msd-types.yang, and add them in the SRv6 YANG draft.
[TS]: Given the model is MPLS specific, would this address your concerns?

Regards,
Tarek


From: Yingzhen Qu <yingzhen.ietf@gmail.com>
Date: Monday, April 8, 2024 at 7:49 PM
To: Tarek Saad <tsaad.net@gmail.com>
Cc: Mahesh Jethanandani <mjethanandani@gmail.com>, Reshad Rehman <reshad@yahoo.com>, <liu.yao71@zte.com.cn>, Acee Lindem <acee.ietf@gmail.com>, draft-ietf-mpls-msd-yang@ietf.org <draft-ietf-mpls-msd-yang@ietf.org>, mpls@ietf.org <mpls@ietf.org>, MPLS Working Chairs <mpls-chairs@ietf.org>
Subject: Re: [mpls] Working Group Last Call on draft-ietf-mpls-msd-yang
Hi,

Sorry for the late reply due to travels.

Thanks Tarek for the pointer to Ketan's email. The draft only included MPLS MSD at the beginning, then Ketan suggested we follow the IANA MSD types registry, so we added the iana-msd-types.yang module, which also includes SRv6 MSD types. The ietf-mpls-msd.yang augments the base MPLS model defined in RFC 8960, and it can only query MPLS MSD types. Note: there are msd-base-mpls and mpls-base-srh defined in the iana module to separate MPLS and SRv6 MSD types.

I'm not sure we want to change the file name. One possible solution is to remove the identities about SRv6 MSD in the iana-msd-types.yang, and add them in the SRv6 YANG draft.

Suggestions and comments are welcome.

Thanks,
Yingzhen

On Mon, Apr 8, 2024 at 8:52 AM Tarek Saad <tsaad.net@gmail.com<mailto:tsaad.net@gmail.com>> wrote:
Hi Mahesh,

SPRING WG was in the loop of updates to this draft. There was a request for the IANA MSD Types registry to be mirrored into YANG which I believe is the current state
https://mailarchive.ietf.org/arch/msg/mpls/rdjYEGVEhx3T9xoVWMu-DkQdBjM/

Regards,
Tarek

From: Mahesh Jethanandani <mjethanandani@gmail.com<mailto:mjethanandani@gmail.com>>
Date: Tuesday, March 26, 2024 at 1:15 AM
To: Reshad Rehman <reshad@yahoo.com<mailto:reshad@yahoo.com>>
Cc: <liu.yao71@zte.com.cn<mailto:liu.yao71@zte.com.cn>>, Acee Lindem <acee.ietf@gmail.com<mailto:acee.ietf@gmail.com>>, Tarek Saad <tsaad.net@gmail.com<mailto:tsaad.net@gmail.com>>, draft-ietf-mpls-msd-yang@ietf.org<mailto:draft-ietf-mpls-msd-yang@ietf.org> <draft-ietf-mpls-msd-yang@ietf.org<mailto:draft-ietf-mpls-msd-yang@ietf.org>>, mpls@ietf.org<mailto:mpls@ietf.org> <mpls@ietf.org<mailto:mpls@ietf.org>>, MPLS Working Chairs <mpls-chairs@ietf.org<mailto:mpls-chairs@ietf.org>>
Subject: Re: [mpls] Working Group Last Call on draft-ietf-mpls-msd-yang
+1 to Reshad’s comment.

mpls-chairs, if the definitions are beyond MPLS, e.g. SRv6, has this been socialized in spring WG?

On Mar 26, 2024, at 4:10 PM, Reshad Rahman <reshad@yahoo.com<mailto:reshad@yahoo.com>> wrote:

Hi Acee, all,

From a quick look at the YANG, I see non MPLS-specific identities such as msd-srh-max-end-pop. If those stay, ietf-msd.yang seems to be a more appropriate name to me.

Regards,
Reshad.

On Thursday, March 21, 2024, 11:10:29 AM EDT, Acee Lindem <acee.ietf@gmail.com<mailto:acee.ietf@gmail.com>> wrote:


Hi Yao,

I agree we should update this to reflect the extended applicability of MSD to different types.

I'm wonder if we should also change the module name to simply ietf-msd.yang. The argument for
changing the name is that MSD is being extended beyond MPLS. The argument against this is that this
module only augments the ietf-mpls.yang module.

Opinions? I've also copied Mahesh (Ops AD focusing on YANG) and Reshad (YANG doctor and reviewer).

Thanks,
Acee

> On Mar 6, 2024, at 3:02 AM, liu.yao71@zte.com.cn<mailto:liu.yao71@zte.com.cn> wrote:
>
> Hi,
>
> I support the progression of the draft.
> And I have one comment after reading the lasest version. From my reading of section 4, it defines YANG module not only for MPLS MSDs, but also for SRv6 MSDs (i.e, msd-base-srh). But the title and abstract of the draft claims that the YANG module is defined for MPLS MSDs, without mentioning SRv6. It confused me a little bit.
>
> Regards,
> Yao
> Original
> From: TarekSaad <tsaad.net@gmail.com<mailto:tsaad.net@gmail.com>>
> To: mpls@ietf.org<mailto:mpls@ietf.org> <mpls@ietf.org<mailto:mpls@ietf.org>>;
> Cc: MPLS Working Chairs <mpls-chairs@ietf.org<mailto:mpls-chairs@ietf.org>>;draft-ietf-mpls-egress-tlv-for-nil-fec@ietf.org<mailto:draft-ietf-mpls-egress-tlv-for-nil-fec@ietf.org> <draft-ietf-mpls-egress-tlv-for-nil-fec@ietf.org<mailto:draft-ietf-mpls-egress-tlv-for-nil-fec@ietf.org>>;
> Date: 2024年03月05日 22:14
> Subject: [mpls] Working Group Last Call on draft-ietf-mpls-msd-yang
> _______________________________________________
> mpls mailing list
> mpls@ietf.org<mailto:mpls@ietf.org>
> https://www.ietf.org/mailman/listinfo/mpls
>
> Dear WG,
>
> This email starts a two-week working group last call for draft-ietf-mpls-msd-yang [1].
>
> Please indicate your support or concern for this draft. If you are opposed to the progression of the draft to RFC, please articulate your concern. If you support it, please indicate that you have read the latest version, and it is ready for publication in your opinion. As always, review comments and nits are most welcome.
>
> Please send your comments to the mpls wg mailing list (mpls@ietf.org<mailto:mpls@ietf.org>).
> If necessary, comments may be sent unidirectional to the WG chairs.
>
> This poll runs until the 19th of March 2024.
>
> Thank you,
> Tarek (for the MPLS WG co-chairs)
>
> [1]  draft-ietf-mpls-msd-yang
>



Mahesh Jethanandani
mjethanandani@gmail.com<mailto:mjethanandani@gmail.com>