Re: [mpls] MPLS-RT review of draft-tsaad-mpls-p2mp-loose-path-reopt

Sriganesh Kini <sriganesh.kini@ericsson.com> Mon, 19 May 2014 22:10 UTC

From: Sriganesh Kini <sriganesh.kini@ericsson.com>
To: Loa Andersson <loa@pi.nu>, Curtis Villamizar <curtis@occnc.com>, Xuxiaohu <xuxiaohu@huawei.com>, "thomas.morin@orange.com" <thomas.morin@orange.com>
Thread-Topic: MPLS-RT review of draft-tsaad-mpls-p2mp-loose-path-reopt
Thread-Index: AQHPXimYbzXLKJja6Eq7kSygg5PJ0psd6QCAgCqGuAA=
Date: Mon, 19 May 2014 22:10:40 +0000
Message-ID: <CF9FCDD5.26881%sriganesh.kini@ericsson.com>
In-Reply-To: <5356727F.8080908@pi.nu>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.5.130515
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <3FE3BD643A9C1B4C904BB38195725D85@ericsson.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/mpls/xFve7on_8YgeECzmFMsOGUfm38k
Cc: "draft-tsaad-mpls-p2mp-loose-path-reopt@tools.ietf.org" <draft-tsaad-mpls-p2mp-loose-path-reopt@tools.ietf.org>, "mpls@ietf.org" <mpls@ietf.org>, "mpls-chairs@tools.ietf.org" <mpls-chairs@tools.ietf.org>
Subject: Re: [mpls] MPLS-RT review of draft-tsaad-mpls-p2mp-loose-path-reopt
Precedence: list

Hello,

Some review comments are below. Overall, the draft is addressing a
useful-problem but is not coherent. I think the problem statement has to
be clearly defined and terminology fixed before the draft proceeds to WG
acceptance call.

1. Abstract should state that the specific limitation being addressed is
one of tree-optimization as opposed to the individual sub-LSP
re-optimization that is already defined.

2. The "egress border" node used in Pg-3 bullet-1 should be defined. I am
assuming you intended to say mid-point LSR of RFC 4736 ?

3. Pg-3 last para. RFC 4736 states that reoptimization is for a preferable
path i.e. shorter path. This should be re-defined for a P2MP LSP so that
the notion of preferable is clear. This is critical to define the problem
statement.

4. Pg-4 bullet-1.  What is the 'query' being referred to here? Is it path
re-evaluation request ?

5. Pg-4 sec 1. A figure to illustrate the problems would be very useful.

6. Pg-5 section-3 last para. "...re-evaluating loosely expanded paths of
all S2L sub-LSP(s)...". Shouldn't the PathErr be sent even if a single S2L
sub-LSP can be re-optimized. Why should 'all' be re-evaluated ?

7. Do the procedures in this draft guarantee 'global optimization' ?

Thanks
Sri

On 4/22/14 6:45 AM, "Loa Andersson" <loa@pi.nu> wrote:

>All,
>
>I was to conservative sending this out, authors, co-chairs and
>wg secretary should have been copied.
>
>/Loa
>
>On 2014-04-22 14:51, Loa Andersson wrote:
>> Curtis, Xiaohu, Sri, Thomas,
>>
>> You have been selected as an MPLS Review team reviewers for
>> draft-tsaad-mpls-p2mp-loose-path-reopt.
>>
>> Note to authors: You have been CC¹d on this email so that you can know
>> that this review is going on. However, please do not review your own
>> document.
>>
>> Reviews should comment on whether the document is coherent, is it useful
>> (ie, is it likely to be actually useful in operational networks), and is
>> the document technically sound?  We are interested in knowing whether
>> the document is ready to be considered for WG adoption (ie, it doesn¹t
>> have to be perfect at this point, but should be a good start).
>>
>> Reviews should be sent to the document authors, WG co-chairs and
>> secretary, and CC¹d to the MPLS WG email list. If necessary, comments
>> may be sent privately to only the WG chairs.
>>
>> Are you able to review this draft by May 7, 2014?
>>
>> Thanks, Loa
>> (as MPLS WG chair)
>>
>>
>
>-- 
>
>
>Loa Andersson                        email: loa@mail01.huawei.com
>Senior MPLS Expert                          loa@pi.nu
>Huawei Technologies (consultant)     phone: +46 739 81 21 64

Re: [mpls] MPLS-RT review of draft-tsaad-mpls-p2m… Sriganesh Kini
Re: [mpls] MPLS-RT review of draft-tsaad-mpls-p2m… Tarek Saad (tsaad)