[mpls] AD review for https://datatracker.ietf.org/doc/draft-ietf-mpls-ri-rsvp-frr/

James Guichard <james.n.guichard@futurewei.com> Wed, 27 March 2024 17:39 UTC

Return-Path: <james.n.guichard@futurewei.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EAEF1C151099; Wed, 27 Mar 2024 10:39:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.107
X-Spam-Level:
X-Spam-Status: No, score=-2.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=futurewei.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wdSdOc7V5lE8; Wed, 27 Mar 2024 10:39:01 -0700 (PDT)
Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2136.outbound.protection.outlook.com [40.107.100.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4B5A6C14F5FE; Wed, 27 Mar 2024 10:38:58 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C47KiaYFsB972y1H4vu7VR3IuY11wBxeUU1UTlisntpLfYU9s2NuTGPqRKdMO16f9BCdnNnj0tCMJ2/F4YidxNdVUV+oDCWk9UrTmWkTFb5r0/R33PDjnPdxN1PbZahyZrUhjKGZ8eqPV2NV2mfgxZcz3GAxtsLJkPiCGFTXvJlXKQ+KJ2lI8ACaH9jrSBTnHJrgeoVx10v5vsGRV+0PqzoazcYQ1jszoY1e8exhSf+Hvx8E7rTkyHk1FMxFFyhnQqJfVwiJMBhjXwWrwo7p4G5ksESK6LhdrY7bH9kgA7bm7rblvFDYjVCgBujKhupZ6guUcdoWM+Hce3v8OekmKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pYqic6mb3tU3/oKyenuJQqOGrHMLbPTE4Esk9eVk6xw=; b=kqKfSCujUFSJ3w8iqKPIW0QwWMLCg/xT89P6t16oYtA0EYiZs+0R2COzsEyiEDCYG1yxSljydX+HnDXAvAwxNFj9hWQ0ZqzEdahr44/kdGtCHZ63ObTgvJ/LtUuTSDyfSkuXJs629/3Afv6ns2xP4NNg7qY3R9o/1FctdQL0DAhLu64Tvcw9cdIqYooU8KdvkewVa6cy0FF0dr5da7XNOZdZ0Tl6NURr1li74Qz3weIy88+1utv9hoy0f4h40qU/xzhudjcKQ/JvySycua4rmkdbQkZkcbRQARWi3wWROmhmed0S+YLViFxX9AqOULy8WjX5IoCmnb3sw8Ac/QGiNg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=futurewei.com; dmarc=pass action=none header.from=futurewei.com; dkim=pass header.d=futurewei.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Futurewei.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pYqic6mb3tU3/oKyenuJQqOGrHMLbPTE4Esk9eVk6xw=; b=smelE3/naWnZeRO/Sc+8kYrYyaTvC2tM1GYe86D07cWYGAh4vQcL1uOmPkJpva1tbDvvFX8qTm9OiZFG8tzXXD0i9my04nqERxENtMXwxDyoji5iivnAs+Iz6Pp1SKTY26BSDQ44jBWdhhEJKlSLzuF6yhBNxnIC88JVRyurTVA=
Received: from MW5PR13MB5485.namprd13.prod.outlook.com (2603:10b6:303:190::9) by SJ0PR13MB5320.namprd13.prod.outlook.com (2603:10b6:a03:3dc::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Wed, 27 Mar 2024 17:38:52 +0000
Received: from MW5PR13MB5485.namprd13.prod.outlook.com ([fe80::94b2:fd09:96e3:f13]) by MW5PR13MB5485.namprd13.prod.outlook.com ([fe80::94b2:fd09:96e3:f13%4]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 17:38:46 +0000
From: James Guichard <james.n.guichard@futurewei.com>
To: "draft-ietf-mpls-ri-rsvp-frr@ietf.org" <draft-ietf-mpls-ri-rsvp-frr@ietf.org>
CC: "mpls-chairs@ietf.org" <mpls-chairs@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: AD review for https://datatracker.ietf.org/doc/draft-ietf-mpls-ri-rsvp-frr/
Thread-Index: AQHagG07moD6+YWWw0u00WOX7Mt+dA==
Date: Wed, 27 Mar 2024 17:38:46 +0000
Message-ID: <MW5PR13MB5485B1C10BED20F3DFA9A98BD2342@MW5PR13MB5485.namprd13.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MW5PR13MB5485:EE_|SJ0PR13MB5320:EE_
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: bSNtECswI7hywGinBY8Y/1vgTsB4T9ikOQWXMCI6lxChUqNOVrMNQAb+DH+ScEl6O0Evum8DrY5/DEyRVm7s7bmn6DomJb2BV4Qze7SG8VsEA3Mu/v1+2vFJb8NBSlGMoXFIJt+2lzNdr8OYtjMsUFIizvdf1fHrdsZG9IKbupwP94QkBX5rMltZDga2khTF8y4IRTmcliiAvu7R/rGPa5mWsOxeqZja1L1vhRrYkhEgX7Jp0F2RPqikyTt+8wqgVr314btv2FKJwTQRXuHeQZ2mI8yRerqI6WDSA3COD8XwMpYjecZiV0bze2nizaGEUiRXpkc3krqS9wj7FrA+1BLbylMOlaH89cp5sV5a7ufNBjb3+a1p15o4G2zrZSAKdAXfzOEzlkAl4I1QMIj5ECWseABVjP8EPbqxRZ6qL1PKiVwH3+hHduf+iTc/OMO4LR3BFbmT2XYCclNmGu66fuTzmi1LHrZMsgo4z1eYOdYCPnmMBrYV64QsoK80LM0n32f+YaSt3yyYPsV4MG6cUShkCwFySyVgQDCZr2Lq6uBZWJhKIqW7bfAprrjJfkyOksA6ccXBjo8qja1W4JUHKIuRcqB/gqmdDs15Ck4xcUo=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR13MB5485.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: GbotrwgugQmpomnBZlKmdjCabgvC2ejBYd3qkJllK0QTUdFQyZlFXFobplrYIBcau7nDf40uItjzUKxLW77bk8/fwXFCetUR1Q8ndflUCahfUw/ixfiOSorGk7xNfC2w2Sx5jr+mgmDcM4kTZi6OjOQa+7fQLyqSCKbF+kYDopPdvXdBBo+olw84xoERuSAldyNjWOz8hbb7SLbI4E0N51Xrf7SxTGR1QWVA4m1XDBoqnActTndb8qpSdBCKCYQpyO10bFJHLy++OKAxz7GdcKMP2zbOQblz3GIDBniRLTp/lVZmZ2iLOLcCY5SK7Su3acTgHaeU91cB4WqCcSDNf6fUWKOduhNbImAOLaAiqcQJddVsun+Tg6IzLSNxLPCkfClF5Y4cO9qm1dB+P0q4OLX/Fc7dVbYHcJHIQlUbAs+eQ1AI4ETWn93mt3fRqHA4Yw2by9w7mBV/IC4rzL9ABsO8Of5YtYASn6qhffm1bvXnl58BypKg/RMLY20FNQTV9XsAW+a2/xcuIpyhl5aqLZhM0k/ZTVrn3MSWDAxzxE9SZ7LGBoTPBB85zgqsZR8RpMr1mqg2O18l+VeEeVwiiSLF8yTJBnOaD/6tEDIYCsF/yub6ya2nugY8t4e2W7CjGuBd7h2QRCWBS+mvGsKRQy32A7f/kWyPwFhdkXsWyje3uyIIspTjQoVfmAL9A+GR+CVBa9t8AutXU6dKUrb+W6oDGoyoM1TnZrTehXV8zZv3S3YzYpslT/WIx6wlW5B8RRplLQWYIaiUTuI6c6Z/WtAnZiyGV1325zvSxEUbQ+YCFTrch1cOs+PvzuJ37NjUujHbpmJ053VlMEMy5yb/kib64nyR6DkqkpPLzJEYDshBhAdrcFO8Qv0VVk9JAZxZ4PVaGn1XzX1mtUVEyc+UlXLje+dbJkW1e9I1mo0s+VNqUWFxqAER9wvS4jhMaRIw3LttFc6yYrxwaP8JyrafB6L5TjQ8JkwU1w7aLz0xiW+SvFw5D3K+TLEjdL6/juX66IH2DTXXkNfse9rYSBwt1rTn/QKRy47g+Eegd05C39qLVm+1JAWs1HAD5yqNYiyXzaXJbN0xKFEGsojsqQpW5ANXj8+cuiseBvD+NZuO2q+jJ2CZYpZB3lyW9vAeOs1DUKQ6TabwWL1TgWh5W+5706SLXFodoUsk/Qqa3DM6ftIf9/B2uLD5xxEWqKxWJWR/mhw+ovkwlT8grg8KOUz84aSxoXGBfID3uRW2gjaK536QSWRbENTBKTgOCyzKKBhhYdXLrO4ZlwdtNAQ/Y5pyOrRawNO0GqBxJNH1A6KaEO5LpGNCZWoYgxaxcIAjtOl3BlKU36WW79ZDoaHB6UkyHMCxehRul9zm5UXYGrVohqS9Dy+PrY05zXeU1AG574CAXEqWmmRk8Taflf6/Y4ibBJyqKZznVgBFr9bFkeOlpafUGYRItRJPl/4HpzkpT3JtFt5Xurmu8y1oCe3cR9XTjFXKdBM8spY5n1WV44uCoN9vK5+8UV2xewcWv/c3d0CAsEzXtMW+ifyGLxIX908qMiPdWyz2SMEkaE7KPAp19m0ZPxPDLDcj3KKV4Jrcy1VKQ04rGzIdzOIl5UBfLayaJcWGsIHiwQBklZVbhOl1LsVQsnXhSbem2oUgbXOK7lTuHBhU7auLUb06ufl50u3YiQjANlvw57eVHezcV59BXPU=
Content-Type: multipart/alternative; boundary="_000_MW5PR13MB5485B1C10BED20F3DFA9A98BD2342MW5PR13MB5485namp_"
MIME-Version: 1.0
X-OriginatorOrg: Futurewei.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR13MB5485.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b52994c6-5ca5-4ee0-62ff-08dc4e84c12e
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 17:38:46.3401 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fee8ff2-a3b2-4018-9c75-3a1d5591fedc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rHn2z1IPPTj0x6bEhgZcXBc+W/wX3zJNGQQNIlWLyL6BSSDDfN5WUN9+RZA8XA3f0h1D8DIuf3ZBHkEBJRlxzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5320
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/xoPc-KRuGp_i4BRCjtmyzdjSn3Y>
Subject: [mpls] AD review for https://datatracker.ietf.org/doc/draft-ietf-mpls-ri-rsvp-frr/
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Mar 2024 17:39:06 -0000

Dear Authors:

Thank you for an easy to read and well-structured document. I have only cosmetic comments as follows. Note that I have used idnit format to show line numbers for ease of review.





32    Requirements Language



34      The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",

35      "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this

36      document are to be interpreted as described in RFC-2119 [RFC2119].



Jim> Please update with the new boilerplate from RFC8174 as follows:



      The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL

      NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",

      "MAY", and "OPTIONAL" in this document are to be interpreted as

      described in BCP 14<https://www.rfc-editor.org/bcp/bcp14> [RFC2119<https://www.rfc-editor.org/rfc/rfc2119>] [RFC8174<https://www.rfc-editor.org/rfc/rfc8174>] when, and only when, they

      appear in all capitals, as shown here.



128     RFC 2961 specifies mechanisms to eliminate the reliance on periodic…



Jim> General comment. Please enclose all references like above in [] to indicate a reference. There are various occurrences of this so please correct throughout the document.



357   4.1.  Requirement on RFC 4090 Capable Node to advertise RI-RSVP

358         Capability



360     A node supporting facility backup protection [RFC4090] MUST set the

361     RI-RSVP capability (I bit) defined in Section 3.1 of RSVP-TE Scaling



Jim> The above is actually the RI-RSVP Capable flag so I would say “A node supporting facility backup protection [RFC4909] MUST set the RI-RSVP flag (I-bit) that is defined in Section 3.1 of …”



372     Procedures for backward compatibility Section 4.6.2.3 delves on this



Jim> Please make clear that Section 4.6.2.3 is *this document* not some other RFC reference.

Jim