Re: [mpls] Review of draft-ietf-mpls-residence-time-12

Uma Chunduri <uma.chunduri@huawei.com> Thu, 19 January 2017 21:32 UTC

Return-Path: <uma.chunduri@huawei.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 803F012962A; Thu, 19 Jan 2017 13:32:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.419
X-Spam-Level:
X-Spam-Status: No, score=-7.419 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-3.199, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YN10YvHm6KRl; Thu, 19 Jan 2017 13:32:20 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8653712962C; Thu, 19 Jan 2017 13:32:18 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml707-cah.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DEV89400; Thu, 19 Jan 2017 21:32:15 +0000 (GMT)
Received: from DFWEML701-CAH.china.huawei.com (10.193.5.175) by lhreml707-cah.china.huawei.com (10.201.5.199) with Microsoft SMTP Server (TLS) id 14.3.301.0; Thu, 19 Jan 2017 21:32:14 +0000
Received: from DFWEML501-MBB.china.huawei.com ([10.193.5.179]) by dfweml701-cah.china.huawei.com ([10.193.5.175]) with mapi id 14.03.0301.000; Thu, 19 Jan 2017 13:32:09 -0800
From: Uma Chunduri <uma.chunduri@huawei.com>
To: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>, John E Drake <jdrake@juniper.net>, "Acee Lindem (acee)" <acee@cisco.com>, "Alexander Vainshtein" <Alexander.Vainshtein@ecitele.com>, Greg Mirsky <gregimirsky@gmail.com>
Thread-Topic: [mpls] Review of draft-ietf-mpls-residence-time-12
Thread-Index: AQHScaXofEGnTa0lXkKsZavczt3GZqE/DUqAgAAIcoCAAA47gIAAOcyAgAEa0YCAAAPVAIAAALgAgAAEO4CAAAY+gIAAAXiAgAABGACAAAHkAIAACKuA//+eF+CAAJBigP//i+sQ
Date: Thu, 19 Jan 2017 21:32:09 +0000
Message-ID: <25B4902B1192E84696414485F5726854018778F8@dfweml501-mbb>
References: <148414970343.8167.4538946698521330202.idtracker@ietfa.amsl.com> <CA+RyBmU9W5QP4EjbPezoCpdLHv1RJCrzJvxQmeTnAvjO_6vbJA@mail.gmail.com> <CA+RyBmVrvyiwDp2kV3VLiQtqOaL=MaVjZugGbvgWnp6y3dwP3Q@mail.gmail.com> <95d41b52-5c85-869f-2139-6713816e9637@nostrum.com> <CA+RyBmWcvU70BZYRj8ZHUZrmkcwq1eHS38jFpyZOq3A_5eXZ9g@mail.gmail.com> <D4A55AE0.9483E%acee@cisco.com> <CA+RyBmWrDhZUmVN0t8aLsL6F3ZfnvBu8FW_2VjDmwj-ercLd5w@mail.gmail.com> <f315026a140148898250f8fa3bdb0123@XCH-ALN-001.cisco.com> <CA+RyBmWMBAXd+zntuAeOU9x7xs9BQSk7J-z9+yyUDvKPd3v2MA@mail.gmail.com> <HE1PR0301MB22660A73C0D5A96BA8F3F0D39D7E0@HE1PR0301MB2266.eurprd03.prod.outlook.com> <D4A65103.94DF0%acee@cisco.com> <DM5PR05MB3001952D0DDD2AA672697094C77E0@DM5PR05MB3001.namprd05.prod.outlook.com> <D4A6573B.94E53%acee@cisco.com> <DM5PR05MB3001ED6AF8296F5DBE5E38EFC77E0@DM5PR05MB3001.namprd05.prod.outlook.com> <3f43cfdfe76e437bb2df6159e5644ae5@XCH-ALN-001.cisco.com> <25B4902B1192E84696414485F57268540187782A@dfweml501-mbb> <af41a7a12f104009ac4efff91baefbc3@XCH-ALN-001.cisco.com>
In-Reply-To: <af41a7a12f104009ac4efff91baefbc3@XCH-ALN-001.cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.213.49.109]
Content-Type: multipart/alternative; boundary="_000_25B4902B1192E84696414485F5726854018778F8dfweml501mbb_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.58813060.0220, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: d9b0f707505a610b0b650e5a99939e32
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/yg-l0-1InENg4xDru1TbfRGnFY8>
Cc: "mpls@ietf.org" <mpls@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "isis-chairs@ietf.org" <isis-chairs@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-mpls-residence-time.all@ietf.org" <draft-ietf-mpls-residence-time.all@ietf.org>, "Abhay Roy \(akr\)" <akr@cisco.com>, Robert Sparks <rjsparks@nostrum.com>
Subject: Re: [mpls] Review of draft-ietf-mpls-residence-time-12
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jan 2017 21:32:24 -0000

Les,

I see what you are saying. Quick response in-line [Uma]:

--
Uma C.

From: Les Ginsberg (ginsberg) [mailto:ginsberg@cisco.com]
Sent: Thursday, January 19, 2017 12:11 PM
To: Uma Chunduri <uma.chunduri@huawei.com>om>; John E Drake <jdrake@juniper.net>et>; Acee Lindem (acee) <acee@cisco.com>om>; Alexander Vainshtein <Alexander.Vainshtein@ecitele.com>om>; Greg Mirsky <gregimirsky@gmail.com>
Cc: Abhay Roy (akr) <akr@cisco.com>om>; mpls@ietf.org; isis-chairs@ietf.org; gen-art@ietf.org; draft-ietf-mpls-residence-time.all@ietf.org; Robert Sparks <rjsparks@nostrum.com>om>; ietf@ietf.org
Subject: RE: [mpls] Review of draft-ietf-mpls-residence-time-12

Uma -

I readily admit S-BFD descriptors are - strictly speaking - a violation of the "non-routing info" policy - this was publicly acknowledged at the time the drafts were written. The exception was justified on the basis that:

  o IGPs are BFD clients
  o The S-BFD discriminator information is unique and extremely modest in size

What we have here is a proposal to start advertising non-routing related interface attribute information. There is nothing special or unique about RTM - it is simply one of many interface attributes which are generic in nature. Having agreed to advertise RTM in the IGPs, how would you then determine what other interface attributes should/should not be advertised by the IGPs? Take a look at your favorite vendors box and see how many interface attributes can be configured.
[Uma]: Well, depends on the use case.  Here I see this needs to go to egress node too..

It is also concerning that - when using the IGPs - we flood information which must be stored on every node even though the use case for it is limited to a much smaller subset.
I think we can and should be smarter in this regard - and given the extensive work being done to enhance manageability I would like to see us benefit from this.

The authors of draft-ietf-mpls-residence-time clearly had some thoughts in this regard - which is why they proposed to use RFC 6823 (GENAPP) in IS-IS to advertise the information -but the proposal in the draft is flawed in this regard. If we were to head in the "application" direction I would propose a much more generic "application" which is capable of advertising many interface attributes. However this goes back to my original concern - whether we want to use IGPs to flood interface attribute information unrelated to routing even if it is segregated under an application. Remember that RFC 6823 stipulates that a separate instance of the protocol (a la RFC 6822) be used for such cases.

[Uma]: +1 here. It does require additional instance and which could bring additional operational overhead here. I didn't bring this in because as the discussion is more about if this should be in IGP. I do prefer to match this to section 8.2 equivalent i.e., 22/222/23/223.

   Les


From: Uma Chunduri [mailto:uma.chunduri@huawei.com]
Sent: Thursday, January 19, 2017 11:41 AM
To: Les Ginsberg (ginsberg); John E Drake; Acee Lindem (acee); Alexander Vainshtein; Greg Mirsky
Cc: Abhay Roy (akr); mpls@ietf.org<mailto:mpls@ietf.org>; isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>; gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>; Robert Sparks; ietf@ietf.org<mailto:ietf@ietf.org>
Subject: RE: [mpls] Review of draft-ietf-mpls-residence-time-12

I support advertising this in IGP.


>This is clearly not TE information -..
>I do not see the IGPs as the appropriate mechanism to flood generic interface capabilities

We have instances where both the above are not met and we flooded information.
https://tools.ietf.org/html/rfc7883 (Les, you co-authored the same!!)
https://tools.ietf.org/html/rfc7880

--
Uma C.

From: mpls [mailto:mpls-bounces@ietf.org] On Behalf Of Les Ginsberg (ginsberg)
Sent: Thursday, January 19, 2017 9:25 AM
To: John E Drake <jdrake@juniper.net<mailto:jdrake@juniper.net>>; Acee Lindem (acee) <acee@cisco.com<mailto:acee@cisco.com>>; Alexander Vainshtein <Alexander.Vainshtein@ecitele.com<mailto:Alexander.Vainshtein@ecitele.com>>; Greg Mirsky <gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>>
Cc: Abhay Roy (akr) <akr@cisco.com<mailto:akr@cisco.com>>; mpls@ietf.org<mailto:mpls@ietf.org>; isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>; gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>; Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>>; ietf@ietf.org<mailto:ietf@ietf.org>
Subject: Re: [mpls] Review of draft-ietf-mpls-residence-time-12

John -

For me, this raises the age-old question of when it is/is not appropriate to use IGPs for flooding information.

This is clearly not TE information - you just happen to be using this in conjunction with MPLS - but it is a generic capability. I do not see the IGPs as the appropriate mechanism to flood generic interface capabilities. It also, as Acee has pointed out, results in flooding information to all nodes in the domain when only a few care about it.

   Les

From: John E Drake [mailto:jdrake@juniper.net]
Sent: Thursday, January 19, 2017 8:54 AM
To: Acee Lindem (acee); Alexander Vainshtein; Greg Mirsky; Les Ginsberg (ginsberg)
Cc: Robert Sparks; mpls@ietf.org<mailto:mpls@ietf.org>; gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>; ietf@ietf.org<mailto:ietf@ietf.org>; isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>; Abhay Roy (akr)
Subject: RE: [mpls] Review of draft-ietf-mpls-residence-time-12

Acee,

Relying on an omniscient controller is a non-starter in general and in particular because the protocol by which it would learn each node's RTM capabilities and distribute them to the other nodes is undefined.  Further, one of the ways by which an omniscient controller learns a node's capabilities is by snooping the link/state database.

Yours Irrespectively,

John

From: Acee Lindem (acee) [mailto:acee@cisco.com]
Sent: Thursday, January 19, 2017 11:47 AM
To: John E Drake <jdrake@juniper.net<mailto:jdrake@juniper.net>>; Alexander Vainshtein <Alexander.Vainshtein@ecitele.com<mailto:Alexander.Vainshtein@ecitele.com>>; Greg Mirsky <gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>>; Les Ginsberg (ginsberg) <ginsberg@cisco.com<mailto:ginsberg@cisco.com>>
Cc: Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>>; mpls@ietf.org<mailto:mpls@ietf.org>; gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>; ietf@ietf.org<mailto:ietf@ietf.org>; isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>; Abhay Roy (akr) <akr@cisco.com<mailto:akr@cisco.com>>
Subject: Re: [mpls] Review of draft-ietf-mpls-residence-time-12

Hi John,

From: John E Drake <jdrake@juniper.net<mailto:jdrake@juniper.net>>
Date: Thursday, January 19, 2017 at 10:43 AM
To: Acee Lindem <acee@cisco.com<mailto:acee@cisco.com>>, Alexander Vainshtein <Alexander.Vainshtein@ecitele.com<mailto:Alexander.Vainshtein@ecitele.com>>, Greg Mirsky <gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>>, "Les Ginsberg (ginsberg)" <ginsberg@cisco.com<mailto:ginsberg@cisco.com>>
Cc: Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>>, "mpls@ietf.org<mailto:mpls@ietf.org>" <mpls@ietf.org<mailto:mpls@ietf.org>>, "gen-art@ietf.org<mailto:gen-art@ietf.org>" <gen-art@ietf.org<mailto:gen-art@ietf.org>>, "draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>" <draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>>, "ietf@ietf.org<mailto:ietf@ietf.org>" <ietf@ietf.org<mailto:ietf@ietf.org>>, "isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>" <isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>>, "Abhay Roy (akr)" <akr@cisco.com<mailto:akr@cisco.com>>
Subject: RE: [mpls] Review of draft-ietf-mpls-residence-time-12

Acee,

We discussed all of this with you over a year ago and used your guidance in adding the indication of RTM capability to OSPF.

I'm sorry but I focused mainly on the OSPF protocol aspects then and didn't question the use case. This question came up in the IS-IS WG discussions.

Thanks,
Acee


Yours Irrespectively,

John

From: Acee Lindem (acee) [mailto:acee@cisco.com]
Sent: Thursday, January 19, 2017 11:38 AM
To: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com<mailto:Alexander.Vainshtein@ecitele.com>>; Greg Mirsky <gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>>; Les Ginsberg (ginsberg) <ginsberg@cisco.com<mailto:ginsberg@cisco.com>>
Cc: Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>>; mpls@ietf.org<mailto:mpls@ietf.org>; gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>; ietf@ietf.org<mailto:ietf@ietf.org>; isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>; Abhay Roy (akr) <akr@cisco.com<mailto:akr@cisco.com>>
Subject: Re: [mpls] Review of draft-ietf-mpls-residence-time-12

I guess what we were trying to envision the use case and whether it makes sense for all the nodes in the IGP routing domain to have this information. Would the LSP ingress LSR only need to if the egress LSR supports RTM and it is best effort recording for transit LSRs in the path?

Additionally, if it is needed in the IGPs, should there also be a BGP-LS Link Attribute TLV proposed?

Thanks,
Acee

From: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com<mailto:Alexander.Vainshtein@ecitele.com>>
Date: Thursday, January 19, 2017 at 10:15 AM
To: Greg Mirsky <gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>>, "Les Ginsberg (ginsberg)" <ginsberg@cisco.com<mailto:ginsberg@cisco.com>>
Cc: Acee Lindem <acee@cisco.com<mailto:acee@cisco.com>>, Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>>, "mpls@ietf.org<mailto:mpls@ietf.org>" <mpls@ietf.org<mailto:mpls@ietf.org>>, "gen-art@ietf.org<mailto:gen-art@ietf.org>" <gen-art@ietf.org<mailto:gen-art@ietf.org>>, "draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>" <draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>>, "ietf@ietf.org<mailto:ietf@ietf.org>" <ietf@ietf.org<mailto:ietf@ietf.org>>, "isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>" <isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>>, "Abhay Roy (akr)" <akr@cisco.com<mailto:akr@cisco.com>>
Subject: RE: [mpls] Review of draft-ietf-mpls-residence-time-12

Hi all,
I concur with Greg: from my POV an interoperable solution should not depend on an omniscient NMS client distributing information about capabilities of each node to each other node.


Regards,
Sasha

Office: +972-39266302
Cell:      +972-549266302
Email:   Alexander.Vainshtein@ecitele.com<mailto:Alexander.Vainshtein@ecitele.com>

From: Greg Mirsky [mailto:gregimirsky@gmail.com]
Sent: Thursday, January 19, 2017 6:01 PM
To: Les Ginsberg (ginsberg) <ginsberg@cisco.com<mailto:ginsberg@cisco.com>>
Cc: Acee Lindem (acee) <acee@cisco.com<mailto:acee@cisco.com>>; Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>>; mpls@ietf.org<mailto:mpls@ietf.org>; gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>; ietf@ietf.org<mailto:ietf@ietf.org>; isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>; Abhay Roy (akr) <akr@cisco.com<mailto:akr@cisco.com>>
Subject: Re: [mpls] Review of draft-ietf-mpls-residence-time-12

Hi Les,
I believe that IGP extensions to advertise RTM capability are required.

Regards,
Greg

On Thu, Jan 19, 2017 at 7:57 AM, Les Ginsberg (ginsberg) <ginsberg@cisco.com<mailto:ginsberg@cisco.com>> wrote:
Greg -

I am having trouble understanding your response.
The question we are raising is whether we should extend the IGPs to support advertising RTM capability - an alternative being to retrieve the capability via network management.

Saying that the IGP functionality is optional and/or wouldn't always be advertised doesn't really answer the question of whether we should or should not define the IGP extensions.

Could you respond more directly to this point?

   Les


From: Greg Mirsky [mailto:gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>]
Sent: Thursday, January 19, 2017 7:44 AM
To: Acee Lindem (acee)
Cc: Robert Sparks; mpls@ietf.org<mailto:mpls@ietf.org>; gen-art@ietf.org<mailto:gen-art@ietf.org>; draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>; ietf@ietf.org<mailto:ietf@ietf.org>; Les Ginsberg (ginsberg); isis-chairs@ietf.org<mailto:isis-chairs@ietf.org>; Abhay Roy (akr)

Subject: Re: [mpls] Review of draft-ietf-mpls-residence-time-12

Hi Acee,
the draft defines optional functionality. If an operator has no use neither for PTP's Transparent Clock, nor RTM itself as performance metric, then RTM sub-TLV would not be included and thus it would not be flooded. Of course, it be right to reflect RTM capability through YANG data model, thus allowing SDN scenario you've described.

Regards,
Greg

On Wed, Jan 18, 2017 at 2:51 PM, Acee Lindem (acee) <acee@cisco.com<mailto:acee@cisco.com>> wrote:
Hi Greg,

Although it is a bit late, we've had some discussions amongst the IS-IS and OSPF chairs and are wondering whether the interface capability belongs in the IGPs. This will be flooded throughout the entire routing domain - is it really needed on every node or will it the RTM testing be initiated from an omniscient NMS client that would know the capabilities of each node or easily query them using YANG?

Thanks,
Acee

From: mpls <mpls-bounces@ietf.org<mailto:mpls-bounces@ietf.org>> on behalf of Greg Mirsky <gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>>
Date: Wednesday, January 18, 2017 at 1:25 PM
To: Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>>
Cc: "mpls@ietf.org<mailto:mpls@ietf.org>" <mpls@ietf.org<mailto:mpls@ietf.org>>, "gen-art@ietf.org<mailto:gen-art@ietf.org>" <gen-art@ietf.org<mailto:gen-art@ietf.org>>, "draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>" <draft-ietf-mpls-residence-time.all@ietf.org<mailto:draft-ietf-mpls-residence-time.all@ietf.org>>, "ietf@ietf.org<mailto:ietf@ietf.org>" <ietf@ietf.org<mailto:ietf@ietf.org>>
Subject: Re: [mpls] Review of draft-ietf-mpls-residence-time-12

Hi Robert,
thank you for the most expedient review and comments. I'll make changes in Section 2 per your suggestion.

Regards,
Greg

On Wed, Jan 18, 2017 at 10:34 AM, Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>> wrote:

The changes all look good.

I still think you should say something in the document about what "the time of packet arrival" and "transmission" means, and call out the point you made about being careful to not introduce apparent jitter by not making those measurements consistently. (The definitions you point to in your earlier mail from G.8013 don't really help - they just say "time of packet arrival". Again, the first and last bit are likely to be several nanoseconds apart so I think it matters. Perhaps you're saying it doesn't matter as long as each node is consistent (there will be error in the residence time measurement, but it will be constant at each node, so the sum of errors will be constant, and the clocks will be ok?)

Please look at the new first paragraph of section 2 - there's a mix of "as case" and "in case" that should be made consistent. I suspect it would be easiest to simply say "referred to as using a one-step clock" and "referred to as using a two-step clock" or similar.

RjS

On 1/18/17 12:03 PM, Greg Mirsky wrote:
Hi Robert,
Sasha Vainshtein came with elegant idea to address disconnection between discussion of one-step and two-step modes that you've pointed out. We've moved Section 7 as sub-section into Section 2 now. Attached are updated diff and the proposed new version -13.

Regards,
Greg

On Wed, Jan 18, 2017 at 8:13 AM, Greg Mirsky <gregimirsky@gmail.com<mailto:gregimirsky@gmail.com>> wrote:
Hi Robert,
once again, thank you for your thorough review and the most detailed comments. I've prepared updated version and would greatly appreciate if you review the changes and let us know whether your comments been addressed. Attached are diff and the new version.

Regards,
Greg

On Wed, Jan 11, 2017 at 7:48 AM, Robert Sparks <rjsparks@nostrum.com<mailto:rjsparks@nostrum.com>> wrote:
Reviewer: Robert Sparks
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-mpls-residence-time-12
Reviewer: Robert Sparks
Review Date: 2017-01-10
IETF LC End Date: 2017-01-17
IESG Telechat date: 2017-02-02

Summary: Ready (with nits) for publication as a Proposed Standard

I have two primary comments. I expect both are rooted in the authors
and working group knowing what the document means instead of seeing
what
it says or doesn't say:

1) The document is loose with its use of 'packet', and where TTLs
appear when
they are discussed. It might be helpful to rephrase the text that
speaks
of RTM packets in terms of RTM messages that are encoded as G-ACh
messages and
not refer to packets unless you mean the whole encapsulated packet
with MPLS
header, ACH, and G-ACh message.

2) Since this new mechanic speaks in terms of fractional nanoseconds,
some
discussion of what trigger-point you intend people to use for taking
the
precise time of a packet's arrival or departure seems warranted. (The
first and
last bit of the whole encapsulated packet above are going to appear at
the
physical layer many nanoseconds apart at OC192 speeds if I've done the
math
right). It may be obvious to the folks discussing this, but it's not
obvious
from the document.  If it's _not_ obvious and variation in technique
is
expected, then some discussion about issues that might arise from
different
implementation choices would be welcome.

The rest of these are editorial nits:

It would help to pull an overview description of the difference
between
one-step and two-step much earlier in the document. I suggest in the
overview
in section 2. Otherwise, the reader really has to jump forward and
read section
7 before section 3's 5th bullet makes any sense.

In section 3, "IANA will be asked" should be made active. Say "This
document
asks IANA to" and point to the IANA consideration section. Apply
similar
treatment to the other places where you talk about future IANA
actions.

There are several places where there are missing words (typically
articles or
prepositions). You're less likely to end up with misinterpretations
during the
RFC Editor phase if you provide them before the document gets that far
in the
process. The spots I found most disruptive were these (this is not
intended to
be exhaustive):

  Section 3: "set 1 according" -> "set to 1 according"
  Section 3: "the Table 19 [IEEE..." -> "Table 19 of [IEEE..."
  Section 4.2: "Detailed discussion of ... modes in Section 7."
                        -> "Detailed discussion of ... modes appears
in Section 7."
  Section 10: "most of" -> "most of all"

In Setion 3.1 at "identity of the source port", please point into the
document
that defines this identity and its representation. I suspect this is a
pointer
into a specific section in IEEE.1588.2008].