Re: [multipathtcp] ADD_ADDR HMAC ambiguity

Alan Ford <alan.ford@gmail.com> Wed, 20 May 2020 20:38 UTC

Return-Path: <alan.ford@gmail.com>
X-Original-To: multipathtcp@ietfa.amsl.com
Delivered-To: multipathtcp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF8983A0ADD for <multipathtcp@ietfa.amsl.com>; Wed, 20 May 2020 13:38:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F7CQ0Y1kc_KD for <multipathtcp@ietfa.amsl.com>; Wed, 20 May 2020 13:38:23 -0700 (PDT)
Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E2353A0ADB for <multipathtcp@ietf.org>; Wed, 20 May 2020 13:38:23 -0700 (PDT)
Received: by mail-wm1-x331.google.com with SMTP id z72so4262155wmc.2 for <multipathtcp@ietf.org>; Wed, 20 May 2020 13:38:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tCMqohQduSBNpB6ytNAY4MNzwhspKMdh33lJdx+9QVE=; b=OlUybuzMb3UG4I+UX5nKBi5AiquOysC6oaiZ8Y71fB3uWgbiPgDzctpqSURvQGrsVC 9HLijPsYZzvpmmsK2bhKXB6oSHX0g2mitb62ZLizQ5YIgzwwMUGYxr3cAbTBTMW6fB6e abdLcwFxg5EdHB5qEN7h/Zsqup0xuJ6ti1S4AFnHgWMjSVgql8WPJ1Cmye0zsrO8gnc/ 7y3Xodh8klwsjb+WCyzLhZ44dUtPwKYvHnTd0vFTHydtbb2iDftygL0qp1T3+QFk/5vy QuZMOCFOmDV+yr+R7H/ufRYvSkLohSs00jqViD8mr5HHrTBQnnuWZy12bgZGw7p0PovZ ZsuQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=tCMqohQduSBNpB6ytNAY4MNzwhspKMdh33lJdx+9QVE=; b=JegWflKCpG2wdCdP1kYRuwqe7O2FnfaNm8xCMWwk4lDQyK95MhVmo0+GQrHEWNhg8j 7rFJaAnezomDuH43DjSoIZ5pKZONJF1lfVwypOTlcclXNLfmiskBYz11Psl0KBjAIWpL J0ne0X5dPVaA3CkYPVdR+xi9aCZYL1ZPMS7/dNFVhyK2Ga9Mq2TBkyCyD712yl8ih1Ho Gosoc2YkCRm4jXkquvoh93LH3u06R7pUhPBVhxKWPT/D5lEVSLyT/YtSFTkhUoAuoEFf DvobRj+nVeJJ4LgL41h8W6rGeCyVR4vDVqjShgHlt3jsd9ob6YK/dYU+S36RxK946XF2 /d8w==
X-Gm-Message-State: AOAM533UXXZMCxIB/e/COximJAvnqzgYg/FAN8fFCNUuX724/xmQpRe8 gQUHI2Xm0ZzkwAultQf5uB4=
X-Google-Smtp-Source: ABdhPJxPsDSPcSHlVZ2Hp5eL/rALukEQMa+EBnMIDml3wer8LkTt3/4YLFrO/ddd/ycZW6TyYm25dQ==
X-Received: by 2002:a1c:1d12:: with SMTP id d18mr5780997wmd.109.1590007101507; Wed, 20 May 2020 13:38:21 -0700 (PDT)
Received: from alan-mbp.lan (50.118.208.46.dyn.plus.net. [46.208.118.50]) by smtp.gmail.com with ESMTPSA id h27sm4389788wrc.46.2020.05.20.13.38.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 May 2020 13:38:20 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
From: Alan Ford <alan.ford@gmail.com>
In-Reply-To: <20200520164023.GH45434@MacBook-Pro-64.local>
Date: Wed, 20 May 2020 21:38:18 +0100
Cc: MultiPath WG <multipathtcp@ietf.org>, mptcp Upstreaming <mptcp@lists.01.org>, Todd Malsbary <todd.malsbary@linux.intel.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <882ACBE0-07FC-4BB8-B0BC-60A884DA1DD7@gmail.com>
References: <20200520164023.GH45434@MacBook-Pro-64.local>
To: Christoph Paasch <cpaasch=40apple.com@dmarc.ietf.org>
X-Mailer: Apple Mail (2.3445.9.5)
Archived-At: <https://mailarchive.ietf.org/arch/msg/multipathtcp/9LN5GLZFC_LHiTNOpdMNwJVWxbg>
Subject: Re: [multipathtcp] ADD_ADDR HMAC ambiguity
X-BeenThere: multipathtcp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-path extensions for TCP <multipathtcp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/multipathtcp>, <mailto:multipathtcp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/multipathtcp/>
List-Post: <mailto:multipathtcp@ietf.org>
List-Help: <mailto:multipathtcp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/multipathtcp>, <mailto:multipathtcp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 May 2020 20:38:25 -0000

Hi Christoph,

Your interpretation is the intended one.

3.4.1 says "rightmost 64 bits of an HMAC” … the HMAC is 256 bits in both 3.2 and 3.4.1. The truncation is the separate from the definition of the HMAC algorithm used.

Best regards,
Alan

> On 20 May 2020, at 17:40, Christoph Paasch <cpaasch=40apple.com@dmarc.ietf.org> wrote:
> 
> Hello,
> 
> Todd Malsbary from Intel is looking at the HMAC-support for ADD_ADDR in
> RFC8684. And it appears that there can be an ambiguity on how to interpret
> the truncation.
> 
> We want to clarify this and make sure all implementations,... are on the
> same page with the intention of the RFC:
> 
> RFC8684, Section 3.4.1 says:
> " The Truncated HMAC parameter present in this option is the rightmost
>  64 bits of an HMAC, negotiated and calculated in the same way as for
>  MP_JOIN as described in Section 3.2. "
> 
> Now, in Section 3.2 it mentions:
> " This specification defines that HMAC as defined in [RFC2104] is used,
>  along with the SHA-256 hash algorithm [RFC6234], and that the output
>  is truncated to the leftmost 160 bits (20 octets). "
> 
> 
> One can read these in two different ways:
> 
> In Section 3.4.1, the truncation to the rightmost 64 bits is based on the
> full 256-bit HMAC-output or whether it is rather the 64 rightmost bits of
> the leftmost 160bits (the ones mentioned in Section 3.2).
> 
> 
> Can we clarify which of the two options is the correct one?
> 
> 
> 
> I personally interpret it as "right most 64 bits of the 256-bit HMAC-output".
> 
> 
> 
> Thanks,
> Christoph
> 
> _______________________________________________
> multipathtcp mailing list
> multipathtcp@ietf.org
> https://www.ietf.org/mailman/listinfo/multipathtcp