IETF Logo Mail Archive

Re: [multipathtcp] I-D Action: draft-ietf-mptcp-rfc6824bis-12.txt

Alan Ford <alan.ford@gmail.com> Thu, 18 October 2018 14:49 UTC

Return-Path: <alan.ford@gmail.com>
X-Original-To: multipathtcp@ietfa.amsl.com
Delivered-To: multipathtcp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8663D12D4EB for <multipathtcp@ietfa.amsl.com>; Thu, 18 Oct 2018 07:49:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zBpoQJniZALj for <multipathtcp@ietfa.amsl.com>; Thu, 18 Oct 2018 07:49:29 -0700 (PDT)
Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A0261128CF2 for <multipathtcp@ietf.org>; Thu, 18 Oct 2018 07:49:28 -0700 (PDT)
Received: by mail-wm1-x336.google.com with SMTP id z204-v6so588853wmc.5 for <multipathtcp@ietf.org>; Thu, 18 Oct 2018 07:49:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=a0Cxqf/pU5M2Spz24Y3Jto4Mm8vhBqsGJPzugzvyOUs=; b=ZFJ7GefoR3nHRGM5zW5ULPR8LqGXt+irRWeU6djC7qXHUOAUwGqAj7QBu00wnqNVvQ lVlWVghib/FTnI+0/hEcUbrA1QYB+9itAedVxOP8pSq4QA0VYblmK8G1YAgiWafoSOST xttR/XY1HIApp+grM2OGmKNxq0UkH/eS1MBe0tkm7BA3wK755bwp79IbWigxViko1elu yB9/zD5jVeJVGYMMAAjSzorN21JY7rRndjrjNRaDUB6kwqkN6Q0p+X1UEoFxBIyNfqRC ky9ZupEFpeTXeiaUDyTKgtjbZYBZkh+XmACy/lKpM2IFfyhte0mvnDf3CV3mOLOTrCEs BlVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=a0Cxqf/pU5M2Spz24Y3Jto4Mm8vhBqsGJPzugzvyOUs=; b=hWHIAXaVFJdqqSksT70XixQke2iT4NBRLm9dZyAnexXgHPEf7skTveoyqrJXdyvdQX 9M9IFuyg3cFf48l9UJQ7gQ+C0vIuQurm/51uLUfzk9LrVDnjycQ0apC5lJI7ipbWsR0x edq5ehA58mgS7TsUH9ZAFt0uUPPN9xgm+GJKRFOpNOuSRMa4ceDS3C1N0paGogYoab+2 f2R+BUHUvjEXDmA9V8Un1UMegDMTBJ2W7LJm8rfm+cvIPD5+am+NFsnLBRRghOn7GqKd 2LaZl3HZwInzLAwdTE5GIgCBhZ+gXg6eqFzJhKVTtolTdXr2D6sHVglDLVD+f42Tjig0 F8rw==
X-Gm-Message-State: ABuFfoiMZ3J+NlZ7X03XL+13QtX5iQXmfzD3q0mEFyiYOoj8+8sv1VwY 9ia++Fy4Q6M6xPrIluKDemo=
X-Google-Smtp-Source: ACcGV625S3FyvUdbQKYb6Mconw/tlNgWid8yWQaLWoOKNsUkPAUHdWeV/QjFmeMMsF6aSPckomqMnw==
X-Received: by 2002:a1c:870c:: with SMTP id j12-v6mr703656wmd.40.1539874166809; Thu, 18 Oct 2018 07:49:26 -0700 (PDT)
Received: from [10.44.30.233] ([62.254.152.194]) by smtp.gmail.com with ESMTPSA id j2-v6sm15629523wrw.29.2018.10.18.07.49.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 07:49:24 -0700 (PDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alan Ford <alan.ford@gmail.com>
In-Reply-To: <LOXP123MB080554CC37A2655A94A4C25EEBFE0@LOXP123MB0805.GBRP123.PROD.OUTLOOK.COM>
Date: Thu, 18 Oct 2018 15:49:17 +0100
Cc: multipathtcp@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <DC56EB70-ED8F-4287-A83B-3B5D324375DB@gmail.com>
References: <153857661587.9120.4590608359579290440@ietfa.amsl.com> <CC367F1F-06FC-4D12-83A2-81435191EA80@gmail.com> <LOXP123MB080554CC37A2655A94A4C25EEBFE0@LOXP123MB0805.GBRP123.PROD.OUTLOOK.COM>
To: "philip.eardley" <philip.eardley@bt.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/multipathtcp/UBy-rpZ_eo9YpC6unkAtvTgooRg>
Subject: Re: [multipathtcp] I-D Action: draft-ietf-mptcp-rfc6824bis-12.txt
X-BeenThere: multipathtcp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-path extensions for TCP <multipathtcp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/multipathtcp>, <mailto:multipathtcp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/multipathtcp/>
List-Post: <mailto:multipathtcp@ietf.org>
List-Help: <mailto:multipathtcp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/multipathtcp>, <mailto:multipathtcp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Oct 2018 14:49:31 -0000

Hi Phil, all,

Inline...

> On 16 Oct 2018, at 17:34, philip.eardley@bt.com wrote:
> 
> Alan,
> Looks good.
> 
> 1. the list of changes /reasons compared with rfc6824 not included. I can submit as separate draft, if you prefer to inclusion in your doc.

I do intend to add this, but have not yet got around to it. I am keen we keep the list clear, consistent, and simple, and focus only on implementation differences.

> 2. I  made a comment on Fig 12 (just checking you meant to ignore it - don’t mind!)
> 
> And in Fig 12
> |        Truncated HMAC (8 octets, if length > 10 octets)       |
> 
> Could this be made more straightforward? Ie spell out when length is >10 octets ie IPv6 (if I understand it). This also seems to mean that IPv4 doesn’t include the HMAC, is this right??

It’s wrong! It should say “If E = 0”. Corrected.

> 3. I made a comment on Section 2:  Need to add sub-sections on closing subflow & fast close & fallback
> Would be nice, but I won't insist if it's too much work

Closing subflow and fast close are covered in the “Closing an MPTCP Connection” subsection. Fallback is too specialist for this introductory overview of signalling.

Best regards,
Alan

v2.23.0 | Report a Bug | By Email