Re: [netconf] [Last-Call] Opsdir last call review of draft-ietf-netconf-sztp-csr-11

Warren Kumari <warren@kumari.net> Wed, 15 December 2021 19:41 UTC

Return-Path: <warren@kumari.net>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92DB53A046E for <netconf@ietfa.amsl.com>; Wed, 15 Dec 2021 11:41:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=kumari.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JHXuCmTqPd1u for <netconf@ietfa.amsl.com>; Wed, 15 Dec 2021 11:41:23 -0800 (PST)
Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9A123A08F9 for <netconf@ietf.org>; Wed, 15 Dec 2021 11:41:23 -0800 (PST)
Received: by mail-io1-xd32.google.com with SMTP id z18so31880944iof.5 for <netconf@ietf.org>; Wed, 15 Dec 2021 11:41:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kumari.net; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0xAr+RmphxYysU02UOc6ZNiAWeUETk+kEBfK/aBxLmQ=; b=ZIQv4L2Gzlwz0KO5Kr1YChSqFUdrwMbLRPisu/+rN/ekQlnahaVwV1fYeFC/NX1bf0 9okw6Uvzm1XTg5oBt0+bQgFgLvVroAQS+kyiD859KotQ6a/RfjWHoQ6qXidsLkjMzQGi faLdFokvnw1SEzCiTT1R/vJ+7beWWMNtm88N2YAgpMTuPgN+SE6WpStS8r+PWolpfM+q 2O34Au7TcDhdocEB5tX/ubzsrDlbyaDpMbDdmiqe7Hk+fJ7q+shTpJPDoAmHz6nbH+0Q EM/gQKNc2ZXHTrT8YLyVNkO/1zVwPsgMQ5ZchJ1c4Qh5arZBYJ8uiLFvSM8rAazlRX3V wI7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0xAr+RmphxYysU02UOc6ZNiAWeUETk+kEBfK/aBxLmQ=; b=P79ZcIWqiHisnKmE+inMrRgiCwQR1iBQlv0KvEmspaNLH6lGAM0RKhGG51KMG/iYNj 4ONjAdqd8w0UxEPszF68+sENBHdY+/YtmY3jH8lSQNr0eNsNv01yexIz9n7CjGltysbU flmY/vIWtxMqYMJa23wuF6uVfU/wAHS2Y4xVrQbIl/P6ABMvnlUef1pi/n1F4yLZmzQi 5Z3ZrwVAVjO//EuTFIJwxmNE9N4cpxL5ACpdyhGUjI3c+FWxSltKVNhnh9HsNZRWC1L/ kxV+MmzZb5FQhbJVWg5CaqyDkLVdNyxu+Aq+qKYfRZHhDRJxjgaWmzzdf9tQvABqJ0vv 4I3w==
X-Gm-Message-State: AOAM533Vd0WNhnpeqnnqWjOIke0eLWniw0UgaAexyiUgxKWUZ9VdVNON AQvSYlcyXdEFCFw4VllMJBzAzv+CQIV7pG99sIBLXw==
X-Google-Smtp-Source: ABdhPJwcWGlaS/CVJbVxtlup+GjvyBMjmfGkh71JH93qe1MyIqq/zKmot1N6GCbC4XKOeS4h+WbZYPbwE0BKPNDYT3s=
X-Received: by 2002:a6b:2cc1:: with SMTP id s184mr7467668ios.63.1639597281254; Wed, 15 Dec 2021 11:41:21 -0800 (PST)
MIME-Version: 1.0
References: <163733688535.10662.12846915795187697217@ietfa.amsl.com> <0100017d487f0f15-c299535d-2006-4dde-9b36-4799849666c0-000000@email.amazonses.com> <BY5PR11MB41964C53DC283350143B6E01B5609@BY5PR11MB4196.namprd11.prod.outlook.com> <0100017d4d608976-11759577-0c2e-4efb-bc34-3da1d8ad2bcb-000000@email.amazonses.com>
In-Reply-To: <0100017d4d608976-11759577-0c2e-4efb-bc34-3da1d8ad2bcb-000000@email.amazonses.com>
From: Warren Kumari <warren@kumari.net>
Date: Wed, 15 Dec 2021 14:40:45 -0500
Message-ID: <CAHw9_iJfFDoyD3uXpm-GWACP5_m8kL6FZ+H2iK3eY6rX9qY23Q@mail.gmail.com>
To: Kent Watsen <kent@watsen.net>
Cc: "Rob Wilton (rwilton)" <rwilton=40cisco.com@dmarc.ietf.org>, Dan Romascanu <dromasca@gmail.com>, "last-call@ietf.org" <last-call@ietf.org>, "ops-dir@ietf.org" <ops-dir@ietf.org>, "draft-ietf-netconf-sztp-csr.all@ietf.org" <draft-ietf-netconf-sztp-csr.all@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000008635ca05d3347d9f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/3if19R0b0kS3c4BQ8kyxBhhcZKw>
Subject: Re: [netconf] [Last-Call] Opsdir last call review of draft-ietf-netconf-sztp-csr-11
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Dec 2021 19:41:29 -0000

Just a quick note to say thanks to the Dan, the authors and Rob -- this has
improved the document.
W

On Tue, Nov 23, 2021 at 10:18 AM Kent Watsen <kent@watsen.net> wrote:

> Hi Rob,
>
> Thank you for your input.  Please see below for responses to your comments.
>
> Kent
>
>
>
> Which option seems best?  Does anyone have. preference?
>
> I don’t think that we should do (1).  If the industry widely understands
> IDevID/LDevID to mean 802.1AR then redefining it in this draft to have a
> wider meaning could just be confusing to readers.
>
>
> Agreed.
>
>
> So I think that the draft has broadly got this right in its current
> approach, but I would propose also extending that to the YANG module
> descriptions.
>
>
> Agreed.
>
>
>
> Specifically, I would suggest adding a version of this paragraph to the
> end of the descriptions of cmc-csr and cmp-csr, which already have quite
> long descriptions, so the extra paragraph shouldn’t really be a problem.
>
>
>         The terms 'IDevID' and 'LDevID' are used herein to
>
>         mean 'initial device identifier' and 'local device
>
>         identifer'.  These terms are defined consistent with
>
>         the IEEE 802.1AR specification, though there is no
>
>         requirement that a ZTP-client's identity certificate
>
>         conform to IEEE 802.1AR.
>
>
>
> Yikes!   After sending the response to Dan, I decided on option 2
> (expanding all the IDevID/LDevID usages).  In my response to Yaron
> yesterday I wrote:
>
> We updated the YANG module to greatly remove references to IDevID/LDevID.
>
> Specifically:
> 1) s/IDevID/initial device identity certificate/g
> 2) s/LDevID/local device identity certificate/g
> 3) manually rewrap lines to col 69 as required
> 4) removed the terminology-disclaimer block at top
>
> The diff is here:
> https://github.com/netconf-wg/sztp-csr/commit/ac35f96eec96528dddf5798d528d9874a85c604b
>
> Good?
>
> This isn’t what you suggest, but it’s quite good, maybe better?   Your
> approach seems like it would’ve been more convenient but, given that it is
> what it is now, are you okay with the current edit?  [PS: I haven’t posted
> an updated draft yet as I’m waiting to complete the reviews with Yaron and
> Dan first]
>
>
> I would suggest changing the description in cert-req-info to “(e.g., an
> IDevID from IEEE 802.1AR)”
>
>
>
> Done!
> https://github.com/netconf-wg/sztp-csr/commit/45ace9b40eedabb84e10607592d29146cb54a9c9
>
>
> Rob
>
>
> K.
>
>
>
>
>
>

-- 
The computing scientist’s main challenge is not to get confused by the
complexities of his own making.
  -- E. W. Dijkstra