Re: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-sztp-csr-12: (with COMMENT)

Russ Housley <housley@vigilsec.com> Thu, 23 December 2021 18:17 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A2EE3A085B for <netconf@ietfa.amsl.com>; Thu, 23 Dec 2021 10:17:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tJht8O73fgq1 for <netconf@ietfa.amsl.com>; Thu, 23 Dec 2021 10:17:33 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2483C3A0845 for <netconf@ietf.org>; Thu, 23 Dec 2021 10:17:33 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 354BC300C75 for <netconf@ietf.org>; Thu, 23 Dec 2021 13:12:25 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0JN_6wjHXxap for <netconf@ietf.org>; Thu, 23 Dec 2021 13:12:23 -0500 (EST)
Received: from a860b60074bd.fios-router.home (pool-141-156-161-153.washdc.fios.verizon.net [141.156.161.153]) by mail.smeinc.net (Postfix) with ESMTPSA id D76B6300B9D; Thu, 23 Dec 2021 13:12:22 -0500 (EST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <20211222223214.GT11486@mit.edu>
Date: Thu, 23 Dec 2021 13:12:18 -0500
Cc: Kent Watsen <kent@watsen.net>, IESG <iesg@ietf.org>, draft-ietf-netconf-sztp-csr@ietf.org, "netconf-chairs@ietf.org" <netconf-chairs@ietf.org>, "netconf@ietf.org" <netconf@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0ED98E8C-611D-4303-9F1D-BDC1EAFD73AA@vigilsec.com>
References: <163952699208.6437.8936066509149136808@ietfa.amsl.com> <0100017dde220d3d-4be5f8d7-c4a8-4f45-81d9-0c80bfac77a2-000000@email.amazonses.com> <20211222223214.GT11486@mit.edu>
To: Ben Kaduk <kaduk@mit.edu>
X-Mailer: Apple Mail (2.3445.104.21)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/4UdAnqAaxtqnC4nk2JtVPy2qtq4>
Subject: Re: [netconf] Benjamin Kaduk's No Objection on draft-ietf-netconf-sztp-csr-12: (with COMMENT)
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Dec 2021 18:17:35 -0000

Ben:

Responding to just one comment in this message ...

>>>               TaggedContentInfo and it includes a bodyPartID element
>>>               and a contentInfo.  The contentInfo is a SignedData
>>>               encapsulating a PKIData with one reqSequence element
>>>               and no cmsSequence or otherMsgSequence elements. The
>>>               reqSequence is the TaggedRequest and it is the tcr
>>>               CHOICE. The tcr is the TaggedCertificationRequest and
>>>               it a bodyPartId and the certificateRequest elements.
>>>               [...]
>>> 
>>> ... since this reqSequence seems to refer to the PKIData inside the
>>> SignedData in the contentInfo in the cmsSequence.  Should we say
>>> anything about the presence/absence of reqSequence in the toplevel
>>> PKIData (since we do in the other two cases)?
>> 
>> Yes, the authors propose:
>> 
>> OLD: […]
>> 
>> NEW:   PKIData contains one cmsSequence element and no
>>            controlSequence, reqSequence, or otherMsgSequence
>>            elements. […]
>> 
>> 
>> Good?
> 
> I don't think we mention controlSequence anywhere else at present (though
> it is mentioned in the "NEW" text above).  I don't think the omission
> seemed noteworthy when I was doing my original review, so my primary
> consideration here is just that we give it consistent treatment everywhere
> (in terms of whether or not we mention it).

When looking at the text to address your comment, I could see not a role for controlSequence in this situation; however, I think there might possibly be a role in some of the other places.  For that reason, I thik it should be allowable in other places.  That is, the text should not exclude it.  If for consistency, you would rather not exclude controlSequence anywhere, I am fine with that too.

Russ