[Netconf] Yangdoctors last call review of draft-ietf-netconf-netconf-client-server-04

Andy Bierman <andy@yumaworks.com> Fri, 28 July 2017 22:15 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Andy Bierman <andy@yumaworks.com>
To: yang-doctors@ietf.org
Cc: draft-ietf-netconf-netconf-client-server.all@ietf.org, netconf@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <150128014698.20632.18031909095903441241@ietfa.amsl.com>
Date: Fri, 28 Jul 2017 15:15:46 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/LAOGs6u1AktzAHMmgTMMTMimZyc>
Subject: [Netconf] Yangdoctors last call review of draft-ietf-netconf-netconf-client-server-04

Reviewer: Andy Bierman
Review result: Ready with Nits

Review: draft-ietf-netconf-netconf-client-server-04

Modules:
 (M1) ietf-netconf-client@2017-07-03.yang
 (M2) ietf-netconf-server@2017-07-03.yang


YANG Usage:

 I did not find anything wrong in either module.
 pyang and yangdump-pro do not report any errors or warnings.

Comments:

C1:

 (M1) feature ssh-initiate
 (M1) feature ssh-listen
 (M2) feature ssh-listen
 (M2) feature ssh-call-home

 Are these features really needed since a NETCONF server MUST support
 the SSH transport?

C2:

Sec 1.2 Tree Diagrams

Old text should be replaced with reference to
draft-ietf-netmod-yang-tree-diagrams-01

C3: Sec 2.1:

Should use the new version of pyang that expands leafref nodes
in tree diagrams.

C4:

 (M1) IETF copyright says 2014; change to 2017
 (M2) IETF copyright says 2014; change to 2017

[Netconf] Yangdoctors last call review of draft-i… Andy Bierman
Re: [Netconf] Yangdoctors last call review of dra… Kent Watsen