Re: [Netconf] Inconsistency in Section 1.4 of draft-ietf-netconf-restconf-18

Martin Bjorklund <mbj@tail-f.com> Thu, 15 December 2016 20:45 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ED796129446 for <netconf@ietfa.amsl.com>; Thu, 15 Dec 2016 12:45:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.797
X-Spam-Level:
X-Spam-Status: No, score=-4.797 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-2.896, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AmSchMDMuiIh for <netconf@ietfa.amsl.com>; Thu, 15 Dec 2016 12:45:43 -0800 (PST)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 719BB126CD8 for <netconf@ietf.org>; Thu, 15 Dec 2016 12:45:43 -0800 (PST)
Received: from localhost (h-13-76.a165.priv.bahnhof.se [155.4.13.76]) by mail.tail-f.com (Postfix) with ESMTPSA id 557EA1AE018B; Thu, 15 Dec 2016 21:45:42 +0100 (CET)
Date: Thu, 15 Dec 2016 21:45:42 +0100
Message-Id: <20161215.214542.1421958322980601199.mbj@tail-f.com>
To: andy@yumaworks.com
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <CABCOCHSymT-3iyDUNnya8o+dCTZuHNMn04fT+rctTKN87LdRSg@mail.gmail.com>
References: <20161215.124711.2216477344616156120.mbj@tail-f.com> <19D8E110-ADA3-4652-9338-D8136511690D@juniper.net> <CABCOCHSymT-3iyDUNnya8o+dCTZuHNMn04fT+rctTKN87LdRSg@mail.gmail.com>
X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset="utf-8"
Content-Transfer-Encoding: base64
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/RDWbS5V_wG_8tqYP2ymfjaHTo1U>
Cc: netconf@ietf.org, rfc-editor@rfc-editor.org
Subject: Re: [Netconf] Inconsistency in Section 1.4 of draft-ietf-netconf-restconf-18
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Network Configuration WG mailing list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Dec 2016 20:45:45 -0000

Andy Bierman <andy@yumaworks.com> wrote:
> On Thu, Dec 15, 2016 at 9:55 AM, Kent Watsen <kwatsen@juniper.net> wrote:
> 
> >
> >
> > "Mehmet Ersue" <mersue@gmail.com> wrote:
> > > Dear NETCONF WG,
> > >
> > > RFC Editor found an inconsistency in Section 1.4 of
> > > draft-ietf-netconf-restconf-18, where paragraph 6 says:
> > >
> > >    "If the NETCONF server is expecting a
> > >    "persist-id" parameter to complete the confirmed commit procedure
> > >    then the RESTCONF edit operation MUST fail with a "409 Conflict"
> > >    status-line.  There error-tag "in-use" is returned in this case.  The
> > >    error-tag value "resource-denied" is used in this case."
> > >
> > > Myself as the document shepherd and the authors agreed to use the
> > error-tag
> > > value "invalid value" to align with the operations <cancel-commit> and
> > > <commit> in RFC 6241.
> > > The correction will be done as below:
> > >
> > > OLD:
> > >    There error-tag "in-use" is returned in this case.  The
> > >    error-tag value "resource-denied" is used in this case.
> > >
> > > NEW:
> > >       The error-tag value "invalid-value" is used in this case.
> > >
> > > Please speak up within 2 days if you have a strong objection.
> >
> > I don't think invalid-value is appropriate.  It signals that the
> > client provided an invalid value for some parameter, but that's not
> > true in this case - there is nothing the client can do in order to fix
> > the situation.  I prefer to use 'resource-denied' (which is actually
> > what Mehmet suggested).
> >
> >
> >
> > What do NETCONF servers return when no persist-id is passed even though
> > one is needed?  RFC 6241 isn’t clear.   RFC 6241 seems to only speak to
> > when the wrong persist-id is passed.  Either case, RESTCONF SHOULD return
> > the same error-tag value that a NETCONF server returns for these cases,
> > right?

Agreed, but as you note RFC 6241 is not clear on the topic.

> Our server returns 'in-use'

Our does that as well.


Actually, the description for in-use says:

   Description:    The request requires a resource that already is in
                   use.

which matches this case fairly well.

resource-denied means something else:

   Description:    Request could not be completed because of
                   insufficient resources.


So, in-use is probably better.


/martin