Re: [netconf] Tsvart early review of draft-ietf-netconf-udp-notif-11

tuexen@fh-muenster.de Fri, 17 November 2023 08:52 UTC

Return-Path: <tuexen@fh-muenster.de>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32235C151524; Fri, 17 Nov 2023 00:52:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yy0SF2jheLki; Fri, 17 Nov 2023 00:52:44 -0800 (PST)
Received: from mx-out-02.fh-muenster.de (mx-out-02.fh-muenster.de [212.201.120.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F1956C151522; Fri, 17 Nov 2023 00:52:41 -0800 (PST)
Received: from mail-director-01.fh-muenster.de (mail-director-01.fh-muenster.de [185.149.215.227]) by mx-out-02.fh-muenster.de (Postfix) with ESMTPS id 3A648E0F52; Fri, 17 Nov 2023 09:52:39 +0100 (CET)
Received: from smtpclient.apple (ip-109-42-114-72.web.vodafone.de [109.42.114.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tuexen) by mail-director-01.fh-muenster.de (Postfix) with ESMTPSA id 93CE91A0064; Fri, 17 Nov 2023 09:52:38 +0100 (CET)
Content-Type: multipart/signed; boundary="Apple-Mail=_C22C745D-79A4-4681-BFEC-11A933ABBBA9"; protocol="application/pkcs7-signature"; micalg="sha-256"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\))
From: tuexen@fh-muenster.de
In-Reply-To: <0DA44491-C18A-4848-AA5B-7B4E81E6C807@gmail.com>
Date: Fri, 17 Nov 2023 09:52:37 +0100
Cc: tsv-art@ietf.org, draft-ietf-netconf-udp-notif.all@ietf.org, netconf@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <8F324146-3BAF-4E6B-AD70-20DB8EE812AB@fh-muenster.de>
References: <170006128089.20545.9787644071978443627@ietfa.amsl.com> <2F7D6971-8A3A-4DCA-824B-3482148FBDEF@gmail.com> <A00B77E0-2D43-4FA3-8646-85EEF5AA3204@fh-muenster.de> <0DA44491-C18A-4848-AA5B-7B4E81E6C807@gmail.com>
To: Mahesh Jethanandani <mjethanandani@gmail.com>
X-Mailer: Apple Mail (2.3774.200.91.1.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/UMnauL4W66N7mRlGiQ0nvVUdDkg>
Subject: Re: [netconf] Tsvart early review of draft-ietf-netconf-udp-notif-11
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Nov 2023 08:52:48 -0000

> On Nov 16, 2023, at 01:37, Mahesh Jethanandani <mjethanandani@gmail.com> wrote:
> 
> 
> 
>> On Nov 15, 2023, at 2:17 PM, tuexen@fh-muenster.de wrote:
>> 
>>> On Nov 15, 2023, at 22:47, Mahesh Jethanandani <mjethanandani@gmail.com> wrote:
>>> 
>>> Hi Michael,
>>> 
>>> Thanks for your review of the document.
>>> 
>>> One of the discussions before the WG was on what the draft calls out as “segmentation”. The draft proposes this solution to deal with UDP packets that are larger than the path MTU, and will result in fragmentation at the IP level. Note, the end application requires that packets be received in sequence and be complete for the application to process. Otherwise, the packet needs to be discarded. Also to note is that there is no retransmission of the frame if the packet is discarded for any reason.
>>> 
>>> Did you have any comments from a transport perspective, on applications that run over UDP, and propose to use fragmentation (segmentation in this draft) and reassembly logic at the application level with no retransmission?
>> Hi Mahesh,
>> 
>> what user message sizes or number of fragments per user message do you expect?
> 
> The discussion was for max-size UDP message - 64K.
I updated the review. Sorry for missing to read the comment in the review request.

If you have further questions, please let me know.

Best regards
Michael
> 
> Thanks
> 
>> 
>> Best regards
>> Michael
>>> 
>>> Thanks.
>>> 
>>>> On Nov 15, 2023, at 7:14 AM, Michael Tüxen via Datatracker <noreply@ietf.org> wrote:
>>>> 
>>>> Reviewer: Michael Tüxen
>>>> Review result: Not Ready
>>>> 
>>>> Major issue:
>>>> Using the suggested protocol results in a high bandwidth using UDP based
>>>> communication. It is really suggested to use some sort of congestion
>>>> control. However, the document arguments that this is not needed, since
>>>> the protocol is used only on "managed networks" as stated in Section 5.1.
>>>> What confuses me is that in Section 6, the document discusses the use
>>>> of the protocol in "open or unsecured" networks. How does this relates
>>>> to "managed networks"? In my understanding, this does not fit. Do you
>>>> really not need some congestion controller?
>>>> I would expect to see some sort of circuit breaker, but have not seen
>>>> a description of it.
>>>> 
>>>> Minor issues:
>>>> * Section 3.2
>>>> I guess all binary fields in the header shown are expected to be transmitted
>>>> and received in network byte order (big endian), but I would prefer to make
>>>> this explicit.
>>>> * Section 3.2
>>>> Is it allowed that the Message ID wraps around? It seems so, but I think it is
>>>> better to make that explicit.
>>>> * Section 4.1
>>>> The length field in the UDP header is limited to 65535 bytes, therefore the
>>>> UDP payload is limited to 65535 - 8 bytes, which is 65527 bytes. This is smaller
>>>> than stated in the first sentence. In addition to that, when using IPv4, the size
>>>> is even 20 bytes smaller, since the IPv6 header contains a 16-bit field holding
>>>> the total length of the IPv4 packet.
>>>> * Section 4.2
>>>> What should happen if the Private Encoding Option is present, but the S-bit is
>>>> not set? What should happen if the S-bit is set, but the Private Encoding Option
>>>> is not present?
>>>> 
>>>> 
>>>> 
>>> 
>>> 
>>> Mahesh Jethanandani
>>> mjethanandani@gmail.com
> 
> 
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com
> 
> 
> 
> 
> 
>