Re: [netconf] New draft: Augmentiton Addition into the IETF-YANG-Library

[Benoit Claise <[e-mail]>]

Hi Jan,

Thanks for your review and comment.
See inline.

On 11/9/2023 6:17 PM, Jan Lindblad (jlindbla) wrote:
> Benoît, WG,
>
> I listened to the presentation in the NETCONF WG, and now I have also 
> read this draft. I think it's ok, even if it does not really provide 
> clients with any new information that they can't access today. Since 
> it is optional for servers to implement, I don't think there are any 
> problems standardizing a module like this. Servers that often 
> participate in use cases where clients find this shortcut to 
> information useful may well choose to implement the augmentation.

>
> If I may be very technical for a moment, I might add that the current 
> definition of the augmentation leaf-list is a bit odd. It is a leafref 
> referring 
> to /yanglib:yang-library/yanglib:module-set/yanglib:module/yanglib:name. 
> In this path there are two keys (module-set/name and 
> module-set/module/name). That means you need two leafrefs to uniquely 
> identify the module, one for each key leaf in the path. Instad of 
> using a leaf-list of leafrefs here, I'd suggest modeling this as a 
> traditional list with two leafref keys to avoid the problem. Other 
> solutions are also possible. Perhaps naming this addition 
> "augmented-by" would also make the contents clearer.
I like the "augmented-by" proposal.
And good advice on the two leafref keys, which we will implement.

Regards, Benoit
>
> Best Regards,
> /jan
>
>
>> On 6 Nov 2023, at 23:02, Benoit Claise 
>> <benoit.claise=[e-mail]> wrote:
>>
>> Dear all,
>>
>> Let me introduce this draft
>>
>>     This document augments the ietf-yang-library in [RFC8525] to provide
>>     the augmentation list. It facilitates the process of obtaining the
>>     entire dependencies of YANG model, by directly querying the server
>>     YANG module.
>>
>> Feedback on this brand new draft (done during the hackathon) is welcome;
>>
>> Regards, Zhuoyao & Benoit
>>
>> -------- Forwarded Message --------
>>
>> A new version of Internet-Draft
>> draft-lincla-netconf-yang-library-augmentation-00.txt has been 
>> successfully
>> submitted by Benoit Claise and posted to the
>> IETF repository.
>>
>> Name: draft-lincla-netconf-yang-library-augmentation
>> Revision: 00
>> Title: Augmentaiton Addition into the IETF-YANG-Library
>> Date: 2023-11-03
>> Group: Individual Submission
>> Pages: 13
>> URL: 
>> https://www.ietf.org/archive/id/draft-lincla-netconf-yang-library-augmentation-00.txt
>> Status: 
>> https://datatracker.ietf.org/doc/draft-lincla-netconf-yang-library-augmentation/
>> HTMLized: 
>> https://datatracker.ietf.org/doc/html/draft-lincla-netconf-yang-library-augmentation
>>
>>
>> Abstract:
>>
>> This document augments the ietf-yang-library in [RFC8525] to provide
>> the augmentation list. It facilitates the process of obtaining the
>> entire dependencies of YANG model, by directly querying the server
>> YANG module.
>>
>> Discussion Venues
>>
>> This note is to be removed before publishing as an RFC.
>>
>> Source for this draft and an issue tracker can be found at
>> https://github.com/Zephyre777/draft-lincla-netconf-yang-library-
>> augmentation.
>>
>>
>>
>> The IETF Secretariat
>>
>>
>>
>> _______________________________________________
>> netconf mailing list
>> [e-mail]
>> https://www.ietf.org/mailman/listinfo/netconf
>