Re: [netconf] [Technical Errata Reported] RFC8040 (6342)

Hi Andy,

The example for plain PATCH in appendix B.2.5 has keys in both the URI and body.
Whereas the example in section 4.6.1 has keys only in the URI.

Clearly one of the examples is wrong.

Best,

Muly

From: netconf [mailto:netconf-bounces@ietf.org] On Behalf Of Andy Bierman
Sent: 23/11/2020 15:03
To: Martin Björklund <mbj+ietf@4668.se>
Cc: Kent Watsen <kwatsen@juniper.net>; Netconf <netconf@ietf.org>; RFC Editor <rfc-editor@rfc-editor.org>
Subject: Re: [netconf] [Technical Errata Reported] RFC8040 (6342)

On Mon, Nov 23, 2020 at 12:37 AM Martin Björklund <mbj+ietf@4668.se<mailto:mbj%2Bietf@4668.se>> wrote:
Hi,

The issue boils down to if list keys are required in a plain patch.
Unfortunately, the RFC doesn't specifucy this.  From a technical pow,
list keys are not necessary.  In fact, if they are present in the
payload, they are redundant (since they are part of the URL) (this is
actually mentioned in the RFC).

Since it isn't clearly specified, I think we must assume that the keys
are not required.  Hence I think that this errata should be rejected.

In a future version of this document, the behaviour should be
clarified.

+1

reject this errata

/martin

Andy

RFC Errata System <rfc-editor@rfc-editor.org<mailto:rfc-editor@rfc-editor.org>> wrote:
> The following errata report has been submitted for RFC8040,
> "RESTCONF Protocol".
>
> --------------------------------------
> You may review the report below and at:
> https://www.rfc-editor.org/errata/eid6342<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.rfc-editor.org%2Ferrata%2Feid6342&data=04%7C01%7Cmuly_i%40rad.com%7C556dc10cce6348d850e808d88fb024e0%7Cf9047108cc2c4e4897a343fad1b3bf9d%7C1%7C0%7C637417333989910693%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Ah8q7Rb9GwOp4Ck6%2FErNLDk92PpSA6KPbnrxJ%2FHYpjc%3D&reserved=0>
>
> --------------------------------------
> Type: Technical
> Reported by: Muly Ilan <muly_i@rad.com<mailto:muly_i@rad.com>>
>
> Section: 4.6.1
>
> Original Text
> -------------
> To replace just the "year" field in the "album" resource (instead of
> replacing the entire resource with the PUT method), the client might
> send a plain patch as follows:
> PATCH /restconf/data/example-jukebox:jukebox/\
> library/artist=Foo%20Fighters/album=Wasting%20Light HTTP/1.1
> Host: example.com<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fexample.com%2F&data=04%7C01%7Cmuly_i%40rad.com%7C556dc10cce6348d850e808d88fb024e0%7Cf9047108cc2c4e4897a343fad1b3bf9d%7C1%7C0%7C637417333989920683%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=R4iqFtnIw%2FktGcQd1UzdrY5gT6LYF2cl0q%2BfNg63sWs%3D&reserved=0>
> If-Match: "b8389233a4c"
> Content-Type: application/yang-data+xml
> <album xmlns="http://example.com/ns/example-jukebox<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fexample.com%2Fns%2Fexample-jukebox&data=04%7C01%7Cmuly_i%40rad.com%7C556dc10cce6348d850e808d88fb024e0%7Cf9047108cc2c4e4897a343fad1b3bf9d%7C1%7C0%7C637417333989920683%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=T8NtFORUGSRk6HjN%2F382U0vkB%2FVF%2FJ5YvKDkBMETFuA%3D&reserved=0>">
> <year>2011</year>
> </album>
>
> Corrected Text
> --------------
> To replace just the "year" field in the "album" resource (instead of
> replacing the entire resource with the PUT method), the client might
> send a plain patch as follows:
> PATCH /restconf/data/example-jukebox:jukebox/\
> library/artist=Foo%20Fighters/album=Wasting%20Light HTTP/1.1
> Host: example.com<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fexample.com%2F&data=04%7C01%7Cmuly_i%40rad.com%7C556dc10cce6348d850e808d88fb024e0%7Cf9047108cc2c4e4897a343fad1b3bf9d%7C1%7C0%7C637417333989930678%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=63TdkWZRnrYaSaHSHMDbAlxHTkIDP4Zu7YPrzn96RgE%3D&reserved=0>
> If-Match: "b8389233a4c"
> Content-Type: application/yang-data+xml
> <album xmlns="http://example.com/ns/example-jukebox<https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fexample.com%2Fns%2Fexample-jukebox&data=04%7C01%7Cmuly_i%40rad.com%7C556dc10cce6348d850e808d88fb024e0%7Cf9047108cc2c4e4897a343fad1b3bf9d%7C1%7C0%7C637417333989930678%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gysKTJN95f59w58%2BNWMVp5ZG6N7V1Ir0m6dL8JG6qI0%3D&reserved=0>">
> <name>Wasting Light</name>
> <year>2011</year>
> </album>
>
> Notes
> -----
> Missing key leaf value in the message-body (<name>Wasting Light</name>)
>
> Instructions:
> -------------
> This erratum is currently posted as "Reported". If necessary, please
> use "Reply All" to discuss whether it should be verified or
> rejected. When a decision is reached, the verifying party
> can log in to change the status and edit the report, if necessary.
>
> --------------------------------------
> RFC8040 (draft-ietf-netconf-restconf-18)
> --------------------------------------
> Title               : RESTCONF Protocol
> Publication Date    : January 2017
> Author(s)           : A. Bierman, M. Bjorklund, K. Watsen
> Category            : PROPOSED STANDARD
> Source              : Network Configuration
> Area                : Operations and Management
> Stream              : IETF
> Verifying Party     : IESG
>
> _______________________________________________
> netconf mailing list
> netconf@ietf.org<mailto:netconf@ietf.org>
> https://www.ietf.org/mailman/listinfo/netconf<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fnetconf&data=04%7C01%7Cmuly_i%40rad.com%7C556dc10cce6348d850e808d88fb024e0%7Cf9047108cc2c4e4897a343fad1b3bf9d%7C1%7C0%7C637417333989940676%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=RTyHWObVREumAU3i3pb0Q0c8tJVUEcG1v0D0olUm1LA%3D&reserved=0>