[netconf] more comments on netconf-adaptive-subscription revision -08

Michael Richardson <mcr+ietf@sandelman.ca> Mon, 31 January 2022 14:19 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: netconf@ietfa.amsl.com
Delivered-To: netconf@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D8FD03A3211 for <netconf@ietfa.amsl.com>; Mon, 31 Jan 2022 06:19:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=sandelman.ca
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89t7NUSA-ZN4 for <netconf@ietfa.amsl.com>; Mon, 31 Jan 2022 06:18:56 -0800 (PST)
Received: from tuna.sandelman.ca (tuna.sandelman.ca [IPv6:2607:f0b0:f:3:216:3eff:fe7c:d1f3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EEBA3A3208 for <netconf@ietf.org>; Mon, 31 Jan 2022 06:18:55 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by tuna.sandelman.ca (Postfix) with ESMTP id 973AB38F2E for <netconf@ietf.org>; Mon, 31 Jan 2022 09:25:59 -0500 (EST)
Received: from tuna.sandelman.ca ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9iciFVZJxNk6 for <netconf@ietf.org>; Mon, 31 Jan 2022 09:25:58 -0500 (EST)
Received: from sandelman.ca (obiwan.sandelman.ca [209.87.249.21]) by tuna.sandelman.ca (Postfix) with ESMTP id B9E2338F2C for <netconf@ietf.org>; Mon, 31 Jan 2022 09:25:58 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sandelman.ca; s=mail; t=1643639158; bh=v+lwj/36rc8CRsEPi2LUaIQAY62w0ScHHM9AOe73L5Q=; h=Date:Subject:To:References:From:In-Reply-To:From; b=cX89CH8LRPjh/yzRyIcDuKALzIzbdopGwTVkiD7a40++X5PtWNALKKd9yg/kcAJbl wwI3pppGlYBLG1r5OgHPidvjDAL6okJ7ntIWNRsa5tnH4dHAU3YHbkBj8PNn+L2u0K f0wiysFEizF9cI/kKlc7+0fJ/1cu/U+YqJSJZrRSBxh2WtlqDDl4v+tXC591m6tMc/ 91AZrA6QaozCaQosd5buoalse6kt4tSYrdFaA/yyjBKNksyLyBIDgWZoCtIX+fuDHP fytMT8WvhXTbRvaQ9+BDGKHjTe8xukibf8pnYcZyZw024GtM8+IPpt/BdxLFCwzT2U Bjtd09ZhGLn8g==
Received: from [127.0.0.1] (localhost [127.0.0.1]) by sandelman.ca (Postfix) with ESMTP id 540BA1CC for <netconf@ietf.org>; Mon, 31 Jan 2022 09:18:51 -0500 (EST)
Message-ID: <4ce1b723-a3fa-477f-fbca-890770885360@sandelman.ca>
Date: Mon, 31 Jan 2022 09:18:51 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1
Content-Language: en-US
To: netconf@ietf.org
References: <5ba27e43a63e427091f3093b35be09a0@huawei.com> <14286.1624562075@localhost>
From: Michael Richardson <mcr+ietf@sandelman.ca>
In-Reply-To: <14286.1624562075@localhost>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netconf/wSU0Tr7nmnDI9cW22f7R78XNU5Q>
Subject: [netconf] more comments on netconf-adaptive-subscription revision -08
X-BeenThere: netconf@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETCONF WG list <netconf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netconf>, <mailto:netconf-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netconf/>
List-Post: <mailto:netconf@ietf.org>
List-Help: <mailto:netconf-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netconf>, <mailto:netconf-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jan 2022 14:19:01 -0000

On 2021-06-24 15:14, Michael Richardson made some comments on:
> 
> I read:
>          Title           : Adaptive Subscription to YANG Notification
> 	Filename        : draft-wang-netconf-adaptive-subscription-05.txt
> 

I have reviewed a diff from -05 to -08, which you can see at:

https://www.ietf.org/rfcdiff?url1=draft-wang-netconf-adaptive-subscription-05&url2=draft-wang-netconf-adaptive-subscription-08

(I know that we have a new rfcdiff service being tested, but I can't 
recall where it is now)

I found the introduction of section 3, on XPath Evaluation is an 
interesting and welcome new addition.  I can't judge on the content of 
it, but it seems like it is useful things to explain.

leaf watermark {	
  	               type uint32;	
  	               description	
  	                 "The watermark for targeted data object. The higher	
  	                  or lower watermark can be specified for the	
  	                  targeted data object.";	
  	             }

probably this description should explain where the kind of watermark 
(high or low) is actually specified.
I guess that I would never specify both, as that would be just two rules.
Are centiseconds already a typical unit for NETCONF?

I see that you have rewritten the example YANG module for wifi based 
upon the CSA/MATTER data model.  It's good to have a realistic model.
I still wonder why an existing YANG model couldn't have been used.

The text in section B.2 hints that the access point will change not just 
how often it reports, but how often it actually collects the data.
I'm not sure if that is the intention?
I think when it says "server", I think you mean access point?