Re: [Netmod-ver-dt] draft-verdt-netmod-yang-module-versioning: Name of the “label-string” typedef.

["Reshad Rahman (rrahman)" <[e-mail]>]

OK with me.

Regards,
Reshad,

From: Netmod-ver-dt <[e-mail]> on behalf of "Rob Wilton (rwilton)" <[e-mail]>
Date: Monday, September 9, 2019 at 6:41 AM
To: "[e-mail]" <[e-mail]>
Subject: [Netmod-ver-dt] draft-verdt-netmod-yang-module-versioning: Name of the “label-string” typedef.

The type of “revision-label” is currently defined as:

  typedef label-string {
    type string {
      length "1..255";
      pattern '[^\s@]+';
      pattern '\d{4}-\d{2}-\d{2}' {
        modifier invert-match;
      }
    }
    description
      "A label associated with a YANG revision.

       Excludes spaces and '@'.  Cannot match revision-date.";
    reference
      "draft-verdt-netmod-yang-module-versioning: Revision label";
  }

  typedef revision-date-or-label {
    type union {
      type revision-identifier;
      type label-string;
    }
    description
      "Represents either a YANG revision date or a revision label";
  }

I think that it might be better to change the name of the typedef “label-string” to “revision-label-string”.

Is this OK?

Thanks,
Rob