Re: [netmod] AD review of draft-ietf-netmod-rfc7223bis-01

Martin Bjorklund <mbj@tail-f.com> Mon, 18 December 2017 14:57 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D44D0124D85 for <netmod@ietfa.amsl.com>; Mon, 18 Dec 2017 06:57:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.011
X-Spam-Level:
X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 tests=[SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id epueYocyH4pK for <netmod@ietfa.amsl.com>; Mon, 18 Dec 2017 06:57:00 -0800 (PST)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 42B65124B17 for <netmod@ietf.org>; Mon, 18 Dec 2017 06:57:00 -0800 (PST)
Received: from localhost (unknown [173.38.220.60]) by mail.tail-f.com (Postfix) with ESMTPSA id CCFEB1AE0311; Mon, 18 Dec 2017 15:56:58 +0100 (CET)
Date: Mon, 18 Dec 2017 15:55:39 +0100 (CET)
Message-Id: <20171218.155539.2007718529213229529.mbj@tail-f.com>
To: bclaise@cisco.com
Cc: netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <4f4df77e-c88e-502d-56b0-5007e93a854f@cisco.com>
References: <4f4df77e-c88e-502d-56b0-5007e93a854f@cisco.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/-QyMLC2p7H3u_NoMjGn_WqiZZug>
Subject: Re: [netmod] AD review of draft-ietf-netmod-rfc7223bis-01
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Dec 2017 14:57:02 -0000

Benoit Claise <bclaise@cisco.com>; wrote:
> Dear all,
> 
> In order not to be the bottleneck in the process, here is my AD review
> of draft-ietf-netmod-rfc7223bis-01
> <https://datatracker.ietf.org/doc/draft-ietf-netmod-rfc7223bis/>
> 
> Editorial:
> 
> -
>    An interface is identified by its name, which is unique within the
>    server.  This property is captured in the "interface-ref"_and_
>    typedef, which other YANG modules SHOULD use when they need to
>    reference an interface.
> 
> NEW:
>    An interface is identified by its name, which is unique within the
>    server.  This property is captured in the "interface-ref"
>    typedef, which other YANG modules SHOULD use when they need to
>    reference an interface.

Ok, now fixed.


> 
> -
>    Note that NETCONF and SNMP may
>    differ in the time granularity in which they provide access to the
>    counters.
> 
> I guess we want to remove the reference to NETCONF?
> Proposal:
>    Note the server that implements the YANG module and the SNMP Agent may
>    differ in the time granularity in which they provide access to the
>    counters.

Ok, fixed.

>  -
> We want to mention that "or:" comes from "ietf-origin@2017-08-17.yang";
> in draft-ietf-netmod-revised-datastores

I added:

  This example uses the "origin" annotation, which is defined in the
  module "ietf-origin" [I-D.ietf-netmod-revised-datastores].


(I added this text to rfc7277bis as well).



/martin


> 
> <rpc-reply
>        xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"
>        message-id="101">
>      <data>
>        <interfaces
>            xmlns="urn:ietf:params:xml:ns:yang:ietf-interfaces"
>            xmlns:ianaift="urn:ietf:params:xml:ns:yang:iana-if-type"
>            xmlns:vlan="http://example.com/vlan"
>            xmlns:or="urn:ietf:params:xml:ns:yang:ietf-origin">
> 
>          <interface or:origin="or:intended">
>            <name>eth0</name>
>            <type>ianaift:ethernetCsmacd</type>
>            <enabled>false</enabled>
>            <admin-status>down</admin-status>
>            <oper-status>down</oper-status>
>            <if-index>2</if-index>
>            <phys-address>00:01:02:03:04:05</phys-address>
>            <statistics>
>              <discontinuity-time>
>                2013-04-01T03:00:00+00:00
>              </discontinuity-time>
>              <!-- counters now shown here -->
>            </statistics>
>          </interface>
> 
> Regards, Benoit (as OPS AD)
>