Re: [netmod] New Version Notification for draft-ietf-netmod-factory-default-10.txt

Kent Watsen <kent+ietf@watsen.net> Mon, 10 February 2020 15:38 UTC

Return-Path: <010001702fc09a71-4c62925a-1d46-4163-9157-866d574d96c4-000000@amazonses.watsen.net>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79AFB120255 for <netmod@ietfa.amsl.com>; Mon, 10 Feb 2020 07:38:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=amazonses.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l8Aqo3L05aBo for <netmod@ietfa.amsl.com>; Mon, 10 Feb 2020 07:38:38 -0800 (PST)
Received: from a48-93.smtp-out.amazonses.com (a48-93.smtp-out.amazonses.com [54.240.48.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1A9FC120232 for <netmod@ietf.org>; Mon, 10 Feb 2020 07:38:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1581349116; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:Feedback-ID; bh=DUpNOyGA/Ket6pbm4ajL5HpK2AR21g/Bv4qApWPw3C0=; b=STOB5ur48pdyr5z7pgeenYhmv7ihHvxRmIZUpZBgWEiuK+nG0ifdqijSOVcuVc2v PBXwF2IUKeBVL/7bJCWYofHDefT76ZqgkvMwnsCswA0iqkflmP4rGSgIxdv0DWus+Mn NTrA8VmJxsRarbVmw5cRA6Ku68OuXq1RDUjHHSvQ=
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
From: Kent Watsen <kent+ietf@watsen.net>
In-Reply-To: <B8F9A780D330094D99AF023C5877DABAA9651B70@dggeml511-mbx.china.huawei.com>
Date: Mon, 10 Feb 2020 15:38:36 +0000
Cc: "netmod@ietf.org" <netmod@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-ID: <010001702fc09a71-4c62925a-1d46-4163-9157-866d574d96c4-000000@email.amazonses.com>
References: <B8F9A780D330094D99AF023C5877DABAA9651B70@dggeml511-mbx.china.huawei.com>
To: Qin Wu <bill.wu@huawei.com>
X-Mailer: Apple Mail (2.3445.104.11)
X-SES-Outgoing: 2020.02.10-54.240.48.93
Feedback-ID: 1.us-east-1.DKmIRZFhhsBhtmFMNikgwZUWVrODEw9qVcPhqJEI2DA=:AmazonSES
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/DK3DIQMCyB5KQhFoIUz_CIZwsT8>
Subject: Re: [netmod] New Version Notification for draft-ietf-netmod-factory-default-10.txt
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Feb 2020 15:38:40 -0000

Thanks for the update, Qin.

BTW, my previous email to the “netmod” list did not get reflected back to me, and I don’t see either of out emails in the archives, so there is a chance that we’re having this conversation in isolation, even though “netmod” is CC-ed….

Regardless, looking at the diffs, I have the following comments:

- I’m not happy with the new “factory-default” term.  Please remove it and review all uses of “factory-default” to see if they should be “factory default” (without the hyphen).  Again, the hyphen should only be used when referring to the YANG node; in all other cases it should not be hyphenated.  Please beware that I see I the diff you made an attempt to hyphenate a number of instances of what should be “factory default”.  Please undo all these.  Again, the hyphen should only be present when referring to the YANG node, otherwise the hyphen should not be present.

- In Section 2, replace ", and logs (e.g., /var/log), temporary files (e.g., /tmp/*)” with ", logs (e.g., /var/log), and temporary files (e.g., /tmp/*).”  That is, move the “and” to the end...

- In the YANG module, you must’ve copy/pasted the description incompletely…please add the last stanza from my previous email (“i.e., beginning with “and”) to "This module defines an RPC called 'factory-reset', a datastore identity called 'factory-default-datastore’”.

- in Section 6:

  a) s/sensitive in and therefore/sensitive and therefore//
  b) s/default- deny-all/default-deny-all/
  c) s/in . [RFC8341]/in [RFC8341]./


Kent // as Shepherd


> On Feb 9, 2020, at 11:28 PM, Qin Wu <bill.wu@huawei.com> wrote:
> 
> The v-10 is posted to address comments raised in Shepherd document review.
> The diff is:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-netmod-factory-default-10
> 
> -Qin
> -----邮件原件-----
> 发件人: internet-drafts@ietf.org [mailto:internet-drafts@ietf.org] 
> 发送时间: 2020年2月10日 12:26
> 收件人: Niuye <niuye@huawei.com>; Qin Wu <bill.wu@huawei.com>; Qin Wu <bill.wu@huawei.com>; Balazs Lengyel <balazs.lengyel@ericsson.com>
> 主题: New Version Notification for draft-ietf-netmod-factory-default-10.txt
> 
> 
> A new version of I-D, draft-ietf-netmod-factory-default-10.txt
> has been successfully submitted by Qin Wu and posted to the IETF repository.
> 
> Name:		draft-ietf-netmod-factory-default
> Revision:	10
> Title:		Factory Default Setting
> Document date:	2020-02-09
> Group:		netmod
> Pages:		11
> URL:            https://www.ietf.org/internet-drafts/draft-ietf-netmod-factory-default-10.txt
> Status:         https://datatracker.ietf.org/doc/draft-ietf-netmod-factory-default/
> Htmlized:       https://tools.ietf.org/html/draft-ietf-netmod-factory-default-10
> Htmlized:       https://datatracker.ietf.org/doc/html/draft-ietf-netmod-factory-default
> Diff:           https://www.ietf.org/rfcdiff?url2=draft-ietf-netmod-factory-default-10
> 
> Abstract:
>   This document defines a method to reset a server to its factory-
>   default content.  The reset operation may be used, e.g., when the
>   existing configuration has major errors so re-starting the
>   configuration process from scratch is the best option.
> 
>   A new factory-reset RPC is defined.  When resetting a device, all
>   previous configuration settings will be lost and replaced by the
>   factory-default content.
> 
>   A new optional "factory-default" read-only datastore is defined, that
>   contains the factory default configuration for the device.
> 
> 
> 
> 
> Please note that it may take a couple of minutes from the time of submission until the htmlized version and diff are available at tools.ietf.org.
> 
> The IETF Secretariat
>