IETF Logo Mail Archive

Re: [netmod] warn: Module's revisions are not unique (2018-06-28).

Andy Bierman <andy@yumaworks.com> Wed, 17 March 2021 18:47 UTC

Return-Path: <andy@yumaworks.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BD4BE3A1165 for <netmod@ietfa.amsl.com>; Wed, 17 Mar 2021 11:47:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.887
X-Spam-Level:
X-Spam-Status: No, score=-1.887 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=yumaworks-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XpZ7J3BoQGhD for <netmod@ietfa.amsl.com>; Wed, 17 Mar 2021 11:47:57 -0700 (PDT)
Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB4783A1164 for <netmod@ietf.org>; Wed, 17 Mar 2021 11:47:56 -0700 (PDT)
Received: by mail-lf1-x12c.google.com with SMTP id x28so489067lfu.6 for <netmod@ietf.org>; Wed, 17 Mar 2021 11:47:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yumaworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R8RyjXXsv+GckTpZed92bsAN8ArH+uromY5On8r31Ak=; b=aRdCL1l0O8rMP8aHSo2Z//VlS+xImUYbz5DzwVXOOcmszC5jArxNax90aYkw8k5rzd kG6wh2PfBGPjx5C8HTD5g6QcAreBEFR8hQExo1l3MMy5FurpYpT98q2rwpVHdoRLwaON BsqEAUAYC2f/8AXiLnJBu2ZGiv9E0bo46J242y1C+GRBys8a/rTlfbf6/OoVbT/1CmK3 nsgxrdDPFwUXpN/OHlkfhgaMZe56jOa0LNHF0t8S2/9/AHqr9BOVG56W2Fpr1ZiL+4Zy 3Nct4d0nvPJgwBnycJuTXZ1b4ZVYJkXDPPzpYWyvrQUqn9ItnT1mHCu/iLvSWU24iugf XSiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R8RyjXXsv+GckTpZed92bsAN8ArH+uromY5On8r31Ak=; b=XT/Fz1YsKpIR8P297nZtZIJbTzgyXkN4SbfUmHOAZndqd8VvRRRoZ0uPs/nzMKtOXP J2G7IFJLVa78IOjClWCtZ7cpadWQpq9FDWOK2Y01gTI74kSkCPmpFJ0/WuEQBcbaE3kC kME9cAiRUPoakJVZ9NFjcsRz4QPzoiFPP+gMUwZoOzlQ+VZY7CCsubbhO/1Ozyiq4TYC uvHg3W5rHeKxFgQCRzt+j6BXf0J1DZFvOv8yrJ40e/Cqw0U2/NYjiTvZ4GCtk+t4s4HV iEDMmrrCt7l1tYvnkhEGPp9JiSsp5n6ZjPBg3RLlRC5O2XqmWrhR8rYwflwJSfjbtPeb spIg==
X-Gm-Message-State: AOAM531FKN3bscM9rNMC9fYpcQA+rwYU2R/4IN+T6GaSyqYKzAz9K9r/ +DkAUj/37UuTx/pc4izKDZCDARXNk+ElHWquzHRiQIJzSwGQww==
X-Google-Smtp-Source: ABdhPJx0RTyQ+TTQUdU8ZwhonHpJle5N6C+oZJoFekxSloyySFLZcN6NP2K20nE0amuURK0/tLfefuyPe5f16lygkik=
X-Received: by 2002:ac2:434d:: with SMTP id o13mr2977002lfl.478.1616006874860; Wed, 17 Mar 2021 11:47:54 -0700 (PDT)
MIME-Version: 1.0
References: <0713027c-3716-11f3-9a6f-69b7dff60916@lightside-instruments.com> <13cdc883-3d57-ad5a-1fa6-7c2802d4aae4@lightside-instruments.com> <CABCOCHT6Jx4RRYCrg7FdL_8s6_aSc13h83e0Go0QL5Rz8UWWZQ@mail.gmail.com> <CAEe_xxhuZRZ2i-TkOPL+EwhujAX2mqSWCOEpiW6oPOBv9EJnqA@mail.gmail.com>
In-Reply-To: <CAEe_xxhuZRZ2i-TkOPL+EwhujAX2mqSWCOEpiW6oPOBv9EJnqA@mail.gmail.com>
From: Andy Bierman <andy@yumaworks.com>
Date: Wed, 17 Mar 2021 11:47:44 -0700
Message-ID: <CABCOCHQKb5TSC3_=BtRqe9X=_VxfwDAhyg9e0arikAa59ZKXPA@mail.gmail.com>
To: William Lupton <wlupton@broadband-forum.org>
Cc: Vladimir Vassilev <vladimir@lightside-instruments.com>, "netmod@ietf.org" <netmod@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000bb224305bdbfebe4"
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/DuomyP6yOmwly69KXreZkgHXGso>
Subject: Re: [netmod] warn: Module's revisions are not unique (2018-06-28).
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Mar 2021 18:47:59 -0000

On Wed, Mar 17, 2021 at 11:36 AM William Lupton <wlupton@broadband-forum.org>
wrote:

> Also note that the YANG catalog keys modules by (name, revision,
> organization).
>

This 3rd key implies that some organizations have their own versions of
YANG modules from SDOs.
We have a bit of that only to fix known Errara in some IETF modules.
YANG has deviations so vendors can change the modules from other
organizations
without hacking the original modules.


Andy



> On Wed, 17 Mar 2021 at 18:21, Andy Bierman <andy@yumaworks.com> wrote:
>
>>
>>
>> On Wed, Mar 17, 2021 at 8:36 AM Vladimir Vassilev <
>> vladimir@lightside-instruments.com> wrote:
>>
>>>
>>> On 16/03/2021 13.36, Vladimir Vassilev wrote:
>>> > Hei,
>>> >
>>> > Many drafts and RFCs are flagged with warnings by the tracker
>>> > validation tools:
>>> >
>>> > ...
>>> > yanglint SO 1.6.7: yanglint --verbose -p {tmplib} -p {rfclib} -p
>>> > {draftlib} -p {ianalib} -p {cataloglib} {model} -i:
>>> > warn: Module's revisions are not unique (2018-06-28).
>>> >
>>> > ...
>>> >
>>> > Does anyone know what causes this warning?
>>>
>>> Seems the warning is issued when iana-if-type@2020-01-10.yang is
>>> processed. It contains 2 revision (history) statements with identical
>>> dates 2018-06-28.
>>>
>>> IMO Multiple revision statements with the same date are valid so the
>>> tool reporting the warning has to be fixed.
>>>
>>>
>>
>> I disagree.  Our compiler has a similar warning.
>>
>> The YANG Library treats entries with the exact same module name and
>> revision-date as
>> the same module.  The protocols that currently advertise YANG module
>> capabilities
>> all use module name and revision-date to identify a unique module
>> revision.
>>
>> A compiler warning simply means "Are you sure you meant to do this?"
>> This is usually a cut-and-paste error.
>>
>>
>>
>>>
>>> Vladimir
>>>
>>>
>> Andy
>>
>>
>>> _______________________________________________
>>> netmod mailing list
>>> netmod@ietf.org
>>> https://www.ietf.org/mailman/listinfo/netmod
>>>
>> _______________________________________________
>> netmod mailing list
>> netmod@ietf.org
>> https://www.ietf.org/mailman/listinfo/netmod
>>
>

v2.23.0 | Report a Bug | By Email