Re: [netmod] Request to review the YANG compiler annotations draft.

[Martin Bjorklund <[e-mail]>]

"vinods.kumar" <[e-mail]> wrote:
> Dear All,
> 
>     We have written a draft, to add annotation in YANG definition which can
> be used by the YANG compilers.
> 
> We are implementing these drafts as a reference implementation in the IETF
> 96 hackathon on ONOS YANG utilities.
> 
> Request you to review the below drafts and provide your comments/feedback.
> 
> Draft(s):
> https://datatracker.ietf.org/doc/draft-agv-netmod-yang-compiler-metadata/
> 
>  
> https://datatracker.ietf.org/doc/draft-agv-netmod-yang-annotation-ds-and-der
> ived/

I have looked at these drafts.  I have two high-level comments.

  1)  What you propose is not valid YANG.  This new syntax would
      require a new version of the YANG language.

  2)  What you propose is not necessary; it can be done (and is being
      done in several existing implementations) with current YANG
      syntax and semantics, with normal YANG extension statements.

      For example, the draft proposes this:

       list server {
         ca:compiler-annotation{
           @MappedCollection(collection-type='map', map-key='name')
           @OverrideImpl('DefaultServer');
         }
         ...

      It can be done today as:

        list server {
           xx:mapped-collection {
             xx:collection-type map;
             xx:map-key name;
           }
           xx:override-impl DefaultServer;
           ...


/martin