[netmod] kw review of draft-liu-netmod-yang-schedule

Kent Watsen <kwatsen@juniper.net> Mon, 04 April 2016 14:54 UTC

Return-Path: <kwatsen@juniper.net>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2E3FC12D790 for <netmod@ietfa.amsl.com>; Mon, 4 Apr 2016 07:54:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.902
X-Spam-Level:
X-Spam-Status: No, score=-1.902 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=junipernetworks.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H8DKImGi0jlr for <netmod@ietfa.amsl.com>; Mon, 4 Apr 2016 07:54:40 -0700 (PDT)
Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0141.outbound.protection.outlook.com [207.46.100.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D452A12D785 for <netmod@ietf.org>; Mon, 4 Apr 2016 07:54:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-juniper-net; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3sy7xFURWsf57DcUJ85XSG8PQ+ho6AuvMokdk7UMsVc=; b=iobw8iLAPjaSWwaJmONAFwdq/W2td5Jr/c8loXVj6ByLVH0ujs7YMebvaX2CuHzf7fGrV32YPW2hg8pFLyahIuHfH9jF066MCwT2AJXC0l7waquE/a4CdUNg+CqBaOfDL+bwdbRHlMguEdnYYBJ7xhw1edn6DyyylBvYx4oCjEk=
Received: from CY1PR0501MB1450.namprd05.prod.outlook.com (10.160.149.11) by CY1PR0501MB1451.namprd05.prod.outlook.com (10.160.149.12) with Microsoft SMTP Server (TLS) id 15.1.447.15; Mon, 4 Apr 2016 14:54:08 +0000
Received: from CY1PR0501MB1450.namprd05.prod.outlook.com ([10.160.149.11]) by CY1PR0501MB1450.namprd05.prod.outlook.com ([10.160.149.11]) with mapi id 15.01.0447.027; Mon, 4 Apr 2016 14:54:08 +0000
From: Kent Watsen <kwatsen@juniper.net>
To: "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: kw review of draft-liu-netmod-yang-schedule
Thread-Index: AQHRjoHX/KUnGqB1j0+ZVGgEbqY4Mg==
Date: Mon, 04 Apr 2016 14:54:08 +0000
Message-ID: <8DC36161-54BC-435B-B8BA-AA72A153451F@juniper.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/0.0.0.160212
authentication-results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=juniper.net;
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [66.129.241.11]
x-ms-office365-filtering-correlation-id: e9852023-749a-4455-57dd-08d35c98f9ca
x-microsoft-exchange-diagnostics: 1; CY1PR0501MB1451; 5:Gz+tjJ96tJaEx2+UtU/4Vl3lCN48Gv3zyT+sLBomp9Re1S3GUVjwkhE9L6mLzUyN0PdqNP1heLZUNMyU9D9Odd0ulHJ7XXB+EoS8F4psGiflOVzGjMhd7uyuPwP6phePa8TC1p1e0EH4jRtRkZ6OHg==; 24:EX4yxHpv0kBLTrTMDC6Vd3rRyPQE/qoHe/f/fuzQB60Llp60Vgbm8qRMYK7gmotZNsvn8dkoBDgmyd2wFtBVGPl+XRtOoAMGtGRYKEq65Ns=
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0501MB1451;
x-microsoft-antispam-prvs: <CY1PR0501MB145104016960A401CE67D714A59D0@CY1PR0501MB1451.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:;
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:CY1PR0501MB1451; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0501MB1451;
x-forefront-prvs: 0902222726
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(164054003)(3280700002)(77096005)(15975445007)(122556002)(2501003)(54356999)(2906002)(5002640100001)(16236675004)(6116002)(33656002)(586003)(102836003)(10400500002)(3846002)(1730700002)(50986999)(83716003)(2900100001)(83506001)(230783001)(450100001)(5004730100002)(81166005)(3660700001)(5640700001)(110136002)(107886002)(92566002)(189998001)(11100500001)(19580395003)(5008740100001)(86362001)(36756003)(4001350100001)(66066001)(229853001)(82746002)(1096002)(106116001)(1220700001)(2351001)(87936001)(104396002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0501MB1451; H:CY1PR0501MB1450.namprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_8DC3616154BC435BB8BAAA72A153451Fjunipernet_"
MIME-Version: 1.0
X-OriginatorOrg: juniper.net
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2016 14:54:08.3850 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0501MB1451
Archived-At: <http://mailarchive.ietf.org/arch/msg/netmod/Mdm-V3EiMRbJBvBdrWC-YhBdL7E>
Subject: [netmod] kw review of draft-liu-netmod-yang-schedule
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Apr 2016 14:54:43 -0000

[As a contributor]

While it's clear what this document is trying to achieve at a high level, it is unclear why the solution is needed.   A "motivation" section explaining why this should be standardized would be nice.

When reading this draft, I was reminded of my long expired draft https://tools.ietf.org/html/draft-kwatsen-conditional-enablement-00.  That draft provided a more general solution, in that it enabled sub-trees to be enabled/disabled for any reason.  It was primarily focused on supporting comments, but it did call out that expressions could include time, though it didn't flush out that thought to any extent.

Other than draft-kwatsen-conditional-enablement being a more generic solution, another difference is that this draft enables the module-designer to specify where in the data model the grouping is used, whereas my old draft let the client enabled/disabled nodes anywhere in the data model, potentially producing nonsensical results, though we have to assume that the server would fail any invalid results.

Regarding this solution, I have some specific questions:

1) why is the "schedule" node a list?  How is a list to be processed?   Are there any overlapping issues?

2) does the "schedule-id" leaf have any useful purpose other than being the list's key?

3) the "schedule-duration" node's pattern matches XSD's "duration" type, is it the intent to process it as such?

4) the draft-ietf-netconf-server-model draft originally had a duration-like value, but the WG consensus was at the time was to instead use an unsigned integer value with a "units" value (e.g., seconds, minutes, etc.).  The claim was that, when large values where needed (e.g., 3600-seconds instead of 1-hour), that the client could always do the math.  Any thoughts on that?

5) are there any issues with the "repeat-interval" node?  I'm specifically thinking about the interval being expressed in terms of hours and days in the context of daylight savings and leap year...


Nit: some examples in the draft would've been nice.

Thanks,
Kent