Re: [netmod] derived-from-or-self leads to circular import

Martin Bjorklund <mbj@tail-f.com> Fri, 26 August 2016 10:44 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6C20712D60E for <netmod@ietfa.amsl.com>; Fri, 26 Aug 2016 03:44:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.449
X-Spam-Level:
X-Spam-Status: No, score=-2.449 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.548, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bFtfjQyaiYOv for <netmod@ietfa.amsl.com>; Fri, 26 Aug 2016 03:44:58 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id 6AE3912D623 for <netmod@ietf.org>; Fri, 26 Aug 2016 03:44:07 -0700 (PDT)
Received: from localhost (unknown [173.38.220.42]) by mail.tail-f.com (Postfix) with ESMTPSA id 786D31AE018C; Fri, 26 Aug 2016 12:44:05 +0200 (CEST)
Date: Fri, 26 Aug 2016 12:43:04 +0200
Message-Id: <20160826.124304.1561054177442678773.mbj@tail-f.com>
To: j.schoenwaelder@jacobs-university.de
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <20160729133257.GA3317@elstar.local>
References: <D62E05768DBAFF42A72B9F4954476D65010EA9AC29@FR712WXCHMBA09.zeu.alcatel-lucent.com> <20160729133257.GA3317@elstar.local>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/QA_XD9p_LOcb8p0hOZ3pQM_4-II>
Cc: netmod@ietf.org
Subject: Re: [netmod] derived-from-or-self leads to circular import
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Aug 2016 10:44:59 -0000

Juergen Schoenwaelder <j.schoenwaelder@jacobs-university.de> wrote:
> On Fri, Jul 29, 2016 at 12:50:13PM +0000, Bogaert, Bart (Nokia - BE) wrote:
> 
> [...]
>  
> > In order to correctly compile (using confdc) we also need to import
> > iana-entity for the identities defined in there.  However this is leading a
> > circular dependency:
> > 
> > 1.       Iana-entity imports ietf-entity (to 'resolve'
> > entity-physical-class)
> > 
> > 2.       Ietf-entity imports iana-entity (to obtain the indentities defined
> > in there)
> > 
> > One way to solve this is to move the definition of entity-physical-class
> > from ietf-entity to iana-entity which would resolve the fact that
> > iana-entity requires an import of ietf-entity (ietf-entity needs to import
> > iana-entity anyhow, so it can also pick the typedef from the same module
> > too).
> 
> I think moving the definition of entity-physical-class into
> iana-entity makes sense.

Ok.  It feels a bit backwards to me though, but I can see the value of
having the iana module self-contained.


/martin


> Perhaps this is generally a good pattern to
> follow for base identities for which IANA maintains derived
> identities.  The required import should not be a problem; the
> ENTITY-MIB also imports from IANA-ENTITY-MIB.