[netmod] yang-instance-file-format-10 uploaded [was: RE: WG Last Call: draft-ietf-netmod-yang-instance-file-format-06 to -07]

Balázs Lengyel <balazs.lengyel@ericsson.com> Fri, 20 March 2020 16:45 UTC

Return-Path: <balazs.lengyel@ericsson.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E81A3A0CCE for <netmod@ietfa.amsl.com>; Fri, 20 Mar 2020 09:45:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.101
X-Spam-Level:
X-Spam-Status: No, score=-2.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uFYYq9Q6DO2k for <netmod@ietfa.amsl.com>; Fri, 20 Mar 2020 09:45:26 -0700 (PDT)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03on0610.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0a::610]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 33D643A0CBD for <netmod@ietf.org>; Fri, 20 Mar 2020 09:45:25 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; =?utf-8?q?b=3DgVLEIshf3CrVEIdbDBdiUX+hDzfvX8OuXrg6YiKWYFiQ+dtZy8bRBaINHgUCr?= =?utf-8?q?Vf5iZj8Ugoy0EwldDazwJYkjVtfXVCQitozz/5LzJbYRS4JbD/mFR4YboyYsVQc51?= =?utf-8?q?25hqg5eH5SvzI1i+yoj0nycFXjaQH2YtwnhsYw/qwqKLWOwTzmJ6RUh66zTCcPN4W?= =?utf-8?q?zJ4iuIVPXX2S1xN2J7RNxi66TWi/0r/XDz6lXeKkiNfa8hVE6ZQHRhjJLh7b32xxK?= =?utf-8?q?4JjW6iTIPV3x1mCV3jwLLyPeMh6FSm5BsNSVrmiVcDSniv1QGOxhWd1waAZ/yBq8B?= =?utf-8?q?J58XGrMYnOryuaQx0iYJw=3D=3D?=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; =?utf-8?q?h=3DFrom=3ADate=3ASubject=3AMessage-ID=3ACont?= =?utf-8?q?ent-Type=3AMIME-Version=3AX-MS-Exchange-SenderADCheck=3B?= =?utf-8?q?bh=3Db//fiwCTZGbNBFm3FA5O2VatHtshWyHZzcbU/KTY9UI=3D=3B_b=3DHoVZ4O?= =?utf-8?q?ofEnwnMV15qsSkM9KIGUPYYXNAMY8U3iNJ6o2oVC7GVYY/KiYX0OzNabysDPiE9Xm?= =?utf-8?q?HEjw56Q2VYWcTF4w+3KF5Tcvd4PeAxDR6XCN7rIaWlwzs2xkoaypE5mBV8FkPYMTI?= =?utf-8?q?y65lkWoEYCP8h3Lzajc/lVzJbrdkpN019UByvPtHPAgRO4ETqdu+PkYoAUycxqInZ?= =?utf-8?q?I7V4RCpI1I9l0WfHtI0cUjFkrmJKCnj4+iOxP+8558bHLkAHRaVCXmB24gUNuoVhM?= =?utf-8?q?IrU0ouK0a5s+q3vw/DRGdSAxmtQQB+IDEzP02Q1HpGhkC7IyvNm8RzF1zcNGSbzgS?= =?utf-8?q?v0Pm3aseKSQ=3D=3D?=
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; =?utf-8?q?h=3DFrom=3ADate=3ASubject=3AMessage-ID=3AContent-Typ?= =?utf-8?q?e=3AMIME-Version=3AX-MS-Exchange-SenderADCheck=3B?= =?utf-8?q?bh=3Db//fiwCTZGbNBFm3FA5O2VatHtshWyHZzcbU/KTY9UI=3D=3B_b=3DILAk6d?= =?utf-8?q?1GpHzGC97eT8omLzv99yaxTnayVb+7i6fwGJq4dOg91K0uIq/ErxXFK5P3ZcRA6Kr?= =?utf-8?q?y3LeF65F/Pph65jLyUscoOAlvwPZRosLuQWjT7WNXrhHkJsfB0q889ZO5Ou0xPQkQ?= =?utf-8?q?EyxaZujrquAY9OaleiW/kfnzRbJnEpZC5mo=3D?=
Received: from DB7PR07MB4011.eurprd07.prod.outlook.com (52.134.97.155) by DB7PR07MB4999.eurprd07.prod.outlook.com (20.177.193.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.7; Fri, 20 Mar 2020 16:45:23 +0000
Received: from DB7PR07MB4011.eurprd07.prod.outlook.com ([fe80::15cf:dc81:c6f4:aa0c]) by DB7PR07MB4011.eurprd07.prod.outlook.com ([fe80::15cf:dc81:c6f4:aa0c%7]) with mapi id 15.20.2835.013; Fri, 20 Mar 2020 16:45:23 +0000
From: =?utf-8?B?QmFsw6F6cyBMZW5neWVs?= <balazs.lengyel@ericsson.com>
To: Kent Watsen <kent+ietf@watsen.net>
CC: "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: yang-instance-file-format-10 uploaded [was: RE: [netmod] WG Last Call: draft-ietf-netmod-yang-instance-file-format-06 to -07]
Thread-Index: AdX+1urCxjCYh57CRUWeVgp/vZEhoA==
Date: Fri, 20 Mar 2020 16:45:23 +0000
Message-ID: =?utf-8?q?=3CDB7PR07MB40110D439D8DCBCAB4DCF54DF0F50=40DB7PR07MB4?= =?utf-8?q?011=2Eeurprd07=2Eprod=2Eoutlook=2Ecom=3E?=
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.lengyel@ericsson.com;
x-originating-ip: [129.192.74.23]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 431fd241-0ee9-4116-e37e-08d7ccee15c8
x-ms-traffictypediagnostic: DB7PR07MB4999:
x-microsoft-antispam-prvs: =?utf-8?q?=3CDB7PR07MB4999D45E817990520343B791F0F?= =?utf-8?q?50=40DB7PR07MB4999=2Eeurprd07=2Eprod=2Eoutlook=2Ecom=3E?=
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 03484C0ABF
x-forefront-antispam-report: SFV:NSPM; =?utf-8?q?SFS=3A=2810009020=29=284636?= =?utf-8?b?MDA5KSgzNDYwMDIpKDM5NjAwMykoMzk4NjA0MDAwMDIpKDM2NjAwNCkoMzc2?= =?utf-8?b?MDAyKSgxMzYwMDMpKDE5OTAwNCkoNjY1NzQwMTIpKDI2MDA1KSgzMTYwMDIpKDcx?= =?utf-8?q?200400001=29=2866446008=29=28478600001=29=2866946007=29=286475600?= =?utf-8?b?OCkoOTY2MDA1KSg2NjYxNjAwOSkoNTI1MzYwMTQpKDc2OTYwMDUpKDE4NjAwMyko?= =?utf-8?q?66556008=29=2885182001=29=2876116006=29=2866476007=29=2886362001?= =?utf-8?b?KSg0MzI2MDA4KSg5Njg2MDAzKSgzMzY1NjAwMikoODUyMDIwMDMpKDUzNTQ2?= =?utf-8?b?MDExKSg4MTE1NjAxNCkoODExNjYwMDYpKDg5MzYwMDIpKDY1MDYwMDcpKDI5?= =?utf-8?q?06002=29=288676002=29=2855016002=29=285660300002=29=3B?= DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR07MB4999; H:DB7PR07MB4011.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: =?utf-8?q?WupFd00TxWNwDPYrKUN7Iam2ngFrr3C?= =?utf-8?q?QQ3dT7Rjkiyhc7Cq4d3rqadgZ+KaIlwLRibkCAehjIpd/Stc4T/v+ejtgjYq5gvOZ?= =?utf-8?q?3uJa/fCNzk1PAwwakS9UZKVMwYyH3KQ+Slx7Wr75w481WbpEVGnN7lm/2yj+TeZD3?= =?utf-8?q?nHvx64Bhmuh2zxdcHIGFmmN7oWpUAXFy2zrw+xENNTZ21Io0VEASrOHL8k2vbTWKY?= =?utf-8?q?mDno9nmQd+IZR7NhTn3xTFtyOxmnjd5nS2YIjDxE/tVGcOeqTjU4CmZtoxhg+R8wH?= =?utf-8?q?abf0WNS2X9FbsTPDRkkhYe9lmOytQogOXw8uKL++RZ3ZAHkLaZf1vJZEbWlJMa0Al?= =?utf-8?q?wROzBx7Hnx1rxBE2NWsmMpZet1gToPFr/u2UggkvnMwhdJe53mbUB7pEZaFYhmbT4?= =?utf-8?q?w0oN1Q7N56T+0H5+mhUTNUEUbooD9fPD9hq3ROCvXiJXtDSLAD106JhclaTWRFq7h?= =?utf-8?q?pmt1yjNzMu7VJHJRhZ/tfh1SbXiZaKKwmH+Lhfsf7Qwrg+sA=3D=3D?=
x-ms-exchange-antispam-messagedata: =?utf-8?q?BBYvWTt2/L4mLnz9PqbkN8zPCoaMke?= =?utf-8?q?2qYw/aE7R23HzOiomHyD+ny8/fnfPs269AtSrqjKabh8RSx9N6rwoUmeDhemUOUsO?= =?utf-8?q?reIDPJdvWd/OyvyLBC55jAVxtij7R/AvQvAqqpzpfzg2CMf7TfKrsyw=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_0074_01D5FEDF.53EE5CB0"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 431fd241-0ee9-4116-e37e-08d7ccee15c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2020 16:45:23.4724 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: =?utf-8?q?/pzVQci0nnWX5wsing6Dd?= =?utf-8?q?yvi0fBBmy1LZkEPnSIUfDJi6uqiA1vfJk8w/+/r011IEXWG2rtIB48lg38ucqYlaQ?= =?utf-8?q?Vg6+Xnjd4HMu10YGriLZ4=3D?=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB4999
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/qOVCpeIQIa03HjDEhsVDhQ3rPtQ>
Subject: [netmod] yang-instance-file-format-10 uploaded [was: RE: WG Last Call: draft-ietf-netmod-yang-instance-file-format-06 to -07]
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Mar 2020 16:45:41 -0000

Hello Kent,
Thanks for the comments. Updated all in -10 version. See below as BALAZS2.
(XML2RFC at this point does not yet accept  netmod-yang-module-versioning. That needs to be changed later.)
Regards Balazs

-----Original Message-----
From: Kent Watsen <kent+ietf@watsen.net> 
Sent: 2020. március 18., szerda 3:58
To: Balázs Lengyel <balazs.lengyel@ericsson.com>
Cc: netmod@ietf.org
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-yang-instance-file-format-06 to -07


> Have the examples in the draft validated against the YANG module?
> 
> BALAZS: Only manually. How do you validate samples conforming to a yang data structure ?

Hmmm, seeing that the examples are still not valid, here goes:

	Until such time as tools support validating structure-data-ext, 
	one can rewrite the YANG module via s/sx:structure/container/ 
	and perform the validation against the resulting YANG module.
BALAZS2: Validated with yanglint

> Please review the Normative/Informative status of the references.
> 
> Not looking carefully, but RFCs 2119 and 8174 should be Normative,
> 
> and I think RFCs 3688 and 6020 should be Informative, right?
> 
> BALAZS: OK, changed in rev 08

Did you check all the other references too?  (I’m trying to save having to do another roundtrip when I do the shepherd writeup...)
BALAZS2: I believe yes. Do you see any other problem ?


> All of the “import” statements in the YANG module are missing a
> “reference” statement.
> BALAZS:
> Added:
> rfc6991 for types added.
> Already present:
> rfc8342 for datastores
> ietf-netmod-yang-data-ext for ietf-yang-structure-ext

Again, all the “import” statements in the YANG module are missing a “reference” statement.
BALAZS2: OK.  Sorry I misunderstood the comment earlier it. Corrected. 
> 
> Please add a statement to the Introduction regarding why the module

> Isn’t compliant with NMDA.
> BALAZS: Sorry, don’t understand. Why is this not compliant with NMDA ?
> IMHO it is NMDA compliant, or rather it  has nothing to do with NDMA.

Either way but, per https://tools.ietf.org/html/rfc8407#section-3.5, the statement should be in the Introduction section.
BALAZS2: Done


> The tree diagram does not adhere to the syntax described in 
> draft-ietf-netmod-yang-data-ext.  
> BALAZS: OK I try, but what actually is the problem? Any help would be really appreciated.

I was looking at the “+—rw”, which can’t be right because yang-data is not “configuration”...

> Sadly
> pyang -p ../ietfYams ietf-yang-instance-data\@2020-03-06.yang -f tree --tree-print-yang-data --tree-print-yang-data
> doesn’t print out anything, so I am handcrafting.

`pyang`  supports the old/RFC8040 “rc:yang-data” statement; it hasn’t been updated to support the new "sx:structure” statement.
BALAZS2: Done, after adding a top level container (which is not needed in structure) and some copy-paste+editing.


> I just updated pyang from git. Any idea why this doesn’t work for me?
> It would be good if YangValidator would print out the tree. At some point it did. Not now. :-(

First, use the s/sx:structure/container/ trick mentioned above.

Then s/+--rw/+—/.

Then review https://tools.ietf.org/html/draft-ietf-netmod-yang-data-ext-05#section-3 and tweak accordingly until all is good.

BALAZS2: Done, I hope

NEW: looking at the new "format-version”, please add a pattern statement to constrain the string values appropriately.  Hint, it’s half a "date-and-time” type...

BALAZS2: Done