Re: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext version 4

Martin Bjorklund <mbj@tail-f.com> Thu, 03 October 2019 11:16 UTC

Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A2645120026; Thu, 3 Oct 2019 04:16:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SFE_qs-FnhMD; Thu, 3 Oct 2019 04:16:22 -0700 (PDT)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id DF1EB12006A; Thu, 3 Oct 2019 04:16:21 -0700 (PDT)
Received: from localhost (unknown [173.38.220.41]) by mail.tail-f.com (Postfix) with ESMTPSA id 4EFE91AE018A; Thu, 3 Oct 2019 13:16:18 +0200 (CEST)
Date: Thu, 03 Oct 2019 13:15:52 +0200 (CEST)
Message-Id: <20191003.131552.11890873935623292.mbj@tail-f.com>
To: rwilton@cisco.com
Cc: joelja@bogus.com, draft-ietf-netmod-yang-data-ext@ietf.org, netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <MN2PR11MB436626F5D5BF2869BEF18C83B59D0@MN2PR11MB4366.namprd11.prod.outlook.com>
References: <CBBD7EDD-0B53-4720-B76B-7932655FF27A@bogus.com> <MN2PR11MB436626F5D5BF2869BEF18C83B59D0@MN2PR11MB4366.namprd11.prod.outlook.com>
X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/VQiG80SnCMf_veZhodpuYs3RX-E>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext version 4
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Oct 2019 11:16:24 -0000

Hi,

Thank you for the review.  Comments inline.

"Rob Wilton (rwilton)" <rwilton@cisco.com>; wrote:
> Hi,
> 
> I've reviewed this document, and other than 2 minor nits, I believe
> that it is ready for publication. 
> 
> Two minor comments:
> 
> 
>   1.  Section 1.1.1 NMDA.  There should be a comma before "and are
>   not redefined here".

Fixed.

>   2.  I wonder whether it would be useful to have a sentence in the
>   "Definitions" section that defines how a structure is encoded.
>   Although I appreciate that this is specified in the YANG module
>   itself.  An alternative could be a forward reference from the
>   Definitions section to the YANG module.  This could also cover the
>   Xpath behaviour as well.

This is probably a good idea.  Perhaps also add a small example:


   A YANG data structure is encoded in the same way as an "anydata"
   node.  This means that the name of the structure is encoded as a
   "container", with the instantiated children encoded as child nodes to
   this node.  For example, this structure:

     module example-errors {
       ...

       sx:structure my-error {
         leaf error-number {
           type int;
         }
       }
     }

   can be encoded in JSON as:

     "example-module:my-error": {
       "error-number": 131
     }



/martin



> 
> Thanks,
> Rob
> 
> 
> From: netmod <netmod-bounces@ietf.org>; On Behalf Of Joel Jaeggli
> Sent: 27 September 2019 06:32
> To: NETMOD Working Group <netmod@ietf.org>;
> Subject: [netmod] WG Last Call: draft-ietf-netmod-yang-data-ext version 4
> 
> All,
> 
> This starts a two week working group last call for  draft-ietf-netmod-yang-data-ext-04
> 
> The working group last call ends on  Friday October 11th 2019.  Please send your comments to the working group mailing list.
> 
> Positive comments, e.g., "I've reviewed this document and believe it is ready for publication", are welcome!  This is useful and important, even from authors.
> 
> 
> https://tools.ietf.org/html/draft-ietf-netmod-yang-data-ext-04
> 
> 
> The diff from 03, produced prior to IETF 105 is available here:
> 
> 
> https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-netmod-yang-data-ext-04.txt
> 
> 
> Thanks
> Joel
> 
>