Re: [netmod] yanglint and implemented versus imported YANG modules

Radek Krejčí <rkrejci@cesnet.cz> Tue, 07 March 2017 09:54 UTC

Return-Path: <rkrejci@cesnet.cz>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F0F20129579 for <netmod@ietfa.amsl.com>; Tue, 7 Mar 2017 01:54:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.3
X-Spam-Level:
X-Spam-Status: No, score=-4.3 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cesnet.cz
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 60jmvFwxYJYz for <netmod@ietfa.amsl.com>; Tue, 7 Mar 2017 01:54:57 -0800 (PST)
Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B4A012947C for <netmod@ietf.org>; Tue, 7 Mar 2017 01:54:57 -0800 (PST)
Received: from [IPv6:2001:67c:1220:80c:921b:eff:fe59:4360] (unknown [IPv6:2001:67c:1220:80c:921b:eff:fe59:4360]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id A645120088; Tue, 7 Mar 2017 10:54:55 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2; t=1488880495; bh=rMi9lAoDj2OD2qdPzZ5DEo1ySdad6KRgo/CUdKKhHMk=; h=Subject:To:References:From:Date:In-Reply-To; b=GrBS5uF09XuTAfoyr+F4kL5XsG9eDlaKi+8PzqYXDJx+0NnD2Qdx6h1boATQJxdpy ECFkMVbjvQR/HuYKpClC9zntk+UlxDOTNVX3oZfxTkJx2BWaS54dMGR12VEp9KT162 rL+mQkQYIh1ny9kzry/EoYp4doAKU9p+ckui5WFc=
To: Ladislav Lhotka <lhotka@nic.cz>, Robert Wilton <rwilton@cisco.com>, William Lupton <wlupton@broadband-forum.org>, netmod@ietf.org
References: <1C757F2F-D47A-4688-845D-ACCE04AE56D1@broadband-forum.org> <9ceda4b1-6297-bab4-7c4e-da29bbea6890@cisco.com> <m2fuipcu2c.fsf@nic.cz>
From: =?UTF-8?B?UmFkZWsgS3JlasSNw60=?= <rkrejci@cesnet.cz>
Message-ID: <d1799253-a159-d410-fbbf-9edf4daaf716@cesnet.cz>
Date: Tue, 7 Mar 2017 10:54:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <m2fuipcu2c.fsf@nic.cz>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/ZPuHERCv4TZBfKknzOGkTB1Nmcw>
Subject: Re: [netmod] yanglint and implemented versus imported YANG modules
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Mar 2017 09:54:59 -0000

Hi Lada,

Dne 7.3.2017 v 10:30 Ladislav Lhotka napsal(a):
> Robert Wilton <rwilton@cisco.com> writes:
>
>> Hi William,
>>
>> I think that what yanglint is doing here is sane, i.e. I think that its 
>> interpretation/split between imported vs implemented modules is 
>> supported by the YANG RFC.
>>
>> However, for validation purposes it seems that it would be useful if 
>> yanglint had an option to assume that all imported modules are 
>> implicitly implemented without requiring them to be explicitly
>> specified.
> This will fail if a module just wants to use a grouping or typedef from
> an imported module but not data nodes that may also be there. 

but does it affect the validation of the module?

> It is exactly the problem that I mentioned in the discussion about
> NETMOD charter: we need a way to specify a complete data model. In my
> YANG/I-D development environment [1], a hello XML file is used for this
> purpose.
>
> Lada
>
> [1] https://github.com/llhotka/YANG-I-D

we have this feature in TODO for yanglint, but I'm afraid that it does not solve the issue - even now the script can read some additional file with the specification which modules are expected to be loaded before the module being validated (i.e. which imported module is supposed to be implemented). The root of the issue is that this information is not part of the importing module itself.

Radek

>
>> Thanks,
>> Rob
>>
>>
>> On 06/03/2017 16:44, William Lupton wrote:
>>> All,
>>>
>>> This message arose from a yang-multicast@ietf.org 
>>> <mailto:yang-multicast@ietf.org> “draft-ietf-pim-igmp-mld-yang-02.txt: 
>>> YANG compilation isuse” (sic) thread 
>>> <https://www.ietf.org/mail-archive/web/yang-multicast/current/threads.html#00232> initiated 
>>> by Benoit.
>>>
>>> I thought it would be useful for NETMOD to see the part of the 
>>> discussion that relates to implemented versus imported YANG modules.
>>>
>>>  1. Benoit Claise reported this warning:
>>>       * warn: Schema node "ietf-ip:ipv4" not found
>>>         (/ietf-interfaces:interfaces/ietf-interfaces:interface[ietf-interfaces:name
>>>         = current()]/ietf-ip:ipv4)
>>>  2. Radek Krejčí replied:
>>>       * These warnings are printed because in yanglint, until
>>>         explicitly stated, the imported modules (such as
>>>         ietf-interfaces and ietf-ip), are supposed to be only
>>>         imported, not implemented. The data nodes in imported schemas
>>>         are not available, which is the reason of these warnings.
>>>  3. William Lupton (that’s me!) asked / commented:
>>>       * Why are the complaints only about ip:ipv4 (etc) and not about
>>>         if:interfaces (etc), which are also referenced in the must
>>>         statements?
>>>       * This makes it hard for an automated tool (such as Benoit’s)
>>>         because it needs to know which other YANG files to process in
>>>         addition to the “file of interest”.
>>>  4. Radek Krejčí replied:
>>>       * According to RFC 7950, sec 5.6.6 (3rd paragraph) [ED: 5.6.5?],
>>>         when an implemented module augments another module
>>>         (ietf-interfaces), the augmented module MUST be also
>>>         implemented. So libyang automatically changes the augmented
>>>         module from imported to the implemented. The same rule applies
>>>         also in case of referring a module in path (leafref) and
>>>         by deviating a module. But it does not apply when a module
>>>         data is used in must or when conditions. That's the reason why
>>>         it complains just about ietf-ip and not about ietf-interfaces.
>>>       * YANG actually does not provide a way to specify that a
>>>         particular import is also expected to be implemented.
>>>         Therefore, libyang needs some help with setting modules
>>>         implemented - all the explicitly loaded modules are supposed
>>>         to be implemented, if the module is just implicitly loaded
>>>         from the search directory and user did not expressed that it
>>>         is supposed to be implemented, it is kept only imported to
>>>         provide groupings or type definitions
>>>  5. Benoit Claise asked (referring to my reference to automated tools):
>>>       * Would it be possible to improve the warning (and the related
>>>         test, by testing implemented instead of import), basically
>>>         telling that the module itself is fine?
>>>
>>>
>>> I’m interested to know that NETMOD thinks about this distinction 
>>> between implemented versus imported (in the absence of any instance 
>>> documents). I guess my (maybe naive) view is that if all I’m doing is 
>>> checking for errors in my YANG model then I don’t care about this. If 
>>> my YANG is good I want to see no warnings or errors, and if it’s bad 
>>> then I want to be told this (and why).
>>>
>>> Thanks,
>>> William
>>>
>>>
>>> _______________________________________________
>>> netmod mailing list
>>> netmod@ietf.org
>>> https://www.ietf.org/mailman/listinfo/netmod
>> _______________________________________________
>> netmod mailing list
>> netmod@ietf.org
>> https://www.ietf.org/mailman/listinfo/netmod