Re: [netmod] example modules in 6087bis

Mahesh Jethanandani <mjethanandani@gmail.com> Thu, 26 January 2017 01:59 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 759F2129430 for <netmod@ietfa.amsl.com>; Wed, 25 Jan 2017 17:59:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 70uEgKmqoWj7 for <netmod@ietfa.amsl.com>; Wed, 25 Jan 2017 17:59:05 -0800 (PST)
Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC95D129410 for <netmod@ietf.org>; Wed, 25 Jan 2017 17:59:05 -0800 (PST)
Received: by mail-pf0-x241.google.com with SMTP id 19so15449106pfo.3 for <netmod@ietf.org>; Wed, 25 Jan 2017 17:59:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=QtL7GuzIqsbb7XGc2rWlCZMkdzLM7sZdG5NzLDR/o5A=; b=bswzri1khjTD7++0v8bADX0XijS4m8l3FgJlmg+M0Bzyw9q+38NzqXYp1XcE6Vg/Sm Qn6f1QyC03J0rgGBfi7UimFOhDQCNup2UUGX1xCijPi/RoSSM+8Jjv0+r+2YOeu9IqEg 2qmWsFAO0F677Jb9w6uL0XprAAqR+XIXpgIHbafqjxaZF/bH667hST5XxAGlzc62cyai j4BUPFc+Ba5Y32D3A0Y8lEIw4EC27NUchKzSoLcTfaPu3a6+Nypuaa4nzc1YJPScEPYy yToBGmOHpj7OzS6ol+6UgkKIL062pStb6TyAbu3N0BB4xhDRHZmeeY2Rbt4LjjRLO5MY X7XA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=QtL7GuzIqsbb7XGc2rWlCZMkdzLM7sZdG5NzLDR/o5A=; b=nY/I1kQdt5/YFGrvMh8CLkzB9ycSqS/BK4RAoksaQC5JPgVUs2So2uDhjdDYTxdymq eyb2GEG+7/B8SPuAAcHvkDuOnG9O3GQRpFFBdhMBJo6sYtG31+yMXsBv3H5wWEcQ4lnv CJ9PZlg8pNLL8To2Cct5gS1zSu/UIl3PspWGVCO+NE3mSrf6dGHjk/L00WfdROT3RGMG Z1XAYkglA8DnCNBA5/zpDOnHuAoFC0/eoqIJHJt6bba/ewbC687pZLhU5Dy8XUyQ7vI4 I2JV17Si62PtiXJtX0qQLlFM7Ax93+KCGAacii4nZu9trmw3hjDGlFkRi8sSEg6UEFeX NF+A==
X-Gm-Message-State: AIkVDXL0/SEpCpZySjHWiEY0f81mqg5el7OlbtpSIKdYPA0HSIjnCTwIyjdxnafxexPS0g==
X-Received: by 10.99.0.196 with SMTP id 187mr242568pga.139.1485395945088; Wed, 25 Jan 2017 17:59:05 -0800 (PST)
Received: from [10.24.52.82] ([128.107.241.184]) by smtp.gmail.com with ESMTPSA id 199sm23604pfu.91.2017.01.25.17.59.03 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Jan 2017 17:59:03 -0800 (PST)
Content-Type: multipart/alternative; boundary="Apple-Mail=_146C265C-F880-4A47-BD72-ECA2B441FC05"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Mahesh Jethanandani <mjethanandani@gmail.com>
In-Reply-To: <aae34c05-df2e-1567-9b38-c269b9e79836@cisco.com>
Date: Wed, 25 Jan 2017 17:59:01 -0800
Message-Id: <9DCB66AF-FB14-4AA8-A899-67E09853B9B6@gmail.com>
References: <CABCOCHRkFwDrQrGqk61nh-3fc+emtJEshdEMqA+G4r2YaKxwdg@mail.gmail.com> <003354d9-841f-37b2-a594-6e9983110984@cisco.com> <093ED4A3-081D-418A-B233-E75148133635@juniper.net> <20170124.202630.843995888894291234.mbj@tail-f.com> <aae34c05-df2e-1567-9b38-c269b9e79836@cisco.com>
To: Benoit Claise <bclaise@cisco.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/bxyyJp9-6qmexmf-7q0P2ub7FXs>
Cc: netmod@ietf.org
Subject: Re: [netmod] example modules in 6087bis
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jan 2017 01:59:07 -0000

> On Jan 25, 2017, at 6:18 AM, Benoit Claise <bclaise@cisco.com> wrote:
> 
> On 1/24/2017 8:26 PM, Martin Bjorklund wrote:
>> Kent Watsen <kwatsen@juniper.net> <mailto:kwatsen@juniper.net> wrote:
>>> Hi Andy,
>>> 
>>> I think this discussion has come to a head.  Please submit an updated 6087bis as soon as you can.  Some comments:
>>> 
>>> 
>>> 1) on the 3rd line below, should the text clarify that --ietf is only for IETF modules? 
Yes, and in addition yangvalidator.com <http://yangvalidator.com/> should stop complaining about module names and namespaces for modules that belong to other SDOs.

mef-cfm.yang:1: warning: RFC 6087: 4.1: the module name should start with one of the strings "ietf-" or "iana-"
mef-cfm.yang:3: warning: RFC 6087: 4.8: namespace value should be "urn:ietf:params:xml:ns:yang:mef-cfm"

>>>  Also, how does the MUST here jive with the SHOULD in Section 4.10?
>>> 
>>>    - MUST use CODE BEGINS for a real module
>>>    - MUST NOT use CODE BEGINS for an example module
>>>    - MUST pass pyang --ietf for a real module
>>>    - MUST pass pyang for example module
>>> 
>>> 
>>> 2) related to #1, Section 5 says "In general, modules in IETF Standards Track specifications MUST comply with all syntactic and semantic requirements of YANG [RFC7950]."
>>> 
>>>    First, what does "In general...MUST" mean?  - maybe the 
>>>    sentence should start with "Modules in IETF..."?
>>> 
>>>    Second, can we add a statement for non-IETF SDOs that might
>>>    have other conventions/restrictions?  Would we recommend
>>>    --strict for starters, until they can add an SDO-specific
>>>    flag (e.g., --<sdo>) to pyang?
>> We wouldn't talk about any specific tool; 
> Note that the document does already.
> See section 4.4:
> The 'pyang' compiler can be used to produce the tree diagram, using
>    the '-f tree' command line parameter.
> 
>    If the YANG module is comprised of groupings only, then the tree
>    diagram SHOULD contain the groupings.  The 'pyang' compiler can be
>    used to produce a tree diagram with groupings using the '-f tree
>    --tree-print-groupings" command line parameters.
> Reviewing this yesterday, I was wondering: why not speak of yanglint?
> In discussion with Radek about this, he mentioned:
> yes, libyang supports the tree format. However, in some details it differs from pyang:
> 
> - instead of the module prefixes, we use module names to avoid prefix collisions.
> - additionally, the default values (of the the leaf/leaf-lists/choice) are printed
> regards, Benoit
>> we'd just talk about
>> compliance with this document.  Other SDOs will have to decide on
>> their own rules, but we can suggest that they use all our rules except
>> the naming convention for modules and namespaces.
>> 
>> 
>>> 3) The first paragraph in Section 4.6 isn't clear, how about this?
>>> 
>>>  OLD
>>>    This section contains the module(s) defined by the specification.
>>>    These modules SHOULD be written using the YANG syntax defined in
>>>    [RFC7950].  YANG 1.0 [RFC6020] MAY be used if no YANG 1.1 constructs
>>>    or semantics are needed in the module.
>>> 
>>>  NEW
>>>    This section contains the module(s) defined by the YANG specification.
>>>    These modules SHOULD be written using the YANG 1.1 [RFC7950] syntax;
>>>    YANG 1.0 [RFC6020] syntax MAY be used if no YANG 1.1 constructs
>>>    or semantics are needed in the module.
>>> 
>>>  Note: this reads better, but I wonder, since YANG 1.0 syntax is a
>>>  subset of YANG 1.1 syntax, what is really being said here? - that
>>>  yang-version statement is optional?  Or maybe, instead of focusing
>>>  on syntax, the statement should regard the version of YANG used?
>> The point is that yang-version 1.1 SHOULD be used, and yang-version 1
>> MAY be used.
>> 
>>> 4) Lastly, picking up on this discussion:
>>> 
>>>      https://www.ietf.org/mail-archive/web/netmod/current/msg17277.html <https://www.ietf.org/mail-archive/web/netmod/current/msg17277.html>.
>>> 
>>>    can add an Informational reference to RFC 4151 in Section 5.9?
>>>    Maybe something like this:
>>> 
>>>  OLD
>>> 
>>>    The following examples are for non-Standards-Track modules.  The
>>>    domain "example.com" SHOULD be used in all namespace URIs for example
>>>    modules.
>>> 
>>>        http://example.com/ns/example-interfaces <http://example.com/ns/example-interfaces>
>>> 
>>>        http://example.com/ns/example-system <http://example.com/ns/example-system>
>>> 
>>>  NEW
>>> 
>>>    The following URIs exemplify what might be used by non Standards
>>>    Track modules.  Note that the domain "example.com" SHOULD be used
>>>    by example modules in IETF drafts.
>>> 
>>>    Example URIs using URLs per RFC 3986 [RFC3986]:
>>> 
>>>        http://example.com/ns/example-interfaces <http://example.com/ns/example-interfaces>
>>>        http://example.com/ns/example-system <http://example.com/ns/example-system>
>>> 
>>>    Example URIs using tags per RFC 4151 [RFC4151]:
>>>  
>>>        tag:example.com,2017:example-interfaces
>>>        tag:example.com,2017:example-system
>> I would like to see urn:example:<module-name>, that's what I usually
>> use here.
>> 
>> 
>> /martin
>> .
>> 
> 
> _______________________________________________
> netmod mailing list
> netmod@ietf.org
> https://www.ietf.org/mailman/listinfo/netmod

Mahesh Jethanandani
mjethanandani@gmail.com