Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7277bis-00
Martin Bjorklund <mbj@tail-f.com> Wed, 13 December 2017 14:48 UTC
Return-Path: <mbj@tail-f.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F2FD2126C3D for <netmod@ietfa.amsl.com>; Wed, 13 Dec 2017 06:48:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ED4KdGbGGp1y for <netmod@ietfa.amsl.com>; Wed, 13 Dec 2017 06:48:58 -0800 (PST)
Received: from mail.tail-f.com (mail.tail-f.com [46.21.102.45]) by ietfa.amsl.com (Postfix) with ESMTP id D3C32124B0A for <netmod@ietf.org>; Wed, 13 Dec 2017 06:48:57 -0800 (PST)
Received: from localhost (unknown [173.38.220.60]) by mail.tail-f.com (Postfix) with ESMTPSA id A2CBD1AE02BD; Wed, 13 Dec 2017 15:48:56 +0100 (CET)
Date: Wed, 13 Dec 2017 15:47:34 +0100
Message-Id: <20171213.154734.273404682004037071.mbj@tail-f.com>
To: vladimir@transpacket.com
Cc: kwatsen@juniper.net, netmod@ietf.org
From: Martin Bjorklund <mbj@tail-f.com>
In-Reply-To: <a63ebf89-fc0b-5833-6789-8029f27c8e4a@transpacket.com>
References: <296363B7-40FF-4FAC-94F9-A7655CD0D111@juniper.net> <975828fb-cd82-84fb-540b-58b8012872b5@transpacket.com> <a63ebf89-fc0b-5833-6789-8029f27c8e4a@transpacket.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/cAVm8RLB1COMJDfSnmGzvSVOWqQ>
Subject: Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7277bis-00
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Dec 2017 14:49:00 -0000
Hi, Thanks for reporting this. I'll add the missing origin. But why did you think forwarding and mtu should be removed? In fact, I think I missed <enabled>, so here's my diff: --- ex-get-data-reply.xml +++ ex-get-data-reply.xml @@ -13,6 +13,7 @@ <!-- other parameters from ietf-interfaces omitted --> <ipv4 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip"> + <enabled>true</enabled> <forwarding>false</forwarding> <mtu>1500</mtu> <address> @@ -20,12 +21,13 @@ <prefix-length>24</prefix-length> <origin>static</origin> </address> - <neighbor> + <neighbor or:origin="or:learned"> <ip>192.0.2.2</ip> <link-layer-address><!-- PPL -->00:01:02:03:04:05</link-layer-address> </neighbor> </ipv4> <ipv6 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip"> + <enabled>true</enabled> <forwarding>false</forwarding> <mtu>1280</mtu> <address> /martin Vladimir Vassilev <vladimir@transpacket.com> wrote: > Hello, > > The previous post was intended for the rfc7223bis Last Call (wrong > subject line). > > I just completed similar validation through a testcase for the > examples in rfc7277bis ("Appendix A. Example: NETCONF <get-config> > reply" and "Appendix B. Example: NETCONF <get-data> Reply") > > Here there are some inconsistencies between the <get-config> output > and the expected <get-data> output. A missing origin bug is probably > more significant then the rest. The following patch fixes the > inconsistencies and the testcase passes: > > --- before.txt 2017-12-12 20:39:09.037576425 +0100 > +++ after.txt 2017-12-12 20:37:46.425656680 +0100 > @@ -7,14 +7,12 @@ > <type>ianaift:ethernetCsmacd</type> > <!-- other parameters from ietf-interfaces omitted --> > <ipv4 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip"> > - <forwarding>false</forwarding> > - <mtu>1500</mtu> > <address> > <ip>192.0.2.1</ip> > <prefix-length>24</prefix-length> > <origin>static</origin> > </address> > - <neighbor> > + <neighbor or:origin="or:learned"> > <ip>192.0.2.2</ip> > <link-layer-address> > 00:01:02:03:04:05 > @@ -22,7 +20,6 @@ > </neighbor> > </ipv4> > <ipv6 xmlns="urn:ietf:params:xml:ns:yang:ietf-ip"> > - <forwarding>false</forwarding> > <mtu>1280</mtu> > <address> > <ip>2001:db8::10</ip> > > > In contrast to rfc7223bis-00 I have not reviewed rfc7277bis-00 and > this is only a report of a detected issue. > > Vladimir > > On 12/11/2017 05:35 PM, Vladimir Vassilev wrote: > > Hello, > > > > I've reviewed this document and believe it is ready for publication. > > > > The focus of my review this time was on validating the module and the > > example modules and example data through running code. I implemented > > NMDA for the open source tools we use and added a testcase that > > reproduces the result specified in "Appendix E. Example: NETCONF > > <get-data> Reply" after loading the configuration specified in > > "Appendix D. Example: NETCONF <get-config> Reply" and providing the > > config false; data and system originated configuration as needed. I > > can confirm the implementation validated the example modules and the > > example data producing identical output. > > > > IMO the examples are demonstrating well the concept of NMDA and its > > application for the ietf-interfaces module. > > > > I had an issue with a bug in ietf-netconf-datastores@2017-08-24.yang I > > had to fix in order to use the <get-data> RPC. The bug is already > > reported on the mailing-list. > > > > diff ietf-patched/ietf-netconf-datastores@2017-08-24.yang > > ietf-draft/ietf-netconf-datastores@2017-08-24.yang > > 140c140 > > < when 'derived-from-or-self(../datastore, "ds:operational")'; > > --- > >> when 'derived-from-or-self(../datastore, "or:operational")'; > > > > Vladimir > > > > > > On 11/28/2017 08:29 PM, Kent Watsen wrote: > >> All, > >> > >> This starts a two-week working group last call on > >> draft-ietf-netmod-rfc7277bis-00. > >> > >> Please recall that this update's intention is to > >> modify the YANG module to be in line with the NMDA > >> guidelines [1]. Reviewing the diff between the two > >> drafts [2] should reveal just this. > >> > >> The working group last call ends on December 12. > >> Please send your comments to the netmod mailing list. > >> > >> Positive comments, e.g., "I've reviewed this document > >> and believe it is ready for publication", are welcome! > >> This is useful and important, even from authors. > >> > >> [1] https://tools.ietf.org/html/draft-dsdt-nmda-guidelines-01 > >> [2] > >> https://tools.ietf.org/rfcdiff?url2=draft-ietf-netmod-rfc7277bis-00.txt > >> > >> Thank you, > >> Netmod Chairs > >> > >> _______________________________________________ > >> netmod mailing list > >> netmod@ietf.org > >> https://www.ietf.org/mailman/listinfo/netmod > > > > _______________________________________________ > > netmod mailing list > > netmod@ietf.org > > https://www.ietf.org/mailman/listinfo/netmod > > _______________________________________________ > netmod mailing list > netmod@ietf.org > https://www.ietf.org/mailman/listinfo/netmod
- [netmod] WG Last Call: draft-ietf-netmod-rfc7277b… Kent Watsen
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Acee Lindem (acee)
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Alex Campbell
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Qin Wu
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Martin Bjorklund
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Eric Voit (evoit)
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Martin Bjorklund
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Kent Watsen
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Martin Bjorklund
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Vladimir Vassilev
- Re: [netmod] WG Last Call: draft-ietf-netmod-rfc7… Martin Bjorklund