[netmod] Roman Danyliw's No Objection on draft-ietf-netmod-yang-instance-file-format-20: (with COMMENT)
Roman Danyliw via Datatracker <noreply@ietf.org> Tue, 05 October 2021 20:44 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: netmod@ietf.org
Delivered-To: netmod@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 511363A0D52; Tue, 5 Oct 2021 13:44:42 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Roman Danyliw via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-netmod-yang-instance-file-format@ietf.org, netmod-chairs@ietf.org, netmod@ietf.org, Kent Watsen <kent+ietf@watsen.net>, kent+ietf@watsen.net
X-Test-IDTracker: no
X-IETF-IDTracker: 7.38.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Roman Danyliw <rdd@cert.org>
Message-ID: <163346668230.2566.10168888768471053540@ietfa.amsl.com>
Date: Tue, 05 Oct 2021 13:44:42 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/hLgPHuOl-myr8YI1RsO_tnW85ME>
Subject: [netmod] Roman Danyliw's No Objection on draft-ietf-netmod-yang-instance-file-format-20: (with COMMENT)
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Oct 2021 20:44:43 -0000
Roman Danyliw has entered the following ballot position for draft-ietf-netmod-yang-instance-file-format-20: No Objection When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/blog/handling-iesg-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-netmod-yang-instance-file-format/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- ** Section 2. instance-data-set-name ['@' ( revision-date / timestamp ) ] ( '.xml' / '.json' ) A syntax for an instance data file name is specified with normative language. However, this format is not explained is cited. ** Section 2. Editorial. OLD If the leaf "name" is present in the instance data header, its value SHOULD be used for the "instance-data-set-name" NEW If the leaf "name" is present in the instance data header, its value SHOULD be used for the "instance-data-set-name" in the filename. ** Section 2. Description of the instance data set. The description SHOULD contain information whether and how the data can change during the lifetime of the server I found this definition of the description confusing as Figure 1 – 3 don’t seem to describe “whether and how the data” will change. ** Section 2.1.1. Per “The inline-yang-library anydata data node carries instance data (conforming to ietf-yang-library@2019-01-04)”, please provide a reference to “ietf-yang-library@2019-01-04”. ** Section 4. Please note the risk of using same-schema-as-file, especially if these configs are not integrity protected or received from outside sources. Per https://, there are the risks of loading remote content. Section 7 of RFC3986 is a good reference. Per file://, there are things list directory traversal. ** Section 4. Per “The header part is not security sensitive with one possible exception … the URI method”, I’m not sure that such a strong statement can be made given the lack of application context. For example, the description leaf in the header could include sensitive information, say ‘Latest test router config for new super secret Aqua-Violet flying car project’. This text needs to either have a caution that that this header is "unprotected so do not put in sensitive information unless this file is protected", or clarify that more in the header than the URI could be sensitive. ** Section 4. Thanks for the language trying to create equivalency between the protections of the file and the YANG store that would house it on a live system. Recommend making this text clear to say this applies to both at rest and in motion data. OLD The same kind of handling should be applied, that would be needed for the result of a read operation returning the same data. NEW (roughly) The same kind of handling should be applied to this file at rest and in transit that would be needed for the result of a read operation returning the same data. These in-transit protection mechanisms will also mitigate integrity issues when transporting the file.
- [netmod] Roman Danyliw's No Objection on draft-ie… Roman Danyliw via Datatracker
- Re: [netmod] Roman Danyliw's No Objection on draf… Balázs Lengyel