Re: [netmod] Revision label in filename

[Jan Lindblad <[e-mail]>]

Hi,

> I understand the requirement to not break what's currently working for date in the filename. However we do need something similar to work for revision-label. Having another file with the revision-label embedded in the filename should work. 
> 
> We discussed this issue in yesterday's weekly meeting and a proposal was made to use '@@' as delimiter for revision-label. # was turned down because of its impact on bash.

I did a quick check, and # is only treated as a comment character by bash when preceded by whitespace, i.e. not when used in the middle of a filename => I think we can drop the comment above.

If we want a filename to include multiple kinds of revision markings while keeping the existing tools afloat, implementing the @ notation, that might be achievable by picking some delimiter that is treated as a filename character by existing tools and placing the version label before the @. I.e. with # as the delimiter:

module-or-submodule-name['#'revision-label]['@'date].yang

Many other (combinations of) symbols could work, but they all run the risk of interfering with some tool or vendor internal CI/CD convention. A few examples: double underscore __, tripple dots ..., _ver_, ~, :

/jan


> So:
> module-or-submodule-name['@'date].yang (unchanged)
> module-or-submodule-name['@@'revision-label].yang
> 
> A symlink could be used, or we could have duplicate file contents.
> 
> Regards,
> Reshad.